* Refactor caselibModel::create, and modify its unit test.

module/caselib/model.php

@@ -191,14 +191,12 @@ class caselibModel extends model
             ->checkFlow()
             ->exec();
 
-        if(!dao::isError())
-        {
-            $libID = $this->dao->lastInsertID();
-            $this->loadModel('file')->updateObjectID($this->post->uid, $libID, 'caselib');
-            $this->loadModel('action')->create('caselib', $libID, 'opened');
-            return $libID;
-        }
-        return false;
+        if(dao::isError()) return false;
+
+        $libID = $this->dao->lastInsertID();
+        $this->loadModel('file')->updateObjectID($this->post->uid, $libID, 'caselib');
+        $this->loadModel('action')->create('caselib', $libID, 'opened');
+        return $libID;
     }
 
     /**

module/caselib/test/caselib.class.php

@@ -114,14 +114,14 @@ class caselibTest
      * 创建用例库单元测试方法。
      * Create case lib test function.
      *
-     * @param  array $params
+     * @param  array        $params
      * @access public
      * @return array|object
      */
-    public function createTest($params = array()): array|object
+    public function createTest(array $params = array()): array|object
     {
         $lib = new stdclass();
-        foreach($params as $key => $value) $lib->$key = $value;
+        foreach($params as $key => $value) $lib->{$key} = $value;
 
         $libID = $this->objectModel->create($lib);
 

module/caselib/test/model/create.php

@@ -2,6 +2,10 @@
 <?php
 include dirname(__FILE__, 5) . '/test/lib/init.php';
 include dirname(__FILE__, 2) . '/caselib.class.php';
+
+zdTable('testsuite')->gen(0);
+zdTable('user')->gen(1);
+
 su('admin');
 
 /**
@@ -16,7 +20,7 @@ $caselib = new caselibTest();
 
 $lib_noname = array('name' => '');
 $lib_normal = array('name' => 'lib name', 'desc' => 'lib desc');
-$lib_repeat = array('name' => 'lib_name');
+$lib_repeat = array('name' => 'lib name');
 
 r($caselib->createTest($lib_noname)) && p('name:0') && e('『名称』不能为空。'); // 测试名称是空时候添加
 r($caselib->createTest($lib_normal)) && p('name')   && e('lib name');           // 测试添加的名称信息