diff --git a/module/caselib/model.php b/module/caselib/model.php index fd5cd48e38..57a33aa32b 100644 --- a/module/caselib/model.php +++ b/module/caselib/model.php @@ -191,14 +191,12 @@ class caselibModel extends model ->checkFlow() ->exec(); - if(!dao::isError()) - { - $libID = $this->dao->lastInsertID(); - $this->loadModel('file')->updateObjectID($this->post->uid, $libID, 'caselib'); - $this->loadModel('action')->create('caselib', $libID, 'opened'); - return $libID; - } - return false; + if(dao::isError()) return false; + + $libID = $this->dao->lastInsertID(); + $this->loadModel('file')->updateObjectID($this->post->uid, $libID, 'caselib'); + $this->loadModel('action')->create('caselib', $libID, 'opened'); + return $libID; } /** diff --git a/module/caselib/test/caselib.class.php b/module/caselib/test/caselib.class.php index 701e6667c2..8cacbbfc52 100644 --- a/module/caselib/test/caselib.class.php +++ b/module/caselib/test/caselib.class.php @@ -114,14 +114,14 @@ class caselibTest * 创建用例库单元测试方法。 * Create case lib test function. * - * @param array $params + * @param array $params * @access public * @return array|object */ - public function createTest($params = array()): array|object + public function createTest(array $params = array()): array|object { $lib = new stdclass(); - foreach($params as $key => $value) $lib->$key = $value; + foreach($params as $key => $value) $lib->{$key} = $value; $libID = $this->objectModel->create($lib); diff --git a/module/caselib/test/model/create.php b/module/caselib/test/model/create.php index c9976941c3..bc2eb4e9c3 100755 --- a/module/caselib/test/model/create.php +++ b/module/caselib/test/model/create.php @@ -2,6 +2,10 @@ gen(0); +zdTable('user')->gen(1); + su('admin'); /** @@ -16,7 +20,7 @@ $caselib = new caselibTest(); $lib_noname = array('name' => ''); $lib_normal = array('name' => 'lib name', 'desc' => 'lib desc'); -$lib_repeat = array('name' => 'lib_name'); +$lib_repeat = array('name' => 'lib name'); r($caselib->createTest($lib_noname)) && p('name:0') && e('『名称』不能为空。'); // 测试名称是空时候添加 r($caselib->createTest($lib_normal)) && p('name') && e('lib name'); // 测试添加的名称信息