* Fix bug #24487.

2022-06-29 14:07:47 +08:00
parent 6669ccb37a
commit 30e6558572
1 changed files with 5 additions and 5 deletions
@@ -1131,16 +1131,16 @@ class testcase extends control
            $changes = $this->testcase->review($caseID);
            if(dao::isError()) return print(js::error(dao::getError()));

-            if($changes or $this->post->comment != '')
+            if(is_array($changes))
            {
                $result = $this->post->result;
                $actionID = $this->loadModel('action')->create('case', $caseID, 'Reviewed', $this->post->comment, ucfirst($result));
                $this->action->logHistory($actionID, $changes);
+
+                $this->executeHooks($caseID);
+
+                return print(js::reload('parent.parent'));
            }
-
-            $this->executeHooks($caseID);
-
-            return print(js::reload('parent.parent'));
        }

        $this->view->users   = $this->user->getPairs('noletter|noclosed|nodeleted');