From 30e65585727b487cf3d5536c3cf97604aa64740f Mon Sep 17 00:00:00 2001 From: liumengyi Date: Wed, 29 Jun 2022 14:07:47 +0800 Subject: [PATCH] * Fix bug #24487. --- module/testcase/control.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/module/testcase/control.php b/module/testcase/control.php index a336ab1962..2d4fb9a109 100644 --- a/module/testcase/control.php +++ b/module/testcase/control.php @@ -1131,16 +1131,16 @@ class testcase extends control $changes = $this->testcase->review($caseID); if(dao::isError()) return print(js::error(dao::getError())); - if($changes or $this->post->comment != '') + if(is_array($changes)) { $result = $this->post->result; $actionID = $this->loadModel('action')->create('case', $caseID, 'Reviewed', $this->post->comment, ucfirst($result)); $this->action->logHistory($actionID, $changes); + + $this->executeHooks($caseID); + + return print(js::reload('parent.parent')); } - - $this->executeHooks($caseID); - - return print(js::reload('parent.parent')); } $this->view->users = $this->user->getPairs('noletter|noclosed|nodeleted');