Comment said: "XXX: check explicitly that ELE was passed, not just size" however this code is in the else block after strcasecmp already was checked for ! ELE, therefore we have already validated that this is an ELE element type. REMOVED comment for clarity.

2025-02-01 10:28:24 +01:00
parent daea83d2cf
commit 285134e43d
1 changed files with 1 additions and 2 deletions
@@ -603,8 +603,7 @@ int VSIM_RedisCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
        vector_args = consumed_args;

        /* Apply projection if the set uses it, with the exception
-         * of ELE type, that will already have the right dimension.
-         * XXX: check explicitly that ELE was passed, not just size. */
+         * of ELE type, that will already have the right dimension. */
        if (vset->proj_matrix && dim != vset->hnsw->vector_dim) {
            float *projected = applyProjection(vec, vset->proj_matrix,
                                             vset->proj_input_size, dim);