Redis/redis-For-Windows
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

[Fix] Workaround for VirtualProtect failing while running the cluster tests.

Browse Source
This commit is contained in:
Enrico Giordani
2015-07-22 09:34:30 +02:00
parent cbde376880
commit 05382e53b1
1 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Win32_Interop/Win32_QFork.cpp
+24 -9
View File
@@ -829,15 +829,30 @@ void CopyForkOperationData(OperationType type, LPVOID globalData, int sizeOfGlob
system_category(),
"BeginForkOperation: VirtualProtect failed for the fork control map");
}
if (VirtualProtect(
g_pQForkControl->heapStart,
g_pQForkControl->availableBlocksInHeap * g_pQForkControl->heapBlockSize,
PAGE_WRITECOPY,
&oldProtect) == FALSE ) {
throw std::system_error(
GetLastError(),
system_category(),
"BeginForkOperation: VirtualProtect failed for the heap");
// TODO: VirtualProtec randomly fails while running the cluster tests,
// retrying the call is just a workaround for the alpha release.
int retries = 0;
while (TRUE){
BOOL result = VirtualProtect(
g_pQForkControl->heapStart,
g_pQForkControl->availableBlocksInHeap * g_pQForkControl->heapBlockSize,
PAGE_WRITECOPY,
&oldProtect);
if (result == TRUE) {
break;
} else {
++retries;
if (retries > 10) {
throw std::system_error(
GetLastError(),
system_category(),
"BeginForkOperation: VirtualProtect failed for the heap");
}
redisLog(REDIS_DEBUG, "BeginForkOperation: VirtualProtect failed for the heap, retrying in 100ms.");
Sleep(100);
}
}
}