add buffer class.

Plugins/uDesktopDuplication/uDesktopDuplication/Common.h

@@ -17,17 +17,6 @@ class MonitorManager;
 const std::unique_ptr<MonitorManager>& GetMonitorManager();
 
 
-template <class T>
-auto MakeUniqueWithReleaser(T* ptr)
-{
-    const auto deleter = [](T* ptr) 
-    { 
-        if (ptr != nullptr) ptr->Release();
-    };
-    return std::unique_ptr<T, decltype(deleter)>(ptr, deleter);
-}
-
-
 // Message is pooled and fetch from Unity.
 enum class Message
 {
@@ -37,3 +26,57 @@ enum class Message
 };
 
 void SendMessageToUnity(Message message);
+
+
+// Buffer
+template <class T>
+class Buffer
+{
+public:
+	Buffer() {}
+	~Buffer() {}
+
+	void ExpandIfNeeded(UINT size)
+	{
+		if (size > size_)
+		{
+			size_ = size;
+			value_ = std::make_unique<T[]>(size);
+		}
+	}
+
+	void Reset()
+	{
+		value_.reset();
+		size_ = 0;
+	}
+
+	UINT Size() const
+	{
+		return size_;
+	}
+
+	T* Get() const
+	{
+		return value_.get();
+	}
+
+	operator bool() const
+	{
+		return value_ != nullptr;
+	}
+
+	T operator [](UINT index) const
+	{
+		if (index >= size_)
+		{
+			Debug::Error("Array index out of range: ", index, size_);
+			return T(0);
+		}
+		return value_[index];
+	}
+
+private:
+	std::unique_ptr<T[]> value_;
+	UINT size_ = 0;
+};

Plugins/uDesktopDuplication/uDesktopDuplication/Cursor.cpp

@@ -1,6 +1,5 @@
 #include <d3d11.h>
 #include <wrl/client.h>
-#include "Common.h"
 #include "Debug.h"
 #include "MonitorManager.h"
 #include "Monitor.h"
@@ -47,13 +46,7 @@ void Cursor::UpdateBuffer(const DXGI_OUTDUPL_FRAME_INFO& frameInfo)
         return;
     }
 
-    // Increase the buffer size if needed
+	apiBuffer_.ExpandIfNeeded(frameInfo.PointerShapeBufferSize);
-    if (frameInfo.PointerShapeBufferSize > apiBufferSize_)
-    {
-        apiBufferSize_ = frameInfo.PointerShapeBufferSize;
-        apiBuffer_ = std::make_unique<BYTE[]>(apiBufferSize_);
-    }
-
     if (!apiBuffer_) 
     {
         return;
@@ -63,16 +56,15 @@ void Cursor::UpdateBuffer(const DXGI_OUTDUPL_FRAME_INFO& frameInfo)
     UINT bufferSize;
     DXGI_OUTDUPL_POINTER_SHAPE_INFO shapeInfo;
     const auto hr = monitor_->GetDeskDupl()->GetFramePointerShape(
-        apiBufferSize_,
+        apiBuffer_.Size(),
-        apiBuffer_.get(),
+        apiBuffer_.Get(),
         &bufferSize,
         &shapeInfo);
 
     if (FAILED(hr))
     {
         Debug::Error("Cursor::UpdateBuffer() => GetFramePointerShape() failed.");
-        apiBuffer_.reset();
+        apiBuffer_.Reset();
-        apiBufferSize_ = 0;
         return;
     }
 
@@ -100,11 +92,7 @@ void Cursor::UpdateTexture()
 
     // Convert the buffer given by API into BGRA32
     const UINT bgraBufferSize = cursorImageWidth * cursorImageHeight * 4;
-    if (bgraBufferSize > bgra32BufferSize_)
+	bgra32Buffer_.ExpandIfNeeded(bgraBufferSize);
-    {
-        bgra32BufferSize_ = bgraBufferSize;
-        bgra32Buffer_ = std::make_unique<BYTE[]>(bgra32BufferSize_);
-    }
     
     // Check buffers
     if (!bgra32Buffer_ || !apiBuffer_) 
@@ -281,7 +269,7 @@ void Cursor::UpdateTexture()
         };
 
         // Access RGBA values at the same time
-        auto output32 = reinterpret_cast<UINT*>(bgra32Buffer_.get());
+        auto output32 = reinterpret_cast<UINT*>(bgra32Buffer_.Get());
 
         if (isMono)
         {
@@ -300,7 +288,7 @@ void Cursor::UpdateTexture()
         }
         else // DXGI_OUTDUPL_POINTER_SHAPE_TYPE_MASKED_COLOR
         {
-            const auto buffer32 = reinterpret_cast<UINT*>(apiBuffer_.get());
+            const auto buffer32 = reinterpret_cast<UINT*>(apiBuffer_.Get());
 
             for (int row = rowMin, y = 0; row < rowMax; ++row, ++y) 
             {
@@ -329,8 +317,8 @@ void Cursor::UpdateTexture()
     }
     else // DXGI_OUTDUPL_POINTER_SHAPE_TYPE_COLOR
     {
-        auto output32 = reinterpret_cast<UINT*>(bgra32Buffer_.get());
+        auto output32 = reinterpret_cast<UINT*>(bgra32Buffer_.Get());
-        const auto buffer32 = reinterpret_cast<UINT*>(apiBuffer_.get());
+        const auto buffer32 = reinterpret_cast<UINT*>(apiBuffer_.Get());
         for (int i = 0; i < cursorImageWidth * cursorImageHeight; ++i) 
         {
             output32[i] = buffer32[i];
@@ -341,7 +329,7 @@ void Cursor::UpdateTexture()
 
 void Cursor::GetTexture(ID3D11Texture2D* texture)
 {
-    if (bgra32Buffer_ == nullptr)
+    if (!bgra32Buffer_)
     {
         Debug::Error("Cursor::GetTexture() => bgra32Buffer is null.");
         return;
@@ -368,7 +356,7 @@ void Cursor::GetTexture(ID3D11Texture2D* texture)
 
     ComPtr<ID3D11DeviceContext> context;
     GetDevice()->GetImmediateContext(&context);
-    context->UpdateSubresource(texture, 0, nullptr, bgra32Buffer_.get(), GetWidth() * 4, 0);
+    context->UpdateSubresource(texture, 0, nullptr, bgra32Buffer_.Get(), GetWidth() * 4, 0);
 }
 
 

Plugins/uDesktopDuplication/uDesktopDuplication/Cursor.h

@@ -3,6 +3,7 @@
 #include <d3d11.h>
 #include <dxgi1_2.h>
 #include <memory>
+#include "Common.h"
 
 class Monitor;
 
@@ -30,10 +31,8 @@ private:
     bool isVisible_ = false;
     int x_ = -1;
     int y_ = -1;
-    std::unique_ptr<BYTE[]> apiBuffer_ = nullptr;
+    Buffer<BYTE> apiBuffer_;
-    UINT apiBufferSize_ = 0;
+	Buffer<BYTE> bgra32Buffer_;
-    std::unique_ptr<BYTE[]> bgra32Buffer_ = nullptr;
-    UINT bgra32BufferSize_ = 0;
     DXGI_OUTDUPL_POINTER_SHAPE_INFO shapeInfo_;
     LARGE_INTEGER timestamp_;
 };

Plugins/uDesktopDuplication/uDesktopDuplication/Monitor.cpp

@@ -156,6 +156,7 @@ void Monitor::Render(UINT timeout)
         return;
     }
 
+	// Get texture
     if (unityTexture_)
     {
         ID3D11Texture2D* texture;