Commit Graph
198 Commits
Author SHA1 Message Date
Jamie Wong 7f7f5eeefb Add support for dropping asm.js symbol maps (#76)
This imports symbol maps generated by emscripten using the `--emit-symbol-map` flag. It allows you to visualize a profile captured in a release build as long as you also have the associated symbol map. To do this, first drop the profile into speedscope and then drop the symbol map. After the second drop, the symbols will be remapped to their original names.

This is a fixed up version of #75
2018-06-25 15:53:08 -07:00
Jamie Wong 27bc4c77d1 Clean up Chrome profiles (#71)
This cleans up imported Chrome profiles in 2 ways:

1. It places `(program)` frames on top of the previous call stack, just like we already did for `(garbage collector)`
2. It completely removes `(root)` and `(idle)` frames, since they aren't semantically useful in the profiles

CC @evanw
2018-06-25 00:57:53 -07:00
Jamie Wong 68f35ab9e8 Fix off-by-one error in viewport limit calculations 2018-06-22 00:05:32 -07:00
Jamie Wong 17e0692b2c Extend scroll height of flamechart to prevent details view from covering flamechart (#69) 2018-06-22 00:02:47 -07:00
Jamie Wong 17d48e753a Update README.md with info about recursion collapsing and table view 2018-06-21 14:00:16 -07:00
Jamie Wong d659eb0159 Add a hotkey to flatten recursion (#68)
This makes the left-heavy view much more useful since recursive calls are all collapsed together.

Press `r` to activate

Fixes #37
2018-06-21 13:56:58 -07:00
Jamie Wong aaac0ad7e3 Update instruments import to use integeruniquer.index file (#64)
I knew early on that `integeruniquer.index` could be used to index into `integeruniquer.data`, but I initially thought it was an optimization rather than a necessity. It seems like if there's data past the 1MB threshold in `integeruniquer.data`, then `integeruniquer.index` is actually quite useful.

The file seems to contain `[byte offset, MB offset]` pairs encoded as two 32 bit unsigned little endian integers. Using that to decode the integer arrays encoded in `integeruniquer.data` allows the file in #63 to load.

Fixes #63
2018-06-20 00:51:22 -07:00
Jamie Wong 7846cce806 Introduce a simple table view (#59)
This is a pretty barebones table view. Eventually I'd like this to provide some better way of identifying problem areas by seeing flamegraphs of all callers and all callees, but this is better than nothing.

![image](https://user-images.githubusercontent.com/150329/41460197-b4f6f0dc-7040-11e8-9390-69bb460bd8f1.png)
2018-06-18 12:11:04 -07:00
Jamie Wong c53bda84e9 Fix drag target oscillation 2018-06-08 10:36:05 -07:00
Jamie Wong ad72036901 Update README.md 2018-06-03 22:59:57 -07:00
Jamie Wong 721246752f Setup for publish 2018-05-31 00:24:24 -07:00
Jamie Wong 7c3aebdda3 Add visual indication that the page is a drag target (#57)
![2018-05-30 23 42 21](https://user-images.githubusercontent.com/150329/40765998-ff373f60-6462-11e8-9099-c8e68e805ca2.gif)
2018-05-31 00:09:53 -07:00
Jamie Wong 2207ff54ce Add tests for importers (#56)
This also fixes deep copy import for Instruments when copying from Instruments 7

Related to #14
2018-05-29 23:53:03 -07:00
Jamie Wong 405e751bbb Add tests for Profile and value formatters (#54)
* Split profile building APIs into dedicated classes

* Split value formatters into their own file

* Add tests for formatters

* Add test for StackListProfileBuilder

* Add test for CallTreeProfileBuilder
2018-05-29 20:02:02 -07:00
Jamie Wong d23660d13c Add test coverage reporting (#55)
This adds an integration with https://coveralls.io/ to report on code coverage of tests
2018-05-29 19:59:04 -07:00
Jamie Wong 4740385d80 Add test for LRU cache (#53) 2018-05-29 18:18:45 -07:00
Jamie Wong 3aa0944f94 Add tests for Vec2, Rect, and AffineTransform (#52)
* Tests for clamp, Vec2

* Switch to using jsverify for testing math functions

* Add tests for AffineTransform

* Add tests for Rect

* Add tests for rect transformations
2018-05-29 17:05:04 -07:00
Jamie Wong aee4534de4 Integrate jest and add first test file (#51)
This sets up the first bit of test infrastructure to write and run unit tests on every PR

Related to #14 
Fixes #7
2018-05-29 14:34:09 -07:00
Jamie Wong 9cdda3abf6 Fix position of x axis labels (#50)
This was broken by #48
2018-05-29 13:46:14 -07:00
Jamie Wong b8e437ec3e Fix scroll delta (#49)
This makes scrolling feel much zippier in Firefox

Fixes #46
2018-05-29 13:45:37 -07:00
Jamie Wong 66d1c2b3fc Switch to Source Code Pro, tweak outlines (#48)
This switches all text to be Source Code Pro instead of Courier for sharper rendering at size 10.

This also changes outline widths to be consistent visual widths on retina and non-retina screens.
2018-05-29 13:32:39 -07:00
Jamie Wong 32c2d637db Improve readability and correct bounds of selection & hover rectangles (#45)
Before:

![image](https://user-images.githubusercontent.com/150329/40530496-e7802094-5fad-11e8-8af1-de05775e529b.png)

After: 

![image](https://user-images.githubusercontent.com/150329/40530506-f142215e-5fad-11e8-97d7-f82ead458b23.png)
2018-05-24 23:56:23 -07:00
Jamie Wong 756a3ff5ac Fixes for details view (#44)
This contains 2 fixes for the details view
The first is that the padding in the scrolling view was causing the last frame to be clipped
The second is that we were uselessly displaying "(speedscope root)" in the stack trace view.

This also removes some sketch specific stuff from the keyed archive expanding code

Fixes #32
2018-05-20 14:42:16 -07:00
Jamie Wong 9edd5ce7ed Add Synalize It! Pro grammars Instruments for safe keeping 2018-05-17 09:13:55 -07:00
Jamie Wong 274110a46b Support importing time profiles from Instruments .trace files (#41)
#33 added support for importing from instruments indirectly via opening instruments and using the deep copy command. This PR adds support for importing `.trace` files directly, though only for time profiles specifically, and only for the highest sample count thread in the profile.

This PR adds `.trace` files from Instruments 9, and adds support for importing from either Instruments 8 and 9. The only major difference in the file format seems to be that Instruments 9 applies raw `zlib` compression generously throughout the file.

This PR also adds example `.trace` files for memory allocations, which are not supported for direct import. They use a totally different storage format for recording memory allocations, and I haven't yet figured out how that list of allocations references their corresponding callstack.

Lastly, this PR also adds examples from Instruments 7 since I happen to have a machine with an old version of Instruments. Import from Instruments 7 probably wouldn't be hard to add, but I haven't done that in this PR.

This currently only works in Chrome, and only via drag-and-drop of the files.

To test, drag the decompressed `simple-time-profile.trace` from https://github.com/jlfwong/speedscope/blob/6016d970b9d419f9ec6bf49326a0a6e9d9b26c0e/sample/profiles/Instruments/9.3.1/simple-time-profile.trace.zip onto speedscope.

The result should be this:

![image](https://user-images.githubusercontent.com/150329/40162338-8fa13502-5968-11e8-8fb3-40626e41884a.png)

Fixes #15
2018-05-17 00:33:09 -07:00
Jamie Wong 2cc3f7f141 Set the CNAME record in the deploy 2018-05-09 00:00:28 -07:00
Jamie Wong 7d68c24737 Fix deploy script 2018-05-08 23:56:13 -07:00
Jamie Wong ba7df9bef3 Change the public asset directory to be top level now that we have a domain (#36)
We previously had to serve from `/speedscope/` because the website was https://jlfwong.github.io/speedscope/. Now that we're going to serve from https://www.speedscope.app, we no longer have to do that (in fact it's important that we don't do that).
2018-05-08 23:53:06 -07:00
Jamie Wong f9032f4100 Reorganize sample directory (#34)
This should help keep things organized as speedscope supports more languages & more formats

Test Plan: Try importing from every single file type, see that the link to load the example profile still works
2018-05-08 23:13:38 -07:00
Jamie Wong 2b9f7ffe1b Support importing from instruments via deep copy (#33)
Instruments has a complex binary file format. If we're interested in just having a nice flamegraph display of the contents and don't care too much about time ordering or symbol file locations, then we can just grab the information we need from the clipboard rather than deal with the binary file format. This also avoids needing to deal with multiple processes or multiple threads.

This PR contains 2 compressed `.trace` files. In each, if you select the top row in the call tree view and hit "Cmd+Shift+C" or go to "Edit -> Deep Copy", then paste into speedscope, you should get the corresponding flamechart.

## Allocations Profile

![image](https://user-images.githubusercontent.com/150329/39796943-5d900c88-530e-11e8-8dea-fa0a44888a64.png)

![image](https://user-images.githubusercontent.com/150329/39796949-65f6a9f4-530e-11e8-8509-64816cebe74c.png)

## Time Profile

![image](https://user-images.githubusercontent.com/150329/39796956-6fd88776-530e-11e8-9978-14aba8e883e1.png)

![image](https://user-images.githubusercontent.com/150329/39796973-8983189e-530e-11e8-8d82-92183c8590f6.png)
2018-05-08 22:27:31 -07:00
Jamie Wong 84504f650a Fix browser zoom issues by not caching devicePixelRatio (#27)
When devicePixelRatio changes, a window resize event will fired, which should fix both #25 and #9.

To test this, I focused the location bar and zoomed into the page.

Before this PR:

![image](https://user-images.githubusercontent.com/150329/38972079-630a0fa8-4353-11e8-8278-3e33fda5ae6e.png)

After this PR:

![image](https://user-images.githubusercontent.com/150329/38972082-6847a2d2-4353-11e8-8d5b-4a5bd1ed9d03.png)


Fixes #25 
Fixes #9
2018-04-18 22:18:37 -07:00
Jamie Wong 2bfb2ae1bd Fix typo in file name 2018-04-18 21:44:39 -07:00
Jamie Wong e519785924 Update README with note about Firefox support 2018-04-17 18:52:43 -07:00
Jamie Wong 7ca4a41a6a Support importing from Firefox (#26) 2018-04-17 18:50:53 -07:00
Jamie Wong caba525465 Add a detail view to view aggregate statistics & file details (#23)
![image](https://user-images.githubusercontent.com/150329/38852391-9706fb4e-41ce-11e8-8296-a236928820c6.png)

This introduces a view for showing detailed information about a selected frame in the flamegraph. This provides information about self time & aggregate times across all instances of the function, regardless of where it is in the flamegraph.

This also shows a full stack with file & line information.

Fixes #20
2018-04-17 00:04:24 -07:00
Alan Pierce 7c1118a425 Add profileURL and title hash parameters (#19)
On init, we check the hash fragment for these parameters and load the URL. We
always show a loading state in that case rather than the landing screen.

When determining the title, an explicitly-specified title takes precedence,
otherwise we use the filename.

I also added an error state, currently only used for my new code, but possibly
there could be a more robust or widespread error handling approach in the
future.
2018-04-14 20:38:04 -07:00
Jamie Wong 702d8cf5b4 Merge pull request #17 from alangpierce/set-up-prettier
Set up Prettier and run it on the whole codebase
2018-04-14 16:56:31 -07:00
Alan Pierce 404aacfa46 Address review comments
* Switch to `bracketSpacing: false`.
* Add prettier-ignore in one case.
2018-04-14 16:19:26 -07:00
Alan Pierce 1bcb88670b Set up Prettier and run it on the whole codebase
* Install prettier, set up the config file, and run it on all ts and tsx files.
* Install eslint and configure it with just eslint-plugin-prettier to check to
  make sure that prettier has been run.
* Add a basic .travis.yml that runs eslint.

There are other style things that might be nice to enforce with ESLint/TSLint,
like using const, import order, etc, but this commit just focuses on prettier,
which gets most of the way there.

One annoying issue for now is that typescript-eslint-parser gives a big warning
message since they haven't updated to officially support TypeScript 2.8 yet. We
aren't even using any ESLint rules that need the parser, but if we don't include
it, ESLint will crash. TS2.8 support is hopefully coming really soon, though:
https://github.com/eslint/typescript-eslint-parser/pull/454

As for the prettier config specifically, see https://prettier.io/docs/en/options.html
for the available options.

Config settings that seem non-controversial:

Semicolons: You don't use semicolons. (I prefer semicolons, but either way is fine.)

Quote style: Looks like you consistently use single quotes outside JSX and double
quotes in JSX, which is the `singleQuote: true` option.

Config settings worth discussion:

Line width: You don't have a specific max. I put 100 since I think it's a good number
for people (like both of us, probably) who find 80 a bit cramped. (At Benchling we use
110.) Prettier has a big red warning box recommending 80, but I still prefer 100ish.

Bracket spacing: This is `{foo}` vs `{ foo }` for imports, exports, object literals,
and destructuring. Looks like you're inconsistent but lean toward spaces. I personally
really dislike bracket spacing (it feels inconsistent with arrays and function calls),
but I'm certainly fine with it and Prettier has it enabled by default, so I kept it
enabled.

Trailing comma style: Options are "no trailing commas", "trailing commas for
everything exception function calls and parameter lists", and "trailing commas
everywhere". TypeScript can handle trailing commas everywhere, so there isn't a
concern with tooling. You're inconsistent, and it looks like you tend to not have
trailing commas, but I think it's probably best to just have them everywhere, so I
enabled them.

JSX Brackets: You're inconsistent about this, I think. I'd prefer to just keep the
default and wrap the `>` to the next line.

Arrow function parens: I only found two cases of arrow functions with one param
(both `c => c.frame === frame`), and both omitted the parens, so I kept the
default of omitting parens. This makes it mildly more annoying to add a typescript
type or additional param, which is a possible reason for always requiring parens.

Everything else is non-configurable, although it's possible some places would be
better with a `// prettier-ignore` comment (but I usually try to avoid those).
2018-04-14 08:40:06 -07:00
Jamie Wong 298056a9ef Add MIT License 2018-04-08 22:35:53 -07:00
Jamie Wong f4d14e55d0 Fix deploy 2018-04-05 00:59:56 -07:00
Jamie Wong e630b21420 Rename release to deploy 2018-04-05 00:53:49 -07:00
Jamie Wong 971c0a2dc4 More tweaks to release process 2018-04-05 00:53:21 -07:00
Jamie Wong 045be2831b Prevent an infinite loop 2018-04-05 00:41:49 -07:00
Jamie Wong e4a6d2e3f3 Include commit in gh-pages branch to see which version is deployed 2018-04-05 00:32:26 -07:00
Jamie Wong 5104e5cdcb Demangle C++ symbols (#2)
This adds support for demangling C++ symbols automatically (they'll have a name prefix of `__Z`).
2018-04-05 00:27:03 -07:00
Jamie Wong 1987e83bde Upgrade libraries & change release procedure (#8)
Previously, I was doing a hacky release process where I had `index.html` serve contents for `jlfwong.github.io/speedscope`, but used `dev.html` locally. This seems like it broke with the latest parcel release, so I just revamped the release process instead.

Now, the `release.sh` script creates a temporary shallow clone of the repository, overwrites its contents with build artifacts, runs a local server to verify it's working, then commits and pushes to the `gh-pages` branches.
2018-04-05 00:15:42 -07:00
Jamie Wong aee0554635 release 2018-02-05 11:06:21 -08:00
Jamie Wong bd40956722 Change triangle wave frequency for color generation 2018-02-05 11:04:42 -08:00
Jamie Wong f86a4f0d00 More colorscheme tweaking 2018-02-05 11:02:30 -08:00