* Filter issue in gitlab using alternative way.

2021-07-12 14:32:48 +08:00
parent 2fce8df996
commit cc60268ee4
1 changed files with 14 additions and 4 deletions
@@ -315,10 +315,20 @@ class gitlab extends control
                                 ->where('relation')->eq('gitlab')
                                 ->andWhere('product')->in($productIDList)
                                 ->fetchAll('issueID');
-        $iids = '';
-        foreach($savedIssueIDList as $savedIssueID) $iids = $iids . $savedIssueID->issueID . ',';
-        $options = '&state=opened&not[iids]=' . trim($iids, ',');
-        $gitlabIssues = $this->gitlab->apiGetIssues($gitlabID, $projectID, $options); //TODO(dingguodong) when no issues here?
+
+        /* 'not[iids]' option in gitlab API has a issue when iids is too long. */ 
+        $gitlabIssues = $this->gitlab->apiGetIssues($gitlabID, $projectID, '&state=opened'); 
+        foreach($gitlabIssues as $index => $issue)
+        {
+            foreach($savedIssueIDList as $savedIssueID)
+            {
+                if($issue->iid == $savedIssueID->issueID) 
+                {
+                    unset($gitlabIssues[$index]);
+                    break;
+                }
+            }
+        }

        $products = array();
        $products[] = '';