* testtaskModel: return false if the run object query from database doesn't exist.

2023-10-16 14:44:30 +08:00
parent 85540681db
commit b5ece1db65
1 changed files with 7 additions and 5 deletions
@@ -1142,13 +1142,15 @@ class testtaskModel extends model
     *
     * @param  int    $runID
     * @access public
-     * @return object
+     * @return object|false
     */
-    public function getRunById(int $runID): object
+    public function getRunById(int $runID): object|false
    {
-        $testRun = $this->dao->findById($runID)->from(TABLE_TESTRUN)->fetch();
-        $testRun->case = $this->loadModel('testcase')->getById($testRun->case, $testRun->version);
-        return $testRun;
+        $run = $this->dao->findById($runID)->from(TABLE_TESTRUN)->fetch();
+        if(!$run) return false;
+
+        $run->case = $this->loadModel('testcase')->getById($run->case, $run->version);
+        return $run;
    }

    /**