From b5ece1db6518c441f95e74b33f0ec75a2b53db80 Mon Sep 17 00:00:00 2001 From: liugang Date: Mon, 16 Oct 2023 14:44:30 +0800 Subject: [PATCH] * testtaskModel: return false if the run object query from database doesn't exist. --- module/testtask/model.php | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/module/testtask/model.php b/module/testtask/model.php index 5e560b2262..99bae13027 100755 --- a/module/testtask/model.php +++ b/module/testtask/model.php @@ -1142,13 +1142,15 @@ class testtaskModel extends model * * @param int $runID * @access public - * @return object + * @return object|false */ - public function getRunById(int $runID): object + public function getRunById(int $runID): object|false { - $testRun = $this->dao->findById($runID)->from(TABLE_TESTRUN)->fetch(); - $testRun->case = $this->loadModel('testcase')->getById($testRun->case, $testRun->version); - return $testRun; + $run = $this->dao->findById($runID)->from(TABLE_TESTRUN)->fetch(); + if(!$run) return false; + + $run->case = $this->loadModel('testcase')->getById($run->case, $run->version); + return $run; } /**