Design/EasySoft-ZenTaoPMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 30 Wiki Activity

* Refactor bugModel-createBugFromGitlabIssue and modify unit test.

Browse Source
This commit is contained in:
liumengyi
2023-05-29 13:20:02 +08:00
parent f390fe7bd4
commit 9e4e3f9a2e
3 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/bug/model.php
+3 -2
View File
@@ -124,6 +124,7 @@ class bugModel extends model
}
/**
* gitlab问题转为bug。
* Create bug from gitlab issue.
*
* @param object $bug
@@ -131,11 +132,11 @@ class bugModel extends model
* @access public
* @return int|bool
*/
public function createBugFromGitlabIssue($bug, $executionID)
public function createBugFromGitlabIssue(object $bug, int $executionID): int|bool
{
$bug->openedBy = $this->app->user->account;
$bug->openedDate = helper::now();
$bug->assignedDate = isset($bug->assignedTo) ? helper::now() : 0;
$bug->assignedDate = isset($bug->assignedTo) ? helper::now() : null;
$bug->openedBuild = 'trunk';
$bug->story = 0;
$bug->task = 0;
module/bug/test/bug.class.php
+5 -4
View File
@@ -127,14 +127,15 @@ class bugTest
}
/**
* 测试gitlab问题转bug。
* Test create bug from gitlab issue.
*
* @param array $bug
* @param int $executionID
* @param object $bug
* @param int $executionID
* @access public
* @return object|int
* @return object|int|array
*/
public function createBugFromGitlabIssueTest($bug, $executionID)
public function createBugFromGitlabIssueTest(object $bug, int $executionID): object|int|array
{
$objectID = $this->objectModel->createBugFromGitlabIssue($bug, $executionID);
module/bug/test/model/createbugfromgitlabissue.php
+6 -9
View File
@@ -2,6 +2,10 @@
<?php
include dirname(__FILE__, 5) . '/test/lib/init.php';
include dirname(__FILE__, 2) . '/bug.class.php';
zdTable('project')->config('execution')->gen(2);
zdTable('user')->gen(2);
su('admin');
/**
@@ -10,16 +14,9 @@ title=bugModel->createBugFromGitlabIssue ();
cid=1
pid=1
测试正常的创建来源于gitlab issue的bug的title >> 问题1
测试正常的创建来源于gitlab issue的bug的execution >> 101
测试正常的创建来源于gitlab issue的bug的pri >> 3
测试正常的创建来源于gitlab issue的bug的severity >> 3
测试创建没有标题 来源于gitlab issue的异常bug >> 『Bug标题』不能为空。
测试短时间内重复创建来源于gitlab issue的bug >> 0
*/
$executionID = 101;
$executionID = 11;
$bug1 = new stdclass();
$bug1->title = '问题1';
@@ -43,7 +40,7 @@ $bug5->execution = $executionID;
$bug=new bugTest();
r($bug->createBugFromGitlabIssueTest($bug1, $executionID)) && p('title') && e('问题1'); // 测试正常的创建来源于gitlab issue的bug的title
r($bug->createBugFromGitlabIssueTest($bug2, $executionID)) && p('execution') && e('101'); // 测试正常的创建来源于gitlab issue的bug的execution
r($bug->createBugFromGitlabIssueTest($bug2, $executionID)) && p('execution') && e('11'); // 测试正常的创建来源于gitlab issue的bug的execution
r($bug->createBugFromGitlabIssueTest($bug3, $executionID)) && p('pri') && e('3'); // 测试正常的创建来源于gitlab issue的bug的pri
r($bug->createBugFromGitlabIssueTest($bug4, $executionID)) && p('severity') && e('3'); // 测试正常的创建来源于gitlab issue的bug的severity
r($bug->createBugFromGitlabIssueTest($bug5, $executionID)) && p('title:0') && e('『Bug标题』不能为空。'); // 测试创建没有标题 来源于gitlab issue的异常bug