* Refactor computeCFD method.

This commit is contained in:
tianshujie
2023-08-31 10:14:19 +08:00
parent 2115c04e4f
commit 92f44d38ba
2 changed files with 8 additions and 21 deletions
+5 -4
View File
@@ -1335,7 +1335,7 @@ class execution extends control
/**
* 更新燃尽图数据。
* Compute burndown datas.
* Compute burndown data.
*
* @param string $reload
* @access public
@@ -1414,17 +1414,18 @@ class execution extends control
}
/**
* Compute cfd datas.
* 计算累计流图数据。
* Compute cfd data.
*
* @param string $reload
* @param int $executionID
* @access public
* @return void
*/
public function computeCFD($reload = 'no', $executionID = 0)
public function computeCFD(string $reload = 'no', int $executionID = 0)
{
$this->execution->computeCFD($executionID);
if($reload == 'yes') return print(js::reload('parent'));
if($reload == 'yes') return $this->sendSuccess(array('load' => true));
}
/**
+3 -17
View File
@@ -3809,13 +3809,14 @@ class executionModel extends model
}
/**
* 计算累计流图的数据。
* Compute cfd of a execution.
*
* @param int $executionID
* @access public
* @return array
*/
public function computeCFD($executionID = 0)
public function computeCFD(int $executionID = 0)
{
$today = helper::today();
$executions = $this->dao->select('id, code')->from(TABLE_EXECUTION)
@@ -3856,22 +3857,7 @@ class executionModel extends model
{
foreach($columns as $colName => $laneGroup)
{
$cfd = new stdclass();
$cfd->count = 0;
$cfd->date = $today;
$cfd->type = $type;
foreach($laneGroup as $columnGroup)
{
foreach($columnGroup as $columnCard)
{
$cards = trim($columnCard->cards, ',');
$cfd->count += $cards ? count(explode(',', $cards)) : 0;
}
}
$cfd->name = $colName;
$cfd->execution = $executionID;
$this->dao->replace(TABLE_CFD)->data($cfd)->exec();
$this->executionTao->updateTodayCFDData($executionID, $type, $colName, $laneGroup);
}
}
}