* [misc] Optimize the code for related object.

This commit is contained in:
xieqiyu
2024-11-29 17:09:35 +08:00
committed by 王于听
parent c8f39a7521
commit 8a54569740
4 changed files with 10 additions and 8 deletions
+3 -2
View File
@@ -770,6 +770,7 @@ class bugZen extends bug
/* Get story and task id list. */
$storyIdList = $taskIdList = array();
if($this->config->edition == 'max') $identifyList = $this->loadModel('review')->getPairs(0, 0, true);
if($this->config->edition != 'open') $bugRelatedObjectList = $this->custom->getRelatedObjectList(array_keys($bugs), 'bug', 'byRelation', true);
foreach($bugs as $bug)
{
if($bug->story) $storyIdList[$bug->story] = $bug->story;
@@ -781,10 +782,10 @@ class bugZen extends bug
$bug->injection = zget($identifyList, $bug->injection, '');
$bug->identify = zget($identifyList, $bug->identify, '');
}
if($this->config->edition != 'open') $bug->relatedObject = $this->custom->getRelatedObjectList($bug->id, 'bug', 'byRelation', true);
if($this->config->edition != 'open') $bug->relatedObject = zget($bugRelatedObjectList, $bug->id, 0);
}
$showModule = !empty($this->config->bug->browse->showModule) ? $this->config->bug->browse->showModule : '';
/* Set view. */
+2 -2
View File
@@ -115,8 +115,8 @@ class design extends control
$designs = $this->design->getList($projectID, $productID, $type, $queryID, $orderBy, $pager);
if($this->config->edition != 'open')
{
$this->loadModel('custom');
foreach($designs as $design) $design->relatedObject = $this->custom->getRelatedObjectList($design->id, 'design', 'byRelation', true);
$designRelatedObjectList = $this->loadModel('custom')->getRelatedObjectList(array_keys($designs), 'design', 'byRelation', true);
foreach($designs as $design) $design->relatedObject = zget($designRelatedObjectList, $design->id, 0);
}
$this->view->title = $this->lang->design->common . $this->lang->hyphen . $this->lang->design->browse;
+3 -2
View File
@@ -161,9 +161,10 @@ class execution extends control
foreach($this->view->teamMembers as $key => $member) $memberPairs[$key] = $member->realname;
$memberPairs = $this->loadModel('user')->setCurrentUserFirst($memberPairs);
if($this->config->edition != 'open') $taskRelatedObject = $this->loadModel('custom')->getRelatedObjectList(array_keys($tasks), 'task', 'byRelation', true);
/* Append branches to task. */
$this->loadModel('task');
$this->loadModel('custom');
$branchGroups = $this->loadModel('branch')->getByProducts(array_keys($this->view->products));
foreach($tasks as $task)
{
@@ -183,7 +184,7 @@ class execution extends control
}
if(isset($branchGroups[$task->product][$task->branch])) $task->branch = $branchGroups[$task->product][$task->branch];
if($task->needConfirm) $task->status = 'changed';
if($this->config->edition != 'open') $task->relatedObject = $this->custom->getRelatedObjectList($task->id, 'task', 'byRelation', true);
if($this->config->edition != 'open') $task->relatedObject = zget($taskRelatedObject, $task->id, 0);
}
$showAllModule = empty($this->config->execution->task->allModule) ? '' : 'allModule';
+2 -2
View File
@@ -519,8 +519,8 @@ class testcaseZen extends testcase
if($this->config->edition != 'open')
{
$this->loadModel('custom');
foreach($cases as $caseID => $case) $case->relatedObject = $this->custom->getRelatedObjectList($caseID, 'testcase', 'byRelation', true);
$caseRelatedObjectList = $this->loadModel('custom')->getRelatedObjectList(array_keys($cases), 'testcase', 'byRelation', true);
foreach($cases as $caseID => $case) $case->relatedObject = zget($caseRelatedObjectList, $caseID, 0);
}
$this->view->cases = array_merge($scenes, $cases);