* [task#129929,doing,0.5h] Adjust the trigger page js to expand.

module/job/js/trigger.ui.js

@@ -85,30 +85,9 @@ window.changeTriggerType = function(event)
         return;
     }
 
-    if(type == 'tag' && repo.SCM == 'Subversion')
-    {
-        $parentDom.append(svnField.replace(/%s/g, window.triggerCount));
-        $('#dirPicker' + window.triggerCount).addClass('form-group-wrapper picker-box');
+    if(type != 'tag' || repo.SCM == 'Subversion') $parentDom.append(eval(`${type}Field`).replace(/%s/g, window.triggerCount));
+    if(type != 'commit') eval(`window.init${type}Block`);
 
-        const options = Object.keys(dirs).map((dir) => {
-            return {value: dir, text: dirs[dir]};
-        });
-        new zui.Picker('#dirPicker' + window.triggerCount, {
-            items:         options,
-            name:         `svnDir[]`,
-            required:     true,
-            defaultValue: options.length ? options[0].value : ''
-        });
-    }
-    if(type == 'commit')   $parentDom.append(commentField);
-    if(type == 'schedule')
-    {
-        $parentDom.append(scheduleField.replace(/%s/g, window.triggerCount));
-        $('#scheduleTime' + window.triggerCount).addClass('form-group-wrapper picker-box');
-        new zui.TimePicker('#scheduleTime' + window.triggerCount, {
-            name: 'atTime'
-        })
-    }
     $parentDom.find('.hidden').removeClass('hidden');
 }
 
@@ -162,3 +141,28 @@ window.deleteTrigger = function(event)
     $(event.target).closest('.trigger-box').remove();
     if($('#triggerForm .trigger-box').length <= 1) $('.delete-trigger').addClass('hidden');
 }
+
+window.initTagBlock = function()
+{
+    if(repo.SCM != 'Subversion') return;
+
+    $('#dirPicker' + window.triggerCount).addClass('form-group-wrapper picker-box');
+
+    const options = Object.keys(dirs).map((dir) => {
+        return {value: dir, text: dirs[dir]};
+    });
+    new zui.Picker('#dirPicker' + window.triggerCount, {
+        items:         options,
+        name:         `svnDir[]`,
+        required:     true,
+        defaultValue: options.length ? options[0].value : ''
+    });
+}
+
+window.initScheduleBlock = function()
+{
+    $('#scheduleTime' + window.triggerCount).addClass('form-group-wrapper picker-box');
+    new zui.TimePicker('#scheduleTime' + window.triggerCount, {
+        name: 'atTime'
+    })
+}

module/job/ui/trigger.html.php

@@ -14,7 +14,7 @@ jsVar('dirs', !empty($dirs) ? $dirs : '');
 jsVar('triggerRepeat', $lang->job->triggerRepeat);
 jsVar('triggerTypeList', $lang->job->triggerTypeList);
 
-jsVar('svnField', formRow
+jsVar('tagField', formRow
 (
     setClass('svn-fields linkage-fields hidden mt-4'),
     formGroup
@@ -26,7 +26,7 @@ jsVar('svnField', formRow
         div(setID('dirPicker%s'))
     )
 )->render());
-jsVar('commentField', formRow
+jsVar('commitField', formRow
 (
     setClass('comment-fields linkage-fields hidden mt-4'),
     formGroup