Redis/redis
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
e26ea35cd4b683dd4bd43ef0569086f36ee65914
redis/tests/modules
T
History
debing.sun 4581d43230 Fix daylight race condition and some thread leaks (#13191) 
fix some issues that come from sanitizer thread report.

1. when the main thread is updating daylight_active, other threads (bio,
module thread) may be writing logs at the same time.
```
WARNING: ThreadSanitizer: data race (pid=661064)
  Read of size 4 at 0x55c9a4d11c70 by thread T2:
    #0 serverLogRaw /home/sundb/data/redis_fork/src/server.c:116 (redis-server+0x8d797) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #1 _serverLog.constprop.2 /home/sundb/data/redis_fork/src/server.c:146 (redis-server+0x2a3b14) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #2 bioProcessBackgroundJobs /home/sundb/data/redis_fork/src/bio.c:329 (redis-server+0x1c24ca) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)

  Previous write of size 4 at 0x55c9a4d11c70 by main thread (mutexes: write M0, write M1, write M2, write M3):
    #0 updateCachedTimeWithUs /home/sundb/data/redis_fork/src/server.c:1102 (redis-server+0x925e7) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #1 updateCachedTimeWithUs /home/sundb/data/redis_fork/src/server.c:1087 (redis-server+0x925e7)
    #2 updateCachedTime /home/sundb/data/redis_fork/src/server.c:1118 (redis-server+0x925e7)
    #3 afterSleep /home/sundb/data/redis_fork/src/server.c:1811 (redis-server+0x925e7)
    #4 aeProcessEvents /home/sundb/data/redis_fork/src/ae.c:389 (redis-server+0x85ae0) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #5 aeProcessEvents /home/sundb/data/redis_fork/src/ae.c:342 (redis-server+0x85ae0)
    #6 aeMain /home/sundb/data/redis_fork/src/ae.c:477 (redis-server+0x85ae0)
    #7 main /home/sundb/data/redis_fork/src/server.c:7211 (redis-server+0x7168c) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
```

2. thread leaks in module tests
```
WARNING: ThreadSanitizer: thread leak (pid=668683)
  Thread T13 (tid=670041, finished) created by main thread at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:1036 (libtsan.so.2+0x3d179) (BuildId: 28a9f70061dbb2dfa2cef661d3b23aff4ea13536)
    #1 HelloBlockNoTracking_RedisCommand /home/sundb/data/redis_fork/tests/modules/blockonbackground.c:200 (blockonbackground.so+0x97fd) (BuildId: 9cd187906c57e88cdf896d121d1d96448b37a136)
    #2 HelloBlockNoTracking_RedisCommand /home/sundb/data/redis_fork/tests/modules/blockonbackground.c:169 (blockonbackground.so+0x97fd)
    #3 call /home/sundb/data/redis_fork/src/server.c:3546 (redis-server+0x9b7fb) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #4 processCommand /home/sundb/data/redis_fork/src/server.c:4176 (redis-server+0xa091c) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #5 processCommandAndResetClient /home/sundb/data/redis_fork/src/networking.c:2468 (redis-server+0xd2b8e) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #6 processInputBuffer /home/sundb/data/redis_fork/src/networking.c:2576 (redis-server+0xd2b8e)
    #7 readQueryFromClient /home/sundb/data/redis_fork/src/networking.c:2722 (redis-server+0xd358f) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #8 callHandler /home/sundb/data/redis_fork/src/connhelpers.h:58 (redis-server+0x288a7b) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #9 connSocketEventHandler /home/sundb/data/redis_fork/src/socket.c:277 (redis-server+0x288a7b)
    #10 aeProcessEvents /home/sundb/data/redis_fork/src/ae.c:417 (redis-server+0x85b45) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
    #11 aeProcessEvents /home/sundb/data/redis_fork/src/ae.c:342 (redis-server+0x85b45)
    #12 aeMain /home/sundb/data/redis_fork/src/ae.c:477 (redis-server+0x85b45)
    #13 main /home/sundb/data/redis_fork/src/server.c:7211 (redis-server+0x7168c) (BuildId: dca0b1945ba30010e36129bdb296e488dd2b32d0)
```
2024-04-04 13:49:51 +03:00
..
aclcheck.c
Allows modules to declare new ACL categories. (#12486)
2023-08-30 13:01:24 -07:00
auth.c
Fix daylight race condition and some thread leaks (#13191)
2024-04-04 13:49:51 +03:00
basics.c
Change license from BSD-3 to dual RSALv2+SSPLv1 (#13157)
2024-03-20 22:38:24 +00:00
blockedclient.c
Fix daylight race condition and some thread leaks (#13191)
2024-04-04 13:49:51 +03:00
blockonbackground.c
Fix daylight race condition and some thread leaks (#13191)
2024-04-04 13:49:51 +03:00
blockonkeys.c
Modules: Unblock from within a timer coverage (#12337)
2023-06-22 23:15:16 +03:00
cmdintrospection.c
Overhauls command summaries and man pages. (#11942)
2023-03-29 20:48:59 +03:00
commandfilter.c
Un-register notification and server event when RedisModule_OnLoad fails (#12809)
2023-11-27 17:26:33 +02:00
crash.c
Handle recursive serverAsserts and provide more information for recursive segfaults (#12857)
2024-01-02 18:20:22 -08:00
datatype2.c
Use const char pointer in redismodule.h as far as possible (#10064)
2022-01-18 15:55:20 +02:00
datatype.c
Module commands to have ACL categories. (#11708)
2023-03-21 10:07:11 -07:00
defragtest.c
Build TLS as a loadable module
2022-08-23 12:37:56 +03:00
eventloop.c
delete obsolete REDISMODULE_EXPERIMENTAL_API define in module demos (#10527)
2022-04-05 08:21:41 +03:00
fork.c
Fix race in module fork kill test (#10717)
2022-05-12 20:10:38 +03:00
getchannels.c
Implemented module getchannels api and renamed channel keyspec (#10299)
2022-02-22 11:00:03 +02:00
getkeys.c
Handle key-spec flags with modules (#10237)
2022-02-08 10:01:35 +02:00
hash.c
…
hooks.c
Change license from BSD-3 to dual RSALv2+SSPLv1 (#13157)
2024-03-20 22:38:24 +00:00
infotest.c
Update supported version list. (#12488)
2023-08-16 08:36:40 +03:00
keyspace_events.c
Change license from BSD-3 to dual RSALv2+SSPLv1 (#13157)
2024-03-20 22:38:24 +00:00
keyspecs.c
RM_CreateCommand should not set CMD_KEY_VARIABLE_FLAGS automatically (#11320)
2022-09-28 14:15:07 +03:00
list.c
Fix crash due to to reuse iterator entry after list deletion in module (#11383)
2022-10-22 20:36:50 +03:00
Makefile
Handle recursive serverAsserts and provide more information for recursive segfaults (#12857)
2024-01-02 18:20:22 -08:00
mallocsize.c
Add RM_MallocSizeString, RM_MallocSizeDict (#10542)
2022-04-17 08:31:57 +03:00
misc.c
Add API RedisModule_ClusterKeySlot and RedisModule_ClusterCanonicalKeyNameInSlot (#13069)
2024-03-12 09:26:12 -07:00
moduleauthtwo.c
Custom authentication for Modules (#11659)
2023-03-15 15:18:42 -07:00
moduleconfigs.c
Module commands to have ACL categories. (#11708)
2023-03-21 10:07:11 -07:00
moduleconfigstwo.c
Module Configurations (#10285)
2022-03-30 15:47:06 +03:00
postnotifications.c
Fix daylight race condition and some thread leaks (#13191)
2024-04-04 13:49:51 +03:00
propagate.c
Fix daylight race condition and some thread leaks (#13191)
2024-04-04 13:49:51 +03:00
publish.c
Fix broken protocol when PUBLISH emits local push inside MULTI (#12326)
2023-06-20 20:41:41 +03:00
rdbloadsave.c
Add RM_RdbLoad and RM_RdbSave module API functions (#11852)
2023-04-09 12:07:32 +03:00
reply.c
Add RM_ReplyWithErrorFormat that can support format (#11923)
2023-04-12 10:11:29 +03:00
scan.c
…
stream.c
…
subcommands.c
Block some specific characters in module command names (#11434)
2022-11-03 13:19:49 +02:00
test_lazyfree.c
…
testrdb.c
Avoid saving module aux on RDB if no aux data was saved by the module. (#11374)
2022-10-18 19:45:46 +03:00
timer.c
Modules: Mark all APIs non-experimental (#9983)
2021-12-30 12:17:22 +02:00
usercall.c
Fix daylight race condition and some thread leaks (#13191)
2024-04-04 13:49:51 +03:00
zset.c
Delete empty key if fails after moduleCreateEmptyKey() in module (#12129)
2023-05-07 10:13:19 +03:00