TLS: relax verification on CONFIG SET. (#7665)

Avoid re-configuring (and validating) SSL/TLS configuration on `CONFIG
SET` when TLS is not actively enabled for incoming connections, cluster
bus or replication.

This fixes failures when tests run without `--tls` on binaries that were
built with TLS support.

An additional benefit is that it's now possible to perform a multi-step
configuration process while TLS is disabled. The new configuration will
be verified and applied only when TLS is effectively enabled.
This commit is contained in:
Yossi Gottlieb
2020-08-17 17:36:50 +03:00
committed by GitHub
parent 1407a055ee
commit fb2a94af3f
2 changed files with 24 additions and 7 deletions
+20 -6
View File
@@ -85,12 +85,19 @@ jobs:
sudo apt-get install tcl8.5 tcl-tls
./utils/gen-test-certs.sh
./runtest --accurate --verbose --tls
./runtest --accurate --verbose
- name: module api test
run: ./runtest-moduleapi --verbose --tls
run: |
./runtest-moduleapi --verbose --tls
./runtest-moduleapi --verbose
- name: sentinel tests
run: ./runtest-sentinel --tls
run: |
./runtest-sentinel --tls
./runtest-sentinel
- name: cluster tests
run: ./runtest-cluster --tls
run: |
./runtest-cluster --tls
./runtest-cluster
test-valgrind:
runs-on: ubuntu-latest
@@ -147,10 +154,17 @@ jobs:
yum -y install tcl tcltls
./utils/gen-test-certs.sh
./runtest --accurate --verbose --tls
./runtest --accurate --verbose
- name: module api test
run: ./runtest-moduleapi --verbose --tls
run: |
./runtest-moduleapi --verbose --tls
./runtest-moduleapi --verbose
- name: sentinel tests
run: ./runtest-sentinel --tls
run: |
./runtest-sentinel --tls
./runtest-sentinel
- name: cluster tests
run: ./runtest-cluster --tls
run: |
./runtest-cluster --tls
./runtest-cluster