Fix duplicate module options define (#10284)
The bug is introduced by #9323. (released in 7.0 RC1) The define of `REDISMODULE_OPTIONS_HANDLE_IO_ERRORS` and `REDISMODULE_OPTION_NO_IMPLICIT_SIGNAL_MODIFIED` have the same value. This will result in skipping `signalModifiedKey()` after `RM_CloseKey()` if the module has set `REDISMODULE_OPTIONS_HANDLE_REPL_ASYNC_LOAD` option. The implication is missing WATCH and client side tracking invalidations. Other changes: - add `no-implicit-signal-modified` to the options in INFO modules Co-authored-by: Oran Agra <oran@redislabs.com>
This commit is contained in:
@@ -47,6 +47,12 @@ tags "modules" {
|
||||
}
|
||||
}
|
||||
|
||||
test {Verify module options info} {
|
||||
start_server [list overrides [list loadmodule "$testmodule"]] {
|
||||
assert_match "*\[handle-io-errors|handle-repl-async-load\]*" [r info modules]
|
||||
}
|
||||
}
|
||||
|
||||
tags {repl} {
|
||||
test {diskless loading short read with module} {
|
||||
start_server [list overrides [list loadmodule "$testmodule"]] {
|
||||
|
||||
Reference in New Issue
Block a user