Commit Graph
924 Commits
Author SHA1 Message Date
stakx 1eb391c147 Replace "stream" in reader/writer classes' comments
XML documentation comments for JsonReader, JsonWriter and derived
classes often mention "underlying streams". In most cases however,
these types don't operate directly on Streams, but through other types
such as TextReader and TextWriter.

This commit changes these comments to reflect more accurately what
kind of objects the various JSON reader / writer classes operate on.

Additionally the effect of JsonReader.CloseInput and JsonWriter.Close-
Output is made more explicit in the comments for the Close methods.
2016-12-24 02:26:16 +01:00
stakx e19ac3f28c Add & fix crefs in XML document comments
* Add references to types where they are missing.

 * Fix incorrect references to closed generic types.

 * Convert member ID strings to proper references where they can be
   converted without breaking the build. The remaining member ID
   strings usually mean that the comment would have to be rephrased
   for at least one build target / platform.

 * Drop namespaces from type names where they are unnecessary.

 * Fix the odd typo and add additional <c> markup in a few places.
2016-12-23 16:15:24 +01:00
stakx 937d5a53bb XML comments: consistent formatting of C# keywords 2016-12-19 09:29:22 +01:00
stakx 2e6d2ecd4c Fix typos, punctuation, etc. in XML doc comments
* Simple stuff: typos and missing punctuation and line breaks.

 * Sometimes, two method overloads have quite different documentation.
   Rephrase these to make them more similar.

 * Minor rephrasings like in a previous commit (e.g. "...how output
   should be formatted", "initializes a new instance of...").

 * Obvious incorrect type references in comments. These appear mostly
   in `Utilities/LinqBridge.cs` (nullable vs non-nullable).

 * Remove factually incorrect statement about exceptions thrown.

 * Remove comments for explicitly implemented interface methods.
2016-12-18 01:01:46 +01:00
stakx f27ad19eb0 Amend omission in previous commit 2016-12-11 01:26:14 +01:00
stakx 01f370d1ff Change comments as per @JamesNK's feedback
* Explicitly implemented interfaces don't need comments.

 * Protected constructors of abstract classes should be documented
   like Microsoft does on MSDN.

 * Replace term "Common Language Runtime (CLR) type" with ".NET type".
2016-12-11 01:19:50 +01:00
stakx 3c6b49a3dd Revert crefs that cannot be resolved in all targets 2016-12-11 00:14:03 +01:00
stakx 067768a658 Fix minor issues in XML documentation comments
This fixes several minor issues in the code's documentation comments,
such as spelling errors, missing punctuation and references to other
code elements, and a few other small inconsistencies.
2016-12-10 22:53:40 +01:00
James Newton-King 133bbc2d38 -Fixed roundtripping double.MaxValue and float.MaxValue as dictionary keys 2016-12-10 17:23:43 +13:00
James Newton-King 4d425ccd06 -Fix merging null with complex type and MergeNullValueHandling.Ignore 2016-12-08 09:47:01 +13:00
James Newton-King be8ca7a870 -Refactor 2016-11-27 13:58:21 +13:00
James Newton-King 5269ce81c0 -Fixed serializing protected override properties 2016-11-27 13:33:52 +13:00
James Newton-King 38809c68e8 -Refactor away var 2016-11-07 13:33:53 -08:00
James Newton-King b2afa9d674 -Fixed StringEnumConverter when EnumMember defines members that differ only by case 2016-11-06 20:58:32 -08:00
Mikko Rantanen b47f7440d1 Fix null reference error when deserializing bytes
If the JSON contained empty object "{}" for a byte[] property, the `JsonReader` ended up trying to read the object content despite the fact that the content didn't exist. This caused a null reference exception.

The fix ensures the value exists before trying to read it. If the value doesn't exist, the execution ends up in "Unexpected token" exception with way more informative error message.
2016-11-05 15:38:52 +02:00
James Newton-King b2e30121db Merge pull request #1072 from recycleddan/master
Fix return type for SByte and SByteNullable in ToObject
2016-11-05 23:41:15 +13:00
James Newton-King 803403ae21 -Fixed deserializing generic only IList types with a constructor override 2016-11-05 23:21:34 +13:00
Dan Carter b234eafbf2 Fix return type for SByte and SByteNullable in ToObject 2016-11-04 13:33:05 -04:00
James Newton-King ae074a3469 -Fixed incorrectly parsing scan filter when name is quoted
-Added support for multiple names in scan filter
2016-10-28 13:25:52 +13:00
James Newton-King 07b070065a -Refactor 2016-10-25 16:30:30 +13:00
James Newton-King 2d4b86b08e Merge branch 'is-reference-bug' of https://github.com/TylerBrinkley/Newtonsoft.Json into TylerBrinkley-is-reference-bug 2016-10-25 16:09:36 +13:00
James Newton-King 29c84fd7c2 -Improved error when attempting to convert root JSON object property to an XML attribute 2016-10-25 14:43:27 +13:00
James Newton-King 0721bd4dec -Fixed not erroring when deserializing incomplete JSON with a parameterized constructor 2016-10-24 14:20:59 +13:00
James Newton-King 570a7ca078 -Fixed deserializing a duplicate dictionary key from a parameterized constructor 2016-10-24 12:57:17 +13:00
James Newton-King fb1acd0c83 Merge pull request #1051 from TylerBrinkley/nullable-struct-typename-bug
Stops including typename for nullable structs using TypeNameHandling.Auto
2016-10-19 10:15:15 +13:00
TylerBrinkley 2a28dcc544 Stops including the typename for nullable structs using TypeNameHandling.Auto, fixes #1050 2016-10-18 11:34:43 -05:00
Pyit Phyo Aung f50f276b76 Clean up NETFX_CORE directive usage 2016-10-11 14:14:13 +13:00
James Newton-King 7388358e0a -Clean up 2016-10-02 20:42:42 +13:00
James Newton-King d7125908ca -Merge 2016-09-17 17:15:35 +12:00
James Newton-King ca27a0fc3a -Added TypeNameAssemblyFormatHandling
-Added TypeNameAssemblyFormatHandling properties to JsonSerializer and JsonSerializerSettings
-Changed TypeNameAssemblyFormat properties on JsonSerializer and JsonSerializerSettings to obsolete
2016-09-17 15:57:03 +12:00
James Newton-King 4f8a22594f -Added ISerializationBinder
-Added SerializationBinder properties to JsonSerializer and JsonSerializerSettings
-Changed Binder properties on JsonSerializer and JsonSerializerSettings to obsolete
2016-09-16 16:10:13 +12:00
TylerBrinkley 954057ad17 Allow readonly properties to serialize as references if they have corresponding creator parameters 2016-09-15 09:33:44 -05:00
James Newton-King a0403492ad -Tests 2016-09-13 16:51:39 +12:00
James Newton-King 867f4a7d43 Merge branch 'corefx-converter-args' of https://github.com/pieceofsummer/Newtonsoft.Json into pieceofsummer-corefx-converter-args 2016-09-13 16:15:20 +12:00
James Newton-King 6c272eac6e -Fixed StringEnumConverter.AllowIntegerValues to reject integer strings 2016-09-12 17:25:19 +12:00
James Newton-King 39ecc359eb -Fixed date XML precision on portable builds 2016-09-12 09:45:37 +12:00
Alexey Skalozub 04c429a15d Use ValidationUtils.ArgumentNotNull, code cleanup 2016-09-11 19:14:32 +03:00
James Newton-King 5fdfdff453 -Tests
-Fixed regression
2016-09-11 22:07:19 +12:00
James Newton-King 12b38ccb19 -Fixed error handling skipping reading the next object value 2016-09-11 19:37:44 +12:00
James Newton-King ca3af212de -Fixed double parsing bug 2016-09-11 17:06:53 +12:00
James Newton-King 304136a60e Merge branch 'master' into eisber-master 2016-09-11 16:19:27 +12:00
James Newton-King 5dd9f0a904 -Change double parsing validation to match JSON spec 2016-09-11 16:09:08 +12:00
Alexey Skalozub 7b0331725c Speed up expression delegates when widening types is not needed 2016-09-11 03:35:36 +03:00
Alexey Skalozub deefe2e006 Removed Convert.ChangeType calls because of poor performance (DynamicReflectionDelegateFactory now uses IConvertible.ToTypeName, while ExpressionReflectionDelegateFactory uses Convert.ToTypeName). Method binder moved to a separate file and documented, + code style fixes. 2016-09-10 20:19:22 +03:00
James Newton-King 68d160f3c6 -Added netstandard1.1 with BigInteger support 2016-09-10 23:54:44 +12:00
James Newton-King 73d3594762 Merge branch 'master' of https://github.com/wojtpl2/Newtonsoft.Json into wojtpl2-master 2016-09-10 18:41:45 +12:00
James Newton-King ac2d619474 -Added support for root object in JSONPath filters 2016-09-10 16:54:29 +12:00
James Newton-King 59618df631 -Documentation 2016-09-10 14:56:20 +12:00
wojtpl2 dde688207c Fix DeserializeXNode in .net core 2016-09-09 11:32:15 +02:00
Alexey Skalozub 20bbadeb0e Use manual packing of IEEE754 double in ConverterUtils.DoubleTryParse() 2016-09-06 22:02:56 +03:00