-Fixed unhelpful error when failing conversion in JsonReader.ReadAsDecimal

-Fixed JsonReader.ReadAsInt32 with BigInteger values
This commit is contained in:
James Newton-King
2018-02-17 18:46:27 +13:00
parent ac17463d05
commit 91af95d77e
3 changed files with 67 additions and 6 deletions
@@ -72,6 +72,28 @@ namespace Newtonsoft.Json.Tests.JsonTextReaderTests
);
}
[Test]
public void ReadAsDecimal_IntegerTooLarge_ThrowsJsonReaderException()
{
JValue token = new JValue(double.MaxValue);
ExceptionAssert.Throws<JsonReaderException>(
() => token.CreateReader().ReadAsDecimal(),
"Could not convert to decimal: 1.79769313486232E+308. Path ''."
);
}
#if !(NET20 || NET35 || PORTABLE40 || PORTABLE) || NETSTANDARD1_3 || NETSTANDARD2_0
[Test]
public void ReadAsInt32_BigIntegerValue_Success()
{
JValue token = new JValue(BigInteger.Parse("1"));
int? i = token.CreateReader().ReadAsInt32();
Assert.AreEqual(1, i);
}
#endif
[Test]
public void ReadMissingInt64()
{