Lazy async statemachine in WriteToAsync

This commit is contained in:
Ben Adams
2017-08-28 05:29:15 +01:00
parent 98366a4b88
commit 56262bc917
2 changed files with 137 additions and 10 deletions
+43 -4
View File
@@ -25,6 +25,7 @@
#if HAVE_ASYNC
using System;
using System.Globalization;
using System.Threading;
using System.Threading.Tasks;
@@ -41,16 +42,54 @@ namespace Newtonsoft.Json.Linq
/// <param name="cancellationToken">The token to monitor for cancellation requests.</param>
/// <param name="converters">A collection of <see cref="JsonConverter"/> which will be used when writing the token.</param>
/// <returns>A <see cref="Task"/> that represents the asynchronous write operation.</returns>
public override async Task WriteToAsync(JsonWriter writer, CancellationToken cancellationToken, params JsonConverter[] converters)
public override Task WriteToAsync(JsonWriter writer, CancellationToken cancellationToken, params JsonConverter[] converters)
{
await writer.WriteStartObjectAsync(cancellationToken).ConfigureAwait(false);
var t = writer.WriteStartObjectAsync(cancellationToken);
if (t.Status != TaskStatus.RanToCompletion)
{
return AwaitStartObject(t, writer, cancellationToken, converters);
}
for (int i = 0; i < _properties.Count; i++)
{
await _properties[i].WriteToAsync(writer, cancellationToken, converters).ConfigureAwait(false);
t = _properties[i].WriteToAsync(writer, cancellationToken, converters);
if (t.Status != TaskStatus.RanToCompletion)
{
return AwaitProperties(t, i + 1, writer, cancellationToken, converters);
}
}
await writer.WriteEndObjectAsync(cancellationToken).ConfigureAwait(false);
t = writer.WriteEndObjectAsync(cancellationToken);
return (t.Status == TaskStatus.RanToCompletion) ? AsyncUtils.CompletedTask : AwaitEndObject(t);
// Local functions, params renamed (capitalized) so as not to capture and allocate when calling async
async Task AwaitStartObject(Task task, JsonWriter Writer, CancellationToken CancellationToken, JsonConverter[] Converters)
{
await task.ConfigureAwait(false);
for (int i = 0; i < _properties.Count; i++)
{
await _properties[i].WriteToAsync(Writer, CancellationToken, Converters).ConfigureAwait(false);
}
await Writer.WriteEndObjectAsync(CancellationToken).ConfigureAwait(false);
}
async Task AwaitProperties(Task task, int i, JsonWriter Writer, CancellationToken CancellationToken, JsonConverter[] Converters)
{
await task.ConfigureAwait(false);
for (; i < _properties.Count; i++)
{
await _properties[i].WriteToAsync(Writer, CancellationToken, Converters).ConfigureAwait(false);
}
await Writer.WriteEndObjectAsync(CancellationToken).ConfigureAwait(false);
}
async Task AwaitEndObject(Task task)
{
await task.ConfigureAwait(false);
}
}
/// <summary>