* product: fix sonar alerts.

2023-05-10 16:17:35 +08:00
parent a5c2edaa36
commit c5dd73abcc
4 changed files with 11 additions and 7 deletions
@@ -1781,7 +1781,9 @@ class programModel extends model
                $actionsMap[] = $item;
            }

-            if($canSuspendProgram or ($canCloseProgram and $program->status != 'doing') or ($canActivateProgram and $program->status != 'closed'))
+            $canCloseCurrentProgram    = $canCloseProgram && $program->status != 'doing';
+            $canActivateCurrentProgram = $canActivateProgram && $program->status != 'closed';
+            if($canSuspendProgram or $canCloseCurrentProgram or $canActivateCurrentProgram)
            {
                $other = new stdclass();
                $other->name  = 'other';