* Optimize codes that add a same webhook only once and others.

2021-11-12 18:14:10 +08:00
parent 2f5e351b2c
commit b865527512
2 changed files with 49 additions and 29 deletions
@@ -782,15 +782,15 @@ class gitlab extends control
        else
        {
            $repo = $this->loadModel('repo')->getRepoByID($repoID);
-            $res = $this->gitlab->addPushWebhook($repo);
+            $res  = $this->gitlab->addPushWebhook($repo);

-            if(!$res)
+            if($res or is_array($res))
            {
-                die(js::error($this->lang->gitlab->failCreateWebhook));
+                die(js::locate($this->createLink('repo', 'maintain'), 'parent'));
            }
            else
            {
-                die(js::locate($this->createLink('repo', 'maintain'), 'parent'));
+                die(js::error($this->lang->gitlab->failCreateWebhook));
            }
        }
    }