Design/EasySoft-ZenTaoPMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 30 Wiki Activity

* Optimize bug assign function.

Browse Source
This commit is contained in:
wangyuting
2023-05-26 10:37:04 +08:00
parent c51fa64fe9
commit 8a60290816
2 changed files with 16 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/bug/model.php
+5 -8
View File
@@ -560,16 +560,13 @@ class bugModel extends model
* Assign a bug to a user.
*
* @param object $bug
* @param string $comment
* @access public
* @return array|false
* @return bool
*/
public function assign(object $bug, string $comment = ''): array|false
public function assign(object $bug): bool
{
/* Get old bug. */
$oldBug = $this->getById($bug->id);
/* If status of the bug is closed, skip it. */
if($oldBug->status == 'closed') return false;
/* Update assigned of the bug. */
$this->dao->update(TABLE_BUG)
@@ -583,10 +580,10 @@ class bugModel extends model
/* Record log. */
$changes = common::createChanges($oldBug, $bug);
$actionID = $this->loadModel('action')->create('bug', $bug->id, 'Assigned', $comment, $bug->assignedTo);
$this->action->logHistory($actionID, $changes);
$actionID = $this->loadModel('action')->create('bug', $bug->id, 'Assigned', $this->post->comment, $bug->assignedTo);
if($changes) $this->action->logHistory($actionID, $changes);
return $changes;
return !dao::isError();
}
/**