Design/EasySoft-ZenTaoPMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 30 Wiki Activity

* Fix code smell of $$statusVar.

Browse Source
This commit is contained in:
Guanxiying
2023-05-08 11:03:30 +08:00
parent 02bf7ad2be
commit 4f852d7641
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/execution/model.php
+12 -9
View File
@@ -4334,34 +4334,37 @@ class executionModel extends model
*/
public function summary($tasks)
{
$taskSum = $statusWait = $statusDone = $statusDoing = $statusClosed = $statusCancel = $statusPause = 0;
$taskSum = 0;
$totalEstimate = $totalConsumed = $totalLeft = 0.0;
$summations = array();
$this->app->loadLang('task');
/* 当前只需要显示wait 和 doing 状态，但是从代码分析将来可能需要统计其他状态的，所以取全部状态。 */
foreach($this->lang->task->statusList as $statusCode => $statusName) $summations[$statusCode] = 0;
foreach($tasks as $task)
{
if(!isset($tasks[$task->parent]) or $task->parent <= 0)
{
$totalEstimate += $task->estimate;
$totalConsumed += $task->consumed;
$totalEstimate += $task->estimate;
$totalConsumed += $task->consumed;
if($task->status != 'cancel' and $task->status != 'closed') $totalLeft += $task->left;
}
$statusVar = 'status' . ucfirst($task->status);
$$statusVar ++;
if(isset($summations[$task->status])) $summations[$task->status] ++;
if(isset($task->children))
{
foreach($task->children as $children)
foreach($task->children as $child)
{
$statusVar = 'status' . ucfirst($children->status);
$$statusVar ++;
if(isset($summations[$child->status])) $summations[$child->status] ++;
$taskSum ++;
}
}
$taskSum ++;
}
return sprintf($this->lang->execution->taskSummary, $taskSum, $statusWait, $statusDoing, round($totalEstimate, 1), round($totalConsumed, 1), round($totalLeft, 1));
return sprintf($this->lang->execution->taskSummary, $taskSum, $summations['wait'], $summations['doing'], round($totalEstimate, 1), round($totalConsumed, 1), round($totalLeft, 1));
}
/**