diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue0573.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue0573.cs new file mode 100644 index 00000000..e5659883 --- /dev/null +++ b/Src/Newtonsoft.Json.Tests/Issues/Issue0573.cs @@ -0,0 +1,66 @@ +#region License +// Copyright (c) 2007 James Newton-King +// +// Permission is hereby granted, free of charge, to any person +// obtaining a copy of this software and associated documentation +// files (the "Software"), to deal in the Software without +// restriction, including without limitation the rights to use, +// copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the +// Software is furnished to do so, subject to the following +// conditions: +// +// The above copyright notice and this permission notice shall be +// included in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES +// OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND +// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT +// HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, +// WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +// OTHER DEALINGS IN THE SOFTWARE. +#endregion + +using Newtonsoft.Json.Linq; +using Newtonsoft.Json.Linq.JsonPath; +using System; +using Newtonsoft.Json.Serialization; +using System.Diagnostics; +using System.Linq; +using System.Collections.Generic; +#if DNXCORE50 +using Xunit; +using Test = Xunit.FactAttribute; +using Assert = Newtonsoft.Json.Tests.XUnitAssert; +#else +using NUnit.Framework; +#endif + +namespace Newtonsoft.Json.Tests.Issues +{ + [TestFixture] + public class Issue0573 + { + [Test] + public void Test() + { + string json = "{'Value':'hi'}"; + MemoryTraceWriter traceWriter = new MemoryTraceWriter { LevelFilter = TraceLevel.Info }; + PrivateSetterTestClass o = JsonConvert.DeserializeObject(json, new JsonSerializerSettings + { + TraceWriter = traceWriter + }); + List messages = traceWriter.GetTraceMessages().ToList(); + + bool hasMessage = messages.Any(message => message.Contains("Info Unable to deserialize value to non-writable property 'Value' on Newtonsoft.Json.Tests.Issues.Issue0573+PrivateSetterTestClass. Path 'Value', line 1, position 13.")); + Assert.IsTrue(hasMessage); + } + + public class PrivateSetterTestClass + { + public string Value { get; private set; } + } + } +} diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue1837 .cs b/Src/Newtonsoft.Json.Tests/Issues/Issue1837.cs similarity index 87% rename from Src/Newtonsoft.Json.Tests/Issues/Issue1837 .cs rename to Src/Newtonsoft.Json.Tests/Issues/Issue1837.cs index e2e86998..2bd9d5b0 100644 --- a/Src/Newtonsoft.Json.Tests/Issues/Issue1837 .cs +++ b/Src/Newtonsoft.Json.Tests/Issues/Issue1837.cs @@ -1,4 +1,29 @@ -using Newtonsoft.Json.Linq; +#region License +// Copyright (c) 2007 James Newton-King +// +// Permission is hereby granted, free of charge, to any person +// obtaining a copy of this software and associated documentation +// files (the "Software"), to deal in the Software without +// restriction, including without limitation the rights to use, +// copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the +// Software is furnished to do so, subject to the following +// conditions: +// +// The above copyright notice and this permission notice shall be +// included in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES +// OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND +// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT +// HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, +// WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +// OTHER DEALINGS IN THE SOFTWARE. +#endregion + +using Newtonsoft.Json.Linq; using Newtonsoft.Json.Linq.JsonPath; using System; #if DNXCORE50 diff --git a/Src/Newtonsoft.Json/JsonSerializerSettings.cs b/Src/Newtonsoft.Json/JsonSerializerSettings.cs index b0c7a42f..ea68dc94 100644 --- a/Src/Newtonsoft.Json/JsonSerializerSettings.cs +++ b/Src/Newtonsoft.Json/JsonSerializerSettings.cs @@ -30,6 +30,7 @@ using System.Globalization; using System.Runtime.Serialization.Formatters; using Newtonsoft.Json.Serialization; using System.Runtime.Serialization; +using System.Diagnostics; namespace Newtonsoft.Json { @@ -445,6 +446,7 @@ namespace Newtonsoft.Json /// /// Initializes a new instance of the class. /// + [DebuggerStepThrough] public JsonSerializerSettings() { Converters = new List(); diff --git a/Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs b/Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs index 23923262..c4d588ae 100644 --- a/Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs +++ b/Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs @@ -1112,6 +1112,11 @@ namespace Newtonsoft.Json.Serialization if (!property.Writable && !useExistingValue) { + if (TraceWriter != null && TraceWriter.LevelFilter >= TraceLevel.Info) + { + TraceWriter.Trace(TraceLevel.Info, JsonPosition.FormatMessage(reader as IJsonLineInfo, reader.Path, "Unable to deserialize value to non-writable property '{0}' on {1}.".FormatWith(CultureInfo.InvariantCulture, property.PropertyName, property.DeclaringType)), null); + } + return true; }