From 751fb8c117339c1c166f3710712ff2bc41e8ce8f Mon Sep 17 00:00:00 2001 From: songchenxuan Date: Wed, 30 Mar 2022 15:51:39 +0800 Subject: [PATCH 1/2] * Fix taskbatchcreate API bug . --- api/v1/entries/taskbatchcreate.php | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/api/v1/entries/taskbatchcreate.php b/api/v1/entries/taskbatchcreate.php index 6a65f4c898..d12c273085 100644 --- a/api/v1/entries/taskbatchcreate.php +++ b/api/v1/entries/taskbatchcreate.php @@ -43,21 +43,23 @@ class taskBatchCreateEntry extends Entry $desc = array(); $pri = array(); $stories = array(); + $number = 1; foreach($this->request('tasks') as $task) { if(!isset($task->name) or !isset($task->type)) return $this->send400('Task must have name and type.'); - $modules[] = isset($task->module) ? $task->module : $moduleID; - $parents[] = isset($task->parent) ? $task->parent : $taskID; - $names[] = $task->name; - $colors[] = isset($task->color) ? $task->color : ''; - $types[] = $task->type; - $estimates[] = isset($task->estimate) ? $task->estimate : 0; - $estStarted[] = isset($task->estStarted) ? $task->estStarted : 0; - $deadlines[] = isset($task->deadline) ? $task->deadline : null; - $desc[] = isset($task->desc) ? $task->desc : ''; - $pri[] = isset($task->pri) ? $task->pri : 0; - $stories[] = isset($task->story) ? $task->story : $storyID; + $modules[$number] = isset($task->module) ? $task->module : $moduleID; + $parents[$number] = isset($task->parent) ? $task->parent : $taskID; + $names[$number] = $task->name; + $colors[$number] = isset($task->color) ? $task->color : ''; + $types[$number] = $task->type; + $estimates[$number] = isset($task->estimate) ? $task->estimate : 0; + $estStarted[$number] = isset($task->estStarted) ? $task->estStarted : 0; + $deadlines[$number] = isset($task->deadline) ? $task->deadline : null; + $desc[$number] = isset($task->desc) ? $task->desc : ''; + $pri[$number] = isset($task->pri) ? $task->pri : 0; + $stories[$number] = isset($task->story) ? $task->story : $storyID; + $number += 1; } $this->setPost('module', $modules); $this->setPost('parent', $parents); From 344b65b9388011bb8dd1ec8a10a164f4116befc4 Mon Sep 17 00:00:00 2001 From: songchenxuan Date: Wed, 30 Mar 2022 16:07:15 +0800 Subject: [PATCH 2/2] * Fix API bug. --- api/v1/entries/taskbatchcreate.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/api/v1/entries/taskbatchcreate.php b/api/v1/entries/taskbatchcreate.php index d12c273085..92fa3d2c47 100644 --- a/api/v1/entries/taskbatchcreate.php +++ b/api/v1/entries/taskbatchcreate.php @@ -43,9 +43,9 @@ class taskBatchCreateEntry extends Entry $desc = array(); $pri = array(); $stories = array(); - $number = 1; - foreach($this->request('tasks') as $task) + foreach($this->request('tasks') as $key => $task) { + $number = $key + 1; if(!isset($task->name) or !isset($task->type)) return $this->send400('Task must have name and type.'); $modules[$number] = isset($task->module) ? $task->module : $moduleID; @@ -59,7 +59,6 @@ class taskBatchCreateEntry extends Entry $desc[$number] = isset($task->desc) ? $task->desc : ''; $pri[$number] = isset($task->pri) ? $task->pri : 0; $stories[$number] = isset($task->story) ? $task->story : $storyID; - $number += 1; } $this->setPost('module', $modules); $this->setPost('parent', $parents);