From f7fbb4a615ee4eb0c06b42c36c0b904c94c4dcbe Mon Sep 17 00:00:00 2001 From: wangyidong Date: Wed, 27 Nov 2024 14:32:19 +0800 Subject: [PATCH] * [perf story #69668] Adjust code. --- module/task/js/batchcreate.ui.js | 5 +++-- module/task/zen.php | 9 ++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/module/task/js/batchcreate.ui.js b/module/task/js/batchcreate.ui.js index 1486dea5bd..b70a870f22 100644 --- a/module/task/js/batchcreate.ui.js +++ b/module/task/js/batchcreate.ui.js @@ -158,9 +158,10 @@ function loadLanes(event) } } -$('#formSettingBtn').on('click', '.checkbox-primary [value=story]', function() +$(document).off('change', '#formSettingBtn input[value=story]').on('change', '#formSettingBtn input[value=story]', function() { - $('#formSettingBtn .checkbox-primary [value=preview], #formSettingBtn .checkbox-primary [value=copyStory]').prop('checked', $('#formSettingBtn .checkbox-primary [value=story]').prop('checked')); + const checked = $('#formSettingBtn input[value=story]').prop('checked'); + $('#formSettingBtn input[value=preview], #formSettingBtn input[value=copyStory]').prop('checked', checked); }) function checkBatchEstStartedAndDeadline(event) diff --git a/module/task/zen.php b/module/task/zen.php index 414acd85f2..d005c8e265 100644 --- a/module/task/zen.php +++ b/module/task/zen.php @@ -398,7 +398,14 @@ class taskZen extends task if(isset($customFields['story'])) $customFields['preview'] = $customFields['copyStory'] = ''; $showFields = $this->config->task->custom->batchCreateFields; - if(strpos(",$showFields,", ',story,') !== false) $showFields .= ',preview,copyStory'; + if(strpos(",$showFields,", ',story,') !== false) + { + $showFields .= ',preview,copyStory'; + } + else + { + $showFields = trim(str_replace(array(',copyStory,', ',preview,'), ',', ",{$showFields},"), ','); + } $this->config->task->batchcreate->requiredFields = $this->config->task->create->requiredFields;