diff --git a/module/gitlab/control.php b/module/gitlab/control.php index ae65e37916..4d770b5230 100644 --- a/module/gitlab/control.php +++ b/module/gitlab/control.php @@ -33,6 +33,7 @@ class gitlab extends control foreach($gitlabList as $gitlab) { $token = $this->gitlab->apiGetCurrentUser($gitlab->url,$gitlab->token); + $gitlab->isAdminToken = isset($token->is_admin) ? $token->is_admin : 0; } diff --git a/module/gitlab/view/browse.html.php b/module/gitlab/view/browse.html.php index 586860b235..b905dfd9c1 100644 --- a/module/gitlab/view/browse.html.php +++ b/module/gitlab/view/browse.html.php @@ -16,7 +16,7 @@ " . $lang->gitlab->create, '', "class='btn btn-primary'");?> - +

noData;?> diff --git a/module/mr/control.php b/module/mr/control.php index 8134df0fdf..7eb9bb791d 100644 --- a/module/mr/control.php +++ b/module/mr/control.php @@ -74,10 +74,14 @@ class mr extends control * @access public * @return void */ - public function delete($MR, $confim = 'no') + public function delete($id, $confim = 'no') { - if($confim != 'yes') die(js::confirm($this->lang->gitlab->confirmDelete, inlink('delete', "productID=$projectID&gitlabID=$gitlabID&MR=$MR&confirm=yes"))); - $this->mr->apiDeleteMR($MR); + if($confim != 'yes') die(js::confirm($this->lang->gitlab->confirmDelete, inlink('delete', "id=$id&confirm=yes"))); + + $MRList = $this->mr->getByID($id); + + $this->mr->apiDeleteMR($MRList->gitlabID, $MRList->projectID, $MRList->mrID); + $this->mr->deleteMR($id); die(js::reload('parent')); } diff --git a/module/mr/model.php b/module/mr/model.php index 30b5f20c55..3cbdc65a21 100644 --- a/module/mr/model.php +++ b/module/mr/model.php @@ -83,14 +83,14 @@ class mrModel extends model * * condition: when user deleting a repo. * - * @param int $MRID + * @param int $id * @access public * @return void */ - public function deleteMR($MRID) + public function deleteMR($id) { $this->dao->delete()->from(TABLE_MR) - ->andWhere('mrID')->eq($MRID) + ->andWhere('id')->eq($id) ->exec(); } diff --git a/module/mr/view/browse.html.php b/module/mr/view/browse.html.php index fd22d53608..01c02e9546 100644 --- a/module/mr/view/browse.html.php +++ b/module/mr/view/browse.html.php @@ -25,32 +25,32 @@ mr->sourceBranch); ?> mr->targetBranch); ?> mr->status); ?> - mr->mrStatus); ?> + mr->canMerge); ?> actions; ?> - + id; ?> name; ?> - target_branch; ?> - source_branch; ?> + targetBranch; ?> + sourceBranch; ?> status; ?> - mrStatus; ?> + canMerge; ?> id}", '', '', "title='{$lang->mr->list}' class='btn btn-info'"); common::printLink('mr', 'create', "mr={$mr->id}", '', '', "title='{$lang->mr->create}' class='btn btn-info'"); common::printLink('mr', 'edit', "mrID=$mr->id&objectID=$objectID", '', '', "title='{$lang->mr->edit}' class='btn btn-info'"); - if(common::hasPriv('mr', 'delete')) echo html::a($this->createLink('mr', 'delete', "productID=$mr->projectID&gitlabID=$mr->gitlabID&mrID=$mr->mrID"), '', 'hiddenwin', "title='{$lang->mr->delete}' class='btn'"); + if(common::hasPriv('mr', 'delete')) echo html::a($this->createLink('mr', 'delete', "id=$mr->id"), '', 'hiddenwin', "title='{$lang->mr->delete}' class='btn'"); ?> - +