From f1bb74e1fa7ce768cfc8de046207a42fe7992e54 Mon Sep 17 00:00:00 2001 From: xieqiyu Date: Thu, 30 May 2024 10:16:45 +0800 Subject: [PATCH] * [refac] Code review. --- module/story/ui/view.html.php | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/module/story/ui/view.html.php b/module/story/ui/view.html.php index 03b215652c..98c9a1c7fb 100644 --- a/module/story/ui/view.html.php +++ b/module/story/ui/view.html.php @@ -196,15 +196,6 @@ foreach($actions as $key => $action) continue; } - if(isset($action['url'])) $actions[$key]['url'] = str_replace(array('{id}', '{type}', '{product}', '{branch}', '{module}', '{execution}'), array($story->id, $story->type, $story->product, $story->branch, $story->module, isset($executionID) ? $executionID : (isset($projectID) ? $projectID : 0)), $action['url']); - if(isset($action['items'])) - { - foreach($action['items'] as $itemKey => $itemAction) - { - if(isset($itemAction['url'])) $actions[$key]['items'][$itemKey]['url'] = str_replace(array('{id}', '{type}', '{product}', '{branch}', '{module}', '{execution}'), array($story->id, $story->type, $story->product, $story->branch, $story->module, isset($executionID) ? $executionID : (isset($projectID) ? $projectID : 0)), $itemAction['url']); - } - } - if($isInModal && !isset($actions[$key]['data-toggle']) && !isset($actions[$key]['data-load'])) { $actions[$key]['data-load'] = 'modal'; @@ -214,6 +205,7 @@ foreach($actions as $key => $action) detail ( + set::urlFormatter(array('{id}' => $story->id, '{type}' => $story->type, '{product}' => $story->product, '{branch}' => $story->branch, '{module}' => $story->module, '{execution}' => isset($executionID) ? $executionID : (isset($projectID) ? $projectID : 0))), set::objectType('story'), set::toolbar($toolbar), set::sections($sections),