From f0c0da44111f87201ebfe86cb2d224529ddda98b Mon Sep 17 00:00:00 2001
From: Lufei <lufei@easycorp.ltd>
Date: Thu, 8 Jun 2023 15:44:28 +0800
Subject: [PATCH] * Optimize method name.

---
 module/misc/control.php |  2 +-
 module/misc/model.php   | 12 +++++++-----
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/module/misc/control.php b/module/misc/control.php
index 39d41daa2e..a9f0627a36 100644
--- a/module/misc/control.php
+++ b/module/misc/control.php
@@ -353,7 +353,7 @@ class misc extends control
             return;
         }
 
-        $this->misc->getCacheFiles(rtrim($this->app->getCacheRoot(), DS));
+        $this->misc->cleanCachaFiles(rtrim($this->app->getCacheRoot(), DS));
 
         echo 'Cleaned cache files.';
     }
diff --git a/module/misc/model.php b/module/misc/model.php
index 0258444862..0703f70bb5 100644
--- a/module/misc/model.php
+++ b/module/misc/model.php
@@ -141,29 +141,31 @@ class miscModel extends model
      * @param string $directory
      * @return void
      */
-    public function getCacheFiles($directory)
+    public function cleanCachaFiles($directory)
     {
         $files = glob($directory . DS . '*.cache');
 
-        foreach($files as $file) $this->readCacheFile($file);
+        foreach($files as $file) $this->deleteExpiredFile($file);
 
         $subdirectories = glob($directory . DS . '*', GLOB_ONLYDIR);
 
-        foreach($subdirectories as $subdirectory) $this->getCacheFiles($subdirectory);
+        foreach($subdirectories as $subdirectory) $this->cleanCachaFiles($subdirectory);
     }
 
     /**
-     * Read cache file content, and delete it if expired.
+     * Delete expired file.
      *
      * @param string $file
      * @return bool
      */
-    public function readCacheFile($file)
+    public function deleteExpiredFile($file)
     {
         $content = file_get_contents($file);
         $content = unserialize($content);
 
         if(is_null($content['time'])) return false;
         if(time() > $content['time']) return unlink($file);
+
+        return false;
     }
 }