From a8fb159310c730e22b9eda8df1913e861ffe684d Mon Sep 17 00:00:00 2001 From: wangyidong Date: Wed, 29 Nov 2017 14:47:40 +0800 Subject: [PATCH 01/40] * fix error. --- db/zentao.sql | 2 +- module/build/control.php | 2 +- module/project/model.php | 2 +- module/testcase/control.php | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/db/zentao.sql b/db/zentao.sql index c2eb4e5475..affac107d4 100644 --- a/db/zentao.sql +++ b/db/zentao.sql @@ -914,7 +914,7 @@ INSERT INTO `zt_group` (`id`, `name`, `role`, `desc`) VALUES (7, 'PD', 'pd', 'for product director.'), (8, 'QD', 'qd', 'for quality director.'), (9, 'TOP', 'top', 'for top manager.'), -(10, 'OTHERS', '', 'for others.'), +(10, 'OTHERS', 'others', 'for others.'), (11, 'guest', 'guest', 'For guest'), (12, 'limited', 'limited', 'For limited user'); diff --git a/module/build/control.php b/module/build/control.php index c8a5bd1fed..6fe1f9d488 100644 --- a/module/build/control.php +++ b/module/build/control.php @@ -346,7 +346,7 @@ class build extends control } if($varName == 'testTaskBuild') { - $builds = $this->build->getProjectBuildPairs($projectID, $productID, $branch, 'noempty'); + $builds = $this->build->getProjectBuildPairs($projectID, $productID, $branch, 'noempty,notrunk'); if($isJsonView) die(json_encode($builds)); else die(html::select('build', $builds, $build, "class='form-control'")); } diff --git a/module/project/model.php b/module/project/model.php index 7b8017f62e..1b6c04c68e 100644 --- a/module/project/model.php +++ b/module/project/model.php @@ -342,7 +342,7 @@ class projectModel extends model $member->role = $this->lang->project->$fieldName; $member->days = $project->days; $member->hours = $this->config->project->defaultWorkhours; - $this->dao->insert(TABLE_TEAM)->data($member)->exec(); + $this->dao->replace(TABLE_TEAM)->data($member)->exec(); } } } diff --git a/module/testcase/control.php b/module/testcase/control.php index de54fe507d..917eae5fa7 100644 --- a/module/testcase/control.php +++ b/module/testcase/control.php @@ -1147,10 +1147,10 @@ class testcase extends control } /* fill some field with useful value. */ - if(isset($products[$case->product])) $case->product = $products[$case->product] . "(#$case->product)"; - if(isset($branches[$case->branch])) $case->branch = $branches[$case->branch] . "(#$case->branch)"; - if(isset($relatedModules[$case->module])) $case->module = $relatedModules[$case->module] . "(#$case->module)"; - if(isset($relatedStories[$case->story])) $case->story = $relatedStories[$case->story] . "(#$case->story)"; + $case->product = !isset($products[$case->product]) ? '' : $products[$case->product] . "(#$case->product)"; + $case->branch = !isset($branches[$case->branch]) ? '' : $branches[$case->branch] . "(#$case->branch)"; + $case->module = !isset($relatedModules[$case->module])? '' : $relatedModules[$case->module] . "(#$case->module)"; + $case->story = !isset($relatedStories[$case->story]) ? '' : $relatedStories[$case->story] . "(#$case->story)"; if(isset($caseLang->priList[$case->pri])) $case->pri = $caseLang->priList[$case->pri]; if(isset($caseLang->typeList[$case->type])) $case->type = $caseLang->typeList[$case->type]; From 7b0571d18fad39dd192751e2eef46b0d02a279bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=BB=94=E5=93=A5?= Date: Wed, 29 Nov 2017 15:52:14 +0800 Subject: [PATCH 02/40] * User list add title --- module/company/view/browse.html.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/company/view/browse.html.php b/module/company/view/browse.html.php index 04d2cf8649..c5ad8c36b3 100644 --- a/module/company/view/browse.html.php +++ b/module/company/view/browse.html.php @@ -65,7 +65,7 @@ js::set('confirmDelete', $lang->user->confirmDelete); printf('%03d', $user->id); ?> - account", $user->realname)) echo $user->realname;?> + account", $user->realname, '', "title='$user->realname'")) echo $user->realname;?> account;?> user->roleList[$user->role];?> email);?> From 759b3950cbe6e775559530666c4781a901b04e0d Mon Sep 17 00:00:00 2001 From: wangyidong Date: Thu, 30 Nov 2017 09:03:40 +0800 Subject: [PATCH 03/40] * fix bug #1081. --- module/testreport/view/blockbugs.html.php | 3 ++- module/testreport/view/blockbuilds.html.php | 3 ++- module/testreport/view/blockcases.html.php | 3 ++- module/testreport/view/blocklegacybugs.html.php | 3 ++- module/testreport/view/blockstories.html.php | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/module/testreport/view/blockbugs.html.php b/module/testreport/view/blockbugs.html.php index 0657f1d489..499ffd9a81 100644 --- a/module/testreport/view/blockbugs.html.php +++ b/module/testreport/view/blockbugs.html.php @@ -1,3 +1,4 @@ +session->notHead ? common::getSysURL() : '';?> @@ -16,7 +17,7 @@ - + diff --git a/module/testreport/view/blockbuilds.html.php b/module/testreport/view/blockbuilds.html.php index 149559ea85..5dff9a2689 100644 --- a/module/testreport/view/blockbuilds.html.php +++ b/module/testreport/view/blockbuilds.html.php @@ -1,3 +1,4 @@ +session->notHead ? common::getSysURL() : '';?>
id . html::hidden('bugs[]', $bug->id)?> bug->priList, $bug->pri);?>createLink('bug', 'view', "bugID=$bug->id", '', true), $bug->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?>createLink('bug', 'view', "bugID=$bug->id", '', true), $bug->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?> openedBy);?> resolvedBy);?> resolvedDate != '0000-00-00 00:00:00') echo substr($bug->resolvedDate, 2);?>
@@ -12,7 +13,7 @@ - + diff --git a/module/testreport/view/blockcases.html.php b/module/testreport/view/blockcases.html.php index 138962c28d..968f68b911 100644 --- a/module/testreport/view/blockcases.html.php +++ b/module/testreport/view/blockcases.html.php @@ -1,3 +1,4 @@ +session->notHead ? common::getSysURL() : '';?>
id . html::hidden('builds[]', $build->id)?>createLink('build', 'view', "buildID=$build->id", '', true), $build->name, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?>createLink('build', 'view', "buildID=$build->id", '', true), $build->name, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?> builder);?> date;?>
@@ -18,7 +19,7 @@ - + diff --git a/module/testreport/view/blocklegacybugs.html.php b/module/testreport/view/blocklegacybugs.html.php index d8df6c234c..d80798283d 100644 --- a/module/testreport/view/blocklegacybugs.html.php +++ b/module/testreport/view/blocklegacybugs.html.php @@ -1,3 +1,4 @@ +session->notHead ? common::getSysURL() : '';?>
id . html::hidden('cases[]', $case->id)?> testcase->priList, $case->pri);?>createLink('testcase', 'view', "caseID=$case->id", '', true), $case->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?>createLink('testcase', 'view', "caseID=$case->id", '', true), $case->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?> testcase->typeList, $case->type);?> assignedTo);?> lastRunner);?>
@@ -16,7 +17,7 @@ - + diff --git a/module/testreport/view/blockstories.html.php b/module/testreport/view/blockstories.html.php index 367d50069f..531b207fe6 100644 --- a/module/testreport/view/blockstories.html.php +++ b/module/testreport/view/blockstories.html.php @@ -1,3 +1,4 @@ +session->notHead ? common::getSysURL() : '';?>
id?> bug->priList, $bug->pri, $bug->pri);?>createLink('bug', 'view', "bugID=$bug->id", '', true), $bug->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?>createLink('bug', 'view', "bugID=$bug->id", '', true), $bug->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?> openedBy);?> resolvedBy);?> resolvedDate != '0000-00-00 00:00:00') echo substr($bug->resolvedDate, 2);?>
@@ -17,7 +18,7 @@ - + From 76ea4b62e54495169d2278ea8d747a315492de68 Mon Sep 17 00:00:00 2001 From: wangyidong Date: Thu, 30 Nov 2017 09:25:22 +0800 Subject: [PATCH 04/40] * fix bug #993. --- module/task/model.php | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/module/task/model.php b/module/task/model.php index bf17871795..257e7da219 100644 --- a/module/task/model.php +++ b/module/task/model.php @@ -382,20 +382,7 @@ class taskModel extends model } } - if($task->consumed < $oldTask->consumed) - { - die(js::error($this->lang->task->error->consumedSmall)); - } - elseif($task->consumed != $oldTask->consumed or $task->left != $oldTask->left) - { - $estimate = new stdClass(); - $estimate->consumed = $task->consumed - $oldTask->consumed; - $estimate->left = $task->left; - $estimate->task = $taskID; - $estimate->account = $this->app->user->account; - $estimate->date = helper::now(); - $this->addTaskEstimate($estimate); - } + if($task->consumed < $oldTask->consumed) die(js::error($this->lang->task->error->consumedSmall)); $task = $this->loadModel('file')->processImgURL($task, $this->config->task->editor->edit['id'], $this->post->uid); $this->dao->update(TABLE_TASK)->data($task) From 5aae8732dd660680bbd8fb81c52375b7c0ae3b6d Mon Sep 17 00:00:00 2001 From: wangyidong Date: Thu, 30 Nov 2017 14:13:25 +0800 Subject: [PATCH 05/40] * fix bug #843. --- module/testcase/view/showimport.html.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/module/testcase/view/showimport.html.php b/module/testcase/view/showimport.html.php index 4ad3509c24..ca90cbda7b 100644 --- a/module/testcase/view/showimport.html.php +++ b/module/testcase/view/showimport.html.php @@ -6,7 +6,7 @@
-
id . html::hidden('stories[]', $story->id)?> story->priList, $story->pri);?>createLink('story', 'view', "storyID=$story->id", '', true), $story->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?>createLink('story', 'view', "storyID=$story->id", '', true), $story->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'");?> openedBy);?> assignedTo);?> estimate?>
+
@@ -32,7 +32,10 @@ - + $case):?> title)) continue;?> @@ -45,7 +48,7 @@ } else { - echo $key . " {$lang->testcase->new}"; + echo $addID++ . " {$lang->testcase->new}"; } echo html::hidden("product[$key]", $productID); ?> @@ -100,7 +103,7 @@
testcase->id?>