From e4dc723347ed5e135b2bfb2d2122c21d250502c9 Mon Sep 17 00:00:00 2001
From: caoyanyi <caoyanyi@easycorp.ltd>
Date: Wed, 24 Jul 2024 16:09:43 +0800
Subject: [PATCH] * [task#123787,doing,0.2] format code for repo model.

---
 module/repo/model.php | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/module/repo/model.php b/module/repo/model.php
index 89904c93cc..0f9206c3ec 100644
--- a/module/repo/model.php
+++ b/module/repo/model.php
@@ -3019,7 +3019,7 @@ class repoModel extends model
      */
     public function setHideMenu(int $objectID): int
     {
-        $menuGroup = $this->app->tab == 'project' ? array('project', 'waterfall') : 'execution';
+        $menuGroup = $this->app->tab == 'project' ? array('project', 'waterfall') : array('execution');
         $repoPairs = $this->loadModel('repo')->getRepoPairs($this->app->tab, $objectID);
 
         $showMR    = false;
@@ -3034,11 +3034,14 @@ class repoModel extends model
             if(in_array($result, $this->config->repo->gitServiceList)) $showMR = true;
         }
 
+        $showMR     = $showMR    && common::hasPriv('mr', 'browse');
+        $showTag    = $showTag   && common::hasPriv('repo', 'browsetag');
+        $showReview = $repoPairs && common::hasPriv('repo', 'review');
         foreach($menuGroup as $module)
         {
-            if(!$showMR || !common::hasPriv('mr', 'browse'))       unset($this->lang->{$module}->menu->devops['subMenu']->mr);
-            if(!$showTag || !common::hasPriv('repo', 'browsetag')) unset($this->lang->{$module}->menu->devops['subMenu']->tag);
-            if(!$repoPairs || !common::hasPriv('repo', 'review'))  unset($this->lang->{$module}->menu->devops['subMenu']->review);
+            if(!$showMR)     unset($this->lang->{$module}->menu->devops['subMenu']->mr);
+            if(!$showTag)    unset($this->lang->{$module}->menu->devops['subMenu']->tag);
+            if(!$showReview) unset($this->lang->{$module}->menu->devops['subMenu']->review);
             if(count((array)$this->lang->{$module}->menu->devops['subMenu']) < 2) unset($this->lang->{$module}->menu->devops['subMenu']);
         }
         return $objectID;