From b89e3d066526b36d853b873673c384176522fef0 Mon Sep 17 00:00:00 2001 From: Yagami <976204163@qq.com> Date: Fri, 9 Apr 2021 17:13:25 +0800 Subject: [PATCH 01/11] * Fix Version. --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index 343f3a761a..893d61407f 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -15.0.rc1 +15.0.rc2 From d0e21dee63015805fbceb27cb2f3038bdda3f195 Mon Sep 17 00:00:00 2001 From: leiyong <1549684884@qq.com> Date: Fri, 9 Apr 2021 13:16:24 +0300 Subject: [PATCH 02/11] * Fix bug. --- module/bug/model.php | 2 +- module/build/control.php | 8 +--- module/execution/control.php | 46 +++++++------------ module/execution/view/kanban.html.php | 6 +-- module/project/control.php | 2 +- module/projectrelease/control.php | 39 ++++++++-------- module/projectrelease/view/linkstory.html.php | 2 +- module/projectrelease/view/view.html.php | 2 +- 8 files changed, 46 insertions(+), 61 deletions(-) diff --git a/module/bug/model.php b/module/bug/model.php index 66a68612ff..de6aae5e79 100644 --- a/module/bug/model.php +++ b/module/bug/model.php @@ -1545,7 +1545,7 @@ class bugModel extends model $execution = $this->dao->select('*')->from(TABLE_EXECUTION)->where('id')->eq($build->execution)->fetch(); $beforeBuilds = $this->dao->select('t1.id')->from(TABLE_BUILD)->alias('t1') - ->leftJoin(TABLE_EXECTUION)->alias('t2')->on('t1.execution=t2.id') + ->leftJoin(TABLE_EXECUTION)->alias('t2')->on('t1.execution=t2.id') ->where('t1.product')->eq($productID) ->andWhere('t2.status')->ne('done') ->andWhere('t2.deleted')->eq(0) diff --git a/module/build/control.php b/module/build/control.php index 5885571c91..77fc3f9f14 100644 --- a/module/build/control.php +++ b/module/build/control.php @@ -188,10 +188,6 @@ class build extends control if(!$build) die(js::error($this->lang->notFound) . js::locate('back')); $this->session->project = $build->project; - /* Set session and load modules. */ - if($type == 'story')$this->session->set('storyList', $this->app->getURI(true), 'product'); - if($type == 'bug') $this->session->set('bugList', $this->app->getURI(true), 'qa'); - $this->loadModel('story'); $this->loadModel('bug'); @@ -404,7 +400,7 @@ class build extends control } /** - * Link stories + * Link stories. * * @param int $buildID * @param string $browseType @@ -423,7 +419,7 @@ class build extends control die(js::locate(inlink('view', "buildID=$buildID&type=story"), 'parent')); } - $this->session->set('storyList', inlink('view', "buildID=$buildID&type=story&link=true¶m=" . helper::safe64Encode("&browseType=$browseType&queryID=$param")), 'product'); + $this->session->set('storyList', inlink('view', "buildID=$buildID&type=story&link=true¶m=" . helper::safe64Encode("&browseType=$browseType&queryID=$param")), $this->app->openApp); $build = $this->build->getById($buildID); $product = $this->loadModel('product')->getById($build->product); diff --git a/module/execution/control.php b/module/execution/control.php index 4910f1a1e6..793ff62603 100644 --- a/module/execution/control.php +++ b/module/execution/control.php @@ -258,6 +258,7 @@ class execution extends control * * @param int $executionID * @param string $groupBy the field to group by + * @param string $filter * @access public * @return void */ @@ -268,7 +269,6 @@ class execution extends control /* Save session. */ $this->app->session->set('taskList', $this->app->getURI(true), 'execution'); - $this->app->session->set('storyList', $this->app->getURI(true), 'product'); /* Header and session. */ $this->view->title = $execution->name . $this->lang->colon . $this->lang->execution->task; @@ -491,7 +491,6 @@ class execution extends control /* Save session. */ $this->app->session->set('taskList', $this->app->getURI(true), 'execution'); - $this->app->session->set('storyList', $this->app->getURI(true), 'product'); $this->view->title = $execution->name . $this->lang->colon . $this->lang->execution->importTask; $this->view->position[] = html::a(inlink('browse', "executionID=$toExecution"), $execution->name); @@ -530,12 +529,6 @@ class execution extends control $browseType = strtolower($browseType); $queryID = ($browseType == 'bysearch') ? (int)$param : 0; - /* Save to session. */ - $uri = $this->app->getURI(true); - $this->app->session->set('bugList', $uri, 'qa'); - $this->app->session->set('storyList', $uri, 'product'); - $this->app->session->set('executionList', $uri, 'execution'); - $this->loadModel('bug'); $executions = $this->execution->getPairs(0, 'all', 'nocode'); $this->execution->setMenu($executionID); @@ -819,7 +812,7 @@ class execution extends control } /** - * Exectuion qa dashboard. + * Execution qa dashboard. * * @param int $executionID * @access public @@ -1808,7 +1801,6 @@ class execution extends control /* Save to session. */ $uri = $this->app->getURI(true); $this->app->session->set('taskList', $uri, 'execution'); - $this->app->session->set('storyList', $uri, 'product'); $this->app->session->set('bugList', $uri, 'qa'); /* Compatibility IE8*/ @@ -1833,9 +1825,9 @@ class execution extends control $this->view->realnames = $this->loadModel('user')->getPairs('noletter'); $this->view->storyOrder = $orderBy; $this->view->orderBy = 'id_asc'; - $this->view->executionID = $executionID; + $this->view->executionID = $executionID; $this->view->browseType = ''; - $this->view->execution = $execution; + $this->view->execution = $execution; $this->view->type = $type; $this->view->kanbanGroup = $kanbanGroup; $this->view->kanbanColumns = $this->execution->getKanbanColumns($kanbanSetting); @@ -1865,8 +1857,8 @@ class execution extends control /* Save to session. */ $uri = $this->app->getURI(true); - $this->app->session->set('taskList', $uri, 'execution'); - $this->app->session->set('storyList', $uri, 'product'); + $this->app->session->set('taskList', $uri, 'execution'); + $this->app->session->set('storyList', $uri, 'execution'); $this->app->session->set('executionList', $uri, 'execution'); $this->app->session->set('caseList', $uri, 'qa'); $this->app->session->set('bugList', $uri, 'qa'); @@ -2001,10 +1993,6 @@ class execution extends control */ public function storyKanban($executionID) { - /* Save to session. */ - $uri = $this->app->getURI(true); - $this->app->session->set('storyList', $uri, 'product'); - /* Compatibility IE8*/ if(strpos($this->server->http_user_agent, 'MSIE 8.0') !== false) header("X-UA-Compatible: IE=EmulateIE7"); @@ -2023,8 +2011,8 @@ class execution extends control $this->view->position[] = $this->lang->execution->storyKanban; $this->view->stories = $this->story->getKanbanGroupData($stories); $this->view->realnames = $this->loadModel('user')->getPairs('noletter'); - $this->view->executionID = $executionID; - $this->view->execution = $execution; + $this->view->executionID = $executionID; + $this->view->execution = $execution; $this->view->productID = $productID; $this->view->canBeChanged = common::canModify('execution', $execution); // Determines whether an object is editable. @@ -2367,15 +2355,15 @@ class execution extends control $this->view->position[] = html::a($browseLink, $object->name); $this->view->position[] = $this->lang->execution->linkStory; - $this->view->object = $object; - $this->view->products = $products; - $this->view->allStories = empty($allStories) ? $allStories : $allStories[$pageID - 1];; - $this->view->pager = $pager; - $this->view->browseType = $browseType; - $this->view->productType = $productType; - $this->view->modules = $modules; - $this->view->users = $this->loadModel('user')->getPairs('noletter'); - $this->view->branchGroups = $branchGroups; + $this->view->object = $object; + $this->view->products = $products; + $this->view->allStories = empty($allStories) ? $allStories : $allStories[$pageID - 1];; + $this->view->pager = $pager; + $this->view->browseType = $browseType; + $this->view->productType = $productType; + $this->view->modules = $modules; + $this->view->users = $this->loadModel('user')->getPairs('noletter'); + $this->view->branchGroups = $branchGroups; $this->display(); } diff --git a/module/execution/view/kanban.html.php b/module/execution/view/kanban.html.php index ce4ddb33e2..49307adf4f 100644 --- a/module/execution/view/kanban.html.php +++ b/module/execution/view/kanban.html.php @@ -124,9 +124,9 @@