From d2f0306153125e521702be4457350927d693ae4e Mon Sep 17 00:00:00 2001
From: luxuyang <luxuyang@easycorp.ltd>
Date: Wed, 26 Jun 2024 13:46:08 +0800
Subject: [PATCH] + [test,done,0.5h,0h] add function comments.

---
 module/bug/test/lib/confirmbug.ui.class.php | 40 +++++++++++++++------
 1 file changed, 30 insertions(+), 10 deletions(-)

diff --git a/module/bug/test/lib/confirmbug.ui.class.php b/module/bug/test/lib/confirmbug.ui.class.php
index 4846ae894f..aa5649fb15 100644
--- a/module/bug/test/lib/confirmbug.ui.class.php
+++ b/module/bug/test/lib/confirmbug.ui.class.php
@@ -3,6 +3,15 @@
 include dirname(__FILE__, 5) . '/test/lib/ui.php';
 class confirmBugTester extends tester
 {
+    /**
+     * 确认bug。
+     * Confirm a bug.
+     *
+     * @param  array  $project
+     * @param  array  $bug
+     * @access public
+     * @return object
+     */
     public function confirmBug($project = array(), $bug = array())
     {
         $this->login();
@@ -24,10 +33,18 @@ class confirmBugTester extends tester
         $list->dom->btn($this->lang->bug->confirm)->click();
         $this->webdriver->wait(1);
 
-        return $this->bugAssert();
-
+        return $this->bugAssert($bugTitle, $list);
     }
 
+    /**
+     * 解决bug。
+     * Resolve a bug.
+     *
+     * @param  array  $project
+     * @param  array  $bug
+     * @access public
+     * @return object
+     */
     public function resolveBug($project = array(), $bug = array())
     {
         $this->login();
@@ -37,7 +54,6 @@ class confirmBugTester extends tester
         $list->dom->value1->picker($bug['isResolved']);
         $list->dom->searchButton->click();
         $this->webdriver->wait(1);
-        return $this->bugAssert();
         $bugTitle = $list->dom->bugTitle->getText();
         $list->dom->resolveButton->click();
         $this->webdriver->wait(1);
@@ -49,20 +65,24 @@ class confirmBugTester extends tester
         $list->dom->btn($this->lang->bug->resolve)->click();
         $this->webdriver->wait(1);
 
-        return $this->bugAssert();
+        return $this->bugAssert($bugTitle, $list);
     }
 
+    /**
+     * 给bug列表上的操作增加断言。
+     * Add a assertion on bug list.
+     *
+     * @param  string  $bugTitle
+     * @param  object  $list
+     * @access public
+     * @return object
+     */
     public function bugAssert(string $bugTitle = '', object $list = null)
     {
         if(!isset($bugTitle) || !is_object($list)) return $this->failed('获取bug标题失败');
 
         $bugTitleLists = $list->dom->bugTitleList->getElementList($list->dom->page->xpath['bugTitleList']);
-        $bugList = [];
-        foreach($bugTitleLists->element as $bugTitleList)
-        {
-           $bugList[] = $bugTitleList->getText();
-        }
-
+        $bugList = array_map(function($element){return $element->getText();}, $bugTitleLists->element);
         if(!in_array($bugTitle, $bugList)) return $this->success('操作bug成功');
         return $this->failed('操作bug失败');
     }