From cefdbaa5d36873bb010f03d05d52bc90f8aa6ead Mon Sep 17 00:00:00 2001
From: chenfeiCF <chenfei@qdphp.com>
Date: Thu, 15 Nov 2018 15:20:42 +0800
Subject: [PATCH]  * Finish task #5133.

---
 module/project/css/common.css     | 4 ++--
 module/project/view/task.html.php | 6 ++++--
 module/task/model.php             | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/module/project/css/common.css b/module/project/css/common.css
index 4ba392d26f..450076be5e 100644
--- a/module/project/css/common.css
+++ b/module/project/css/common.css
@@ -11,8 +11,8 @@
 #productsBox .input-group.has-branch > select[name*="branch"] + .chosen-container.chosen-container-active  .chosen-single {border-left-width: 1px; padding-left: 8px;}
 
 .table-children {border-left: 2px solid #cbd0db; border-right: 2px solid #cbd0db;}
-.table-children.table-child-top {border-top: 2px solid #cbd0db;}
-.table-children.table-child-bottom {border-bottom: 2px solid #cbd0db;}
+.table tbody > tr.table-children.table-child-top {border-top: 2px solid #cbd0db;}
+.table tbody > tr.table-children.table-child-bottom {border-bottom: 2px solid #cbd0db;}
 .table td.has-child > a {max-width: 90%; max-width: calc(100% - 30px); display: inline-block; overflow: hidden; text-overflow: ellipsis; white-space: nowrap;}
 .table td.has-child > .task-toggle {color: #838a9d; position: relative; top: 1px;}
 .table td.has-child > .task-toggle:hover {color: #006af1; cursor: pointer;}
diff --git a/module/project/view/task.html.php b/module/project/view/task.html.php
index 59b0ab256f..523105c66b 100644
--- a/module/project/view/task.html.php
+++ b/module/project/view/task.html.php
@@ -225,12 +225,14 @@ js::set('browseType', $browseType);
             <?php foreach($customFields as $field) $this->task->printCell($field, $task, $users, $browseType, $branchGroups, $modulePairs, $useDatatable ? 'datatable' : 'table');?>
           </tr>
           <?php if(!empty($task->children)):?>
+          <?php $i = 0;?>
           <?php foreach($task->children as $key => $child):?>
-          <?php $class  = $key == 0 ? ' table-child-top' : '';?>
-          <?php $class .= ($key + 1 == count($task->children)) ? ' table-child-bottom' : '';?>
+          <?php $class  = $i == 0 ? ' table-child-top' : '';?>
+          <?php $class .= ($i + 1 == count($task->children)) ? ' table-child-bottom' : '';?>
           <tr class='table-children<?php echo $class;?> parent-<?php echo $task->id;?>' data-id='<?php echo $child->id?>' data-status='<?php echo $child->status?>' data-estimate='<?php echo $child->estimate?>' data-consumed='<?php echo $child->consumed?>' data-left='<?php echo $child->left?>'>
             <?php foreach($customFields as $field) $this->task->printCell($field, $child, $users, $browseType, $branchGroups, $modulePairs, $useDatatable ? 'datatable' : 'table', true);?>
           </tr>
+          <?php $i ++;?>
           <?php endforeach;?>
           <?php endif;?>
           <?php endforeach;?>
diff --git a/module/task/model.php b/module/task/model.php
index c458c4d8b0..9d442270d6 100644
--- a/module/task/model.php
+++ b/module/task/model.php
@@ -1511,7 +1511,7 @@ class taskModel extends model
             ->beginIF(is_array($type) or strpos(',all,undone,needconfirm,assignedtome,delayed,finishedbyme,myinvolved,', ",$type,") === false)->andWhere('t1.status')->in($type)->fi()
             ->beginIF($modules)->andWhere('t1.module')->in($modules)->fi()
             ->andWhere('t1.deleted')->eq(0)
-            ->orderBy('t1.`parent`,' . $orderBy)
+            ->orderBy($orderBy)
             ->page($pager, 't1.id')
             ->fetchAll('id');