From c1124e377c15256bfca92ea4d5644f9bf3871f6f Mon Sep 17 00:00:00 2001
From: liugang <liugang@chandao.com>
Date: Sat, 20 Sep 2025 12:57:21 +0800
Subject: [PATCH] * [misc] Enhance unit tests for
 gitlabModel::apiUpdateProject() method
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 .../gitlab/test/lib/gitlab.unittest.class.php | 16 ++++++
 module/gitlab/test/model/apiupdateproject.php | 54 +++++++++++++------
 2 files changed, 55 insertions(+), 15 deletions(-)

diff --git a/module/gitlab/test/lib/gitlab.unittest.class.php b/module/gitlab/test/lib/gitlab.unittest.class.php
index 08ab5ae1f4..3469114732 100755
--- a/module/gitlab/test/lib/gitlab.unittest.class.php
+++ b/module/gitlab/test/lib/gitlab.unittest.class.php
@@ -1400,4 +1400,20 @@ class gitlabTest
 
         return $result;
     }
+
+    /**
+     * Test apiUpdateProject method.
+     *
+     * @param  int    $gitlabID
+     * @param  object $project
+     * @access public
+     * @return object|array|null|false
+     */
+    public function apiUpdateProjectTest(int $gitlabID, object $project): object|array|null|false
+    {
+        $result = $this->gitlab->apiUpdateProject($gitlabID, $project);
+        if(dao::isError()) return dao::getError();
+
+        return $result;
+    }
 }
diff --git a/module/gitlab/test/model/apiupdateproject.php b/module/gitlab/test/model/apiupdateproject.php
index 07f72440f0..9940712382 100755
--- a/module/gitlab/test/model/apiupdateproject.php
+++ b/module/gitlab/test/model/apiupdateproject.php
@@ -8,23 +8,28 @@ title=测试 gitlabModel::apiUpdateProject();
 timeout=0
 cid=1
 
-- 使用空的projectID创建gitlab群组 @0
-- 使用错误gitlabID创建群组 @0
-- 通过gitlabID,用户对象正确更新项目描述属性description @apiUpdatedProject
+- 执行gitlab模块的apiUpdateProject方法，参数是$gitlabID, $emptyProject  @0
+- 执行gitlab模块的apiUpdateProject方法，参数是0, $invalidProject  @0
+- 执行gitlab模块的apiUpdateProject方法，参数是$gitlabID, $validProject 属性description @apiUpdatedProject
+- 执行gitlab模块的apiUpdateProject方法，参数是$gitlabID, $multiAttrProject 属性name @Updated Project Name
+- 执行gitlab模块的apiUpdateProject方法，参数是$gitlabID, $nonExistentProject  @~~
 
 */
 
 zenData('pipeline')->gen(5);
 
+global $app;
+$app->rawModule = 'gitlab';
+$app->rawMethod = 'browse';
+
 $gitlab = $tester->loadModel('gitlab');
 
-$gitlabID    = 1;
-$projectName = 'unitTestUpdateProject' . time();
+$gitlabID = 1;
 
-/* Create project. */
+/* Create test project first. */
 $project = new stdclass();
-$project->name         = $projectName;
-$project->path         = $projectName;
+$project->name         = 'unitTestProject99';
+$project->path         = 'unit_test_project99';
 $project->description  = 'unit_test_project desc';
 $project->visibility   = 'public';
 $project->namespace_id = '1';
@@ -32,20 +37,39 @@ $gitlab->apiCreateProject($gitlabID, $project);
 
 /* Get projectID. */
 $gitlabProjects = $gitlab->apiGetProjects($gitlabID);
+$projectID = 0;
 foreach($gitlabProjects as $gitlabProject)
 {
-    if($gitlabProject->name == $projectName)
+    if($gitlabProject->name == 'unitTestProject99')
     {
         $projectID = $gitlabProject->id;
         break;
     }
 }
 
-$project = new stdclass();
-$project->description = 'apiUpdatedProject';
+/* Test cases. */
+$emptyProject = new stdclass();
+$emptyProject->description = 'test description';
 
-r($gitlab->apiUpdateProject($gitlabID, $project)) && p() && e('0'); //使用空的projectID创建gitlab群组
-r($gitlab->apiUpdateProject(0, $project))         && p() && e('0'); //使用错误gitlabID创建群组
+$invalidProject = new stdclass();
+$invalidProject->id = $projectID;
+$invalidProject->description = 'apiUpdatedProject';
 
-$project->id = $projectID;
-r($gitlab->apiUpdateProject($gitlabID, $project)) && p('description') && e('apiUpdatedProject'); //通过gitlabID,用户对象正确更新项目描述
+$validProject = new stdclass();
+$validProject->id = $projectID;
+$validProject->description = 'apiUpdatedProject';
+
+$multiAttrProject = new stdclass();
+$multiAttrProject->id = $projectID;
+$multiAttrProject->name = 'Updated Project Name';
+$multiAttrProject->description = 'Updated description';
+
+$nonExistentProject = new stdclass();
+$nonExistentProject->id = 888888;
+$nonExistentProject->description = 'Non-existent project';
+
+r($gitlab->apiUpdateProject($gitlabID, $emptyProject)) && p() && e('0');
+r($gitlab->apiUpdateProject(0, $invalidProject)) && p() && e('0');
+r($gitlab->apiUpdateProject($gitlabID, $validProject)) && p('description') && e('apiUpdatedProject');
+r($gitlab->apiUpdateProject($gitlabID, $multiAttrProject)) && p('name') && e('Updated Project Name');
+r($gitlab->apiUpdateProject($gitlabID, $nonExistentProject)) && p() && e('~~');
\ No newline at end of file