diff --git a/extension/lite/story/ext/view/view.html.php b/extension/lite/story/ext/view/view.html.php index fb971c4d9f..df7df73062 100644 --- a/extension/lite/story/ext/view/view.html.php +++ b/extension/lite/story/ext/view/view.html.php @@ -110,7 +110,7 @@ common::printIcon('story', 'change', "storyID=$child->id", $child, 'list', 'alter'); if(strpos('draft,changing', $child->status) !== false) { - common::printIcon('story', 'submitReview', "storyID=$child->id", $child, 'list', 'sub-review', '', 'iframe showinonlybody', true); + common::printIcon('story', 'submitReview', "storyID=$child->id", $child, 'list', 'confirm', '', 'iframe showinonlybody', true); } else { @@ -143,7 +143,7 @@ common::printIcon('story', 'change', "storyID=$story->id", $story, 'button', 'alter', '', 'showinonlybody'); if(strpos('draft,changing', $story->status) !== false) { - common::printIcon('story', 'submitReview', "storyID=$story->id", $story, 'button', 'sub-review', '', 'iframe showinonlybody', true); + common::printIcon('story', 'submitReview', "storyID=$story->id", $story, 'button', 'confirm', '', 'iframe showinonlybody', true); } else { diff --git a/module/bug/control.php b/module/bug/control.php index 66a0585929..14e5cf7de2 100755 --- a/module/bug/control.php +++ b/module/bug/control.php @@ -525,7 +525,7 @@ class bug extends control $severity = $bug->severity; $type = $bug->type; $assignedTo = $bug->assignedTo; - $deadline = $bug->deadline; + $deadline = helper::isZeroDate($bug->deadline) ? '' : $bug->deadline; $color = $bug->color; $testtask = $bug->testtask; if($pri == 0) $pri = '3'; diff --git a/module/bug/model.php b/module/bug/model.php index 593bd21324..dbb79b8230 100644 --- a/module/bug/model.php +++ b/module/bug/model.php @@ -3279,7 +3279,7 @@ class bugModel extends model $title = "title='" . zget($projectPairs, $bug->project, '') . "'"; break; case 'plan': - $title = "title='" . zget($plans, $bug->plan) . "'"; + $title = "title='" . zget($plans, $bug->plan, '') . "'"; break; case 'execution': $title = "title='" . zget($executions, $bug->execution) . "'"; diff --git a/module/build/view/linkstory.html.php b/module/build/view/linkstory.html.php index 9700032238..7bf64d0c76 100644 --- a/module/build/view/linkstory.html.php +++ b/module/build/view/linkstory.html.php @@ -47,7 +47,7 @@ story->priList, $story->pri, $story->pri)?> parent > 0) echo "{$lang->story->childrenAB}"; + if($story->parent > 0) echo "{$lang->story->childrenAB}"; echo html::a($this->createLink('story', 'view', "storyID=$story->id&version=0¶m=$objectID", '', true), $story->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'"); ?> diff --git a/module/build/view/view.html.php b/module/build/view/view.html.php index ea39390fb3..d1f39416fd 100644 --- a/module/build/view/view.html.php +++ b/module/build/view/view.html.php @@ -103,7 +103,7 @@ tbody tr td:first-child input {display: none;} story->priList, $story->pri, $story->pri);?> parent > 0) echo "{$lang->story->childrenAB}"; + if($story->parent > 0) echo "{$lang->story->childrenAB}"; if($this->app->tab == 'execution' and common::hasPriv('execution', 'storyView')) { echo html::a($this->createLink('execution', 'storyView', "storyID=$story->id", '', true), $story->title, '', isonlybody() ? "data-width='1000'" : "class='iframe' data-width='1000'"); diff --git a/module/execution/view/linkstory.html.php b/module/execution/view/linkstory.html.php index 80e97dbfde..29bf65c18d 100644 --- a/module/execution/view/linkstory.html.php +++ b/module/execution/view/linkstory.html.php @@ -66,7 +66,7 @@ pri;?>' title='story->priList, $story->pri, $story->pri);?>'>story->priList, $story->pri, $story->pri);?> parent > 0) echo "{$lang->story->childrenAB}"; + if($story->parent > 0) echo "{$lang->story->childrenAB}"; if(common::hasPriv('execution', 'storyView')) { echo html::a($storyLink, $story->title, '', "class='iframe' data-width='80%'"); diff --git a/module/my/view/requirement.html.php b/module/my/view/requirement.html.php index 8472470c53..37248276c6 100644 --- a/module/my/view/requirement.html.php +++ b/module/my/view/requirement.html.php @@ -107,7 +107,7 @@ if(strpos('draft,changing', $story->status) !== false) { - echo common::buildIconButton('story', 'submitReview', "$vars&storyType=requirement", $story, 'list', 'sub-review', '', 'iframe', true); + echo common::buildIconButton('story', 'submitReview', "$vars&storyType=requirement", $story, 'list', 'confirm', '', 'iframe', true); } else { @@ -155,7 +155,7 @@ if(strpos('draft,changing', $child->status) !== false) { - common::printIcon('story', 'submitReview', "$vars&storyType=story", $child, 'list', 'sub-review', '', 'iframe', true); + common::printIcon('story', 'submitReview', "$vars&storyType=story", $child, 'list', 'confirm', '', 'iframe', true); } else { diff --git a/module/my/view/story.html.php b/module/my/view/story.html.php index e19a82ece3..b309858436 100644 --- a/module/my/view/story.html.php +++ b/module/my/view/story.html.php @@ -108,7 +108,7 @@ if(strpos('draft,changing', $story->status) !== false) { - echo common::buildIconButton('story', 'submitReview', $vars, $story, 'list', 'sub-review', '', 'iframe', true); + echo common::buildIconButton('story', 'submitReview', $vars, $story, 'list', 'confirm', 'confirm', 'iframe', true); } else { @@ -158,7 +158,7 @@ if(strpos('draft,changing', $child->status) !== false) { - common::printIcon('story', 'submitReview', $vars, $child, 'list', 'sub-review', '', 'iframe', true); + common::printIcon('story', 'submitReview', $vars, $child, 'list', 'confirm', '', 'iframe', true); } else { diff --git a/module/product/view/ajaxgetdropmenu.html.php b/module/product/view/ajaxgetdropmenu.html.php index dab16dd063..81b430e4d9 100644 --- a/module/product/view/ajaxgetdropmenu.html.php +++ b/module/product/view/ajaxgetdropmenu.html.php @@ -26,7 +26,7 @@ #swapper .tree li>.list-toggle {top: -1px;} #subHeader .tree ul {display: block;} -#closed {width: 90px; height: 25px; line-height: 25px; background-color: #ddd; color: #3c495c; text-align: center; margin-left: 15px; border-radius: 2px;} +div#closed {width: 90px; height: 25px; line-height: 25px; background-color: #ddd; color: #3c495c; text-align: center; margin-left: 15px; border-radius: 2px;} #gray-line {width: 230px; height: 1px; margin-left: 10px; margin-bottom:2px; background-color: #ddd;} #swapper li >.selected {color: #0c64eb!important;background: #e9f2fb!important;} diff --git a/module/projectrelease/view/linkstory.html.php b/module/projectrelease/view/linkstory.html.php index 2d37e27b1c..36f169da5f 100644 --- a/module/projectrelease/view/linkstory.html.php +++ b/module/projectrelease/view/linkstory.html.php @@ -50,7 +50,7 @@ pri;?>' title='story->priList, $story->pri)?>'>story->priList, $story->pri)?> parent > 0) echo "{$lang->story->childrenAB}"; + if($story->parent > 0) echo "{$lang->story->childrenAB}"; echo html::a($this->createLink('story', 'view', "storyID={$story->id}&version=0¶m=$projectID", '', true), $story->title, '', "data-toggle='modal' data-type='iframe' data-width='90%'"); ?> diff --git a/module/projectrelease/view/view.html.php b/module/projectrelease/view/view.html.php index 9ac0487fc3..70378c16b2 100644 --- a/module/projectrelease/view/view.html.php +++ b/module/projectrelease/view/view.html.php @@ -94,7 +94,7 @@ pri;?>' title='story->priList, $story->pri, $story->pri);?>'>story->priList, $story->pri, $story->pri);?> parent > 0) echo "{$lang->story->childrenAB}"; + if($story->parent > 0) echo "{$lang->story->childrenAB}"; echo html::a($storyLink,$story->title, '', "class='preview'"); ?> diff --git a/module/story/control.php b/module/story/control.php index b29572e3e1..16b4b7158b 100644 --- a/module/story/control.php +++ b/module/story/control.php @@ -1858,11 +1858,18 @@ class story extends control $storyGroup = array(); foreach($stories as $story) { - if(strpos('draft,reviewing,changing,closed', $story->status) !== false) continue; + if(strpos('draft,reviewing,changing,closed', $story->status) !== false) + { + unset($stories[$story->id]); + continue; + } + if(isset($storyGroup[$story->module])) continue; $storyGroup[$story->module] = $this->story->getExecutionStoryPairs($executionID, 0, 'all', $story->module, 'short', 'active'); } + if(empty($stories)) return print(js::error($this->lang->story->noStoryToTask) . js::locate($this->session->storyList)); + $this->view->title = $this->lang->story->batchToTask; $this->view->executionID = $executionID; $this->view->syncFields = empty($_POST['fields']) ? array() : $_POST['fields']; diff --git a/module/story/lang/de.php b/module/story/lang/de.php index 4dc37b3253..b4fd31b40c 100644 --- a/module/story/lang/de.php +++ b/module/story/lang/de.php @@ -307,6 +307,7 @@ $lang->story->confirmChangePlan = $lang->SRCommon . ' %s is linked to the bra $lang->story->errorDuplicateStory = $lang->SRCommon . '%s not exist'; $lang->story->confirmRecallChange = "After undo the change, the story content will revert to the version before the change. Are you sure you want to undo?"; $lang->story->confirmRecallReview = "Are you sure you want to withdraw the review?"; +$lang->story->noStoryToTask = "Only the activated {$lang->SRCommon} can be converted into a task!"; $lang->story->form = new stdclass(); $lang->story->form->area = 'Story Bereich'; diff --git a/module/story/lang/en.php b/module/story/lang/en.php index 07a0fea7d6..eaf61f59dd 100644 --- a/module/story/lang/en.php +++ b/module/story/lang/en.php @@ -307,6 +307,7 @@ $lang->story->confirmChangePlan = $lang->SRCommon . ' %s is linked to the bra $lang->story->errorDuplicateStory = $lang->SRCommon . '%s not exist'; $lang->story->confirmRecallChange = "After undo the change, the story content will revert to the version before the change. Are you sure you want to undo?"; $lang->story->confirmRecallReview = "Are you sure you want to withdraw the review?"; +$lang->story->noStoryToTask = "Only the activated {$lang->SRCommon} can be converted into a task!"; $lang->story->form = new stdclass(); $lang->story->form->area = 'Scope'; diff --git a/module/story/lang/fr.php b/module/story/lang/fr.php index 529500b906..d0bff1b1f6 100644 --- a/module/story/lang/fr.php +++ b/module/story/lang/fr.php @@ -307,6 +307,7 @@ $lang->story->confirmChangePlan = $lang->SRCommon . ' %s is linked to the bra $lang->story->errorDuplicateStory = $lang->SRCommon . '%s not exist'; $lang->story->confirmRecallChange = "After undo the change, the story content will revert to the version before the change. Are you sure you want to undo?"; $lang->story->confirmRecallReview = "Are you sure you want to withdraw the review?"; +$lang->story->noStoryToTask = "Only the activated {$lang->SRCommon} can be converted into a task!"; $lang->story->form = new stdclass(); $lang->story->form->area = 'Périmètre'; diff --git a/module/story/lang/vi.php b/module/story/lang/vi.php index b21627c2cf..e92b3a8b0c 100644 --- a/module/story/lang/vi.php +++ b/module/story/lang/vi.php @@ -299,6 +299,7 @@ $lang->story->confirmChangePlan = $lang->SRCommon . ' %s is linked to the bra $lang->story->errorDuplicateStory = $lang->SRCommon . '%s not exist'; $lang->story->confirmRecallChange = "After undo the change, the story content will revert to the version before the change. Are you sure you want to undo?"; $lang->story->confirmRecallReview = "Are you sure you want to withdraw the review?"; +$lang->story->noStoryToTask = "Only the activated {$lang->SRCommon} can be converted into a task!"; $lang->story->form = new stdclass(); $lang->story->form->area = 'Phạm vi'; diff --git a/module/story/lang/zh-cn.php b/module/story/lang/zh-cn.php index 3448bbfdc9..b33b955e51 100644 --- a/module/story/lang/zh-cn.php +++ b/module/story/lang/zh-cn.php @@ -307,6 +307,7 @@ $lang->story->confirmChangePlan = $lang->SRCommon . '%s已关联在之前计 $lang->story->errorDuplicateStory = $lang->SRCommon . '%s不存在'; $lang->story->confirmRecallChange = "撤销变更后,需求内容会回退至变更前的版本,您确定要撤销吗?"; $lang->story->confirmRecallReview = "您确定要撤回评审吗?"; +$lang->story->noStoryToTask = "只有激活的{$lang->SRCommon}才能转为任务!"; $lang->story->form = new stdclass(); $lang->story->form->area = "该{$lang->SRCommon}所属范围"; diff --git a/module/story/view/create.html.php b/module/story/view/create.html.php index b035884158..856bc23ffe 100644 --- a/module/story/view/create.html.php +++ b/module/story/view/create.html.php @@ -11,9 +11,6 @@ */ ?> - story->placeholder); ?> diff --git a/module/task/control.php b/module/task/control.php index c847bc4a05..ec0881ee7e 100755 --- a/module/task/control.php +++ b/module/task/control.php @@ -230,7 +230,7 @@ class task extends control elseif($this->post->after == 'toTaskList') { setcookie('moduleBrowseParam', 0, 0, $this->config->webRoot, '', $this->config->cookieSecure, false); - $taskLink = $this->createLink('execution', 'task', "executionID=$executionID&status=all¶m=0&orderBy=id_desc"); + $taskLink = $this->createLink('execution', 'task', "executionID=$executionID&status=unclosed¶m=0&orderBy=id_desc"); $response['locate'] = $taskLink; return $this->send($response); }