diff --git a/module/testcase/control.php b/module/testcase/control.php index d4cb58a483..3aec963670 100644 --- a/module/testcase/control.php +++ b/module/testcase/control.php @@ -216,7 +216,7 @@ class testcase extends control $this->view->browseType = $browseType; $this->view->param = $param; $this->view->cases = $cases; - $this->view->branch = $branch; + $this->view->branch = $product->type == 'normal' ? 0 : $branch; $this->view->branchOption = $branchOption; $this->view->branchTagOption = $branchTagOption; $this->view->suiteList = $this->loadModel('testsuite')->getSuites($productID); @@ -1942,12 +1942,6 @@ class testcase extends control } unset($rows[0]); - foreach($header as $title) - { - if(!isset($fields[$title])) continue; - $columnKey[] = $fields[$title]; - } - $endField = end($fields); $caseData = array(); $stepData = array(); @@ -1955,8 +1949,11 @@ class testcase extends control foreach($rows as $row => $data) { $case = new stdclass(); - foreach($columnKey as $key => $field) + foreach($header as $key => $title) { + if(!isset($fields[$title])) continue; + $field = $fields[$title]; + if(!isset($data[$key])) continue; $cellValue = $data[$key]; if($field == 'story' or $field == 'module' or $field == 'branch') diff --git a/module/testcase/model.php b/module/testcase/model.php index b1aac04082..1158b7b9b7 100644 --- a/module/testcase/model.php +++ b/module/testcase/model.php @@ -1232,7 +1232,7 @@ class testcaseModel extends model $cases[$key] = $caseData; $line++; } - if(dao::isError()) return print(js::error(dao::getError())); + if(dao::isError()) return false; $forceNotReview = $this->forceNotReview(); foreach($cases as $key => $caseData) diff --git a/module/testcase/view/caseheader.html.php b/module/testcase/view/caseheader.html.php index 6927be6b07..2ca6320c31 100644 --- a/module/testcase/view/caseheader.html.php +++ b/module/testcase/view/caseheader.html.php @@ -138,9 +138,10 @@