-

branch->editAction, $lang->product->branchName[$product->type]);?>

+

branch->edit, $lang->product->branchName[$product->type]);?>

diff --git a/module/group/lang/resource.php b/module/group/lang/resource.php index d582ce1d2e..786d2cf8b8 100644 --- a/module/group/lang/resource.php +++ b/module/group/lang/resource.php @@ -421,8 +421,8 @@ $lang->product->methodOrder[105] = 'unbindWhitelist'; /* Branch. */ $lang->resource->branch = new stdclass(); $lang->resource->branch->manage = 'manage'; -$lang->resource->branch->create = 'createBranch'; -$lang->resource->branch->edit = 'editBranch'; +$lang->resource->branch->create = 'createAction'; +$lang->resource->branch->edit = 'editAction'; $lang->resource->branch->close = 'closeAction'; $lang->resource->branch->activate = 'activateAction'; $lang->resource->branch->sort = 'sort'; From 4a07c2324f8fe030f27f359f0906737f2e487eda Mon Sep 17 00:00:00 2001 From: hufangzhou Date: Thu, 18 Nov 2021 21:41:48 +0800 Subject: [PATCH 112/120] * Fix bug #16385 and fix an error. --- module/group/view/manageview.html.php | 2 +- module/stakeholder/model.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/module/group/view/manageview.html.php b/module/group/view/manageview.html.php index 77b2cb578f..ddaa99e4e2 100644 --- a/module/group/view/manageview.html.php +++ b/module/group/view/manageview.html.php @@ -26,7 +26,7 @@ mainNav as $menuKey => $menu):?> - +
diff --git a/module/stakeholder/model.php b/module/stakeholder/model.php index 18b6e47045..f400c73c09 100644 --- a/module/stakeholder/model.php +++ b/module/stakeholder/model.php @@ -328,7 +328,7 @@ class stakeholderModel extends model } } - if(empty($parents)) return false; + if(empty($parents)) return array(); /* Get all parent stakeholders.*/ $parentStakeholders = $this->dao->select('objectID, user')->from(TABLE_STAKEHOLDER)->where('objectID')->in(array_keys($parents))->andWhere('deleted')->eq('0')->fetchAll(); From 70f8e0d3206699cc1a1b2b5828fc9b799c4d75ce Mon Sep 17 00:00:00 2001 From: tianshujie Date: Fri, 19 Nov 2021 08:44:53 +0800 Subject: [PATCH 113/120] * Fix execution and project linked product prompt issues. --- module/execution/js/common.js | 4 +--- module/project/js/common.js | 2 +- module/project/js/create.js | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/module/execution/js/common.js b/module/execution/js/common.js index 92953627e7..5a71f3f02c 100644 --- a/module/execution/js/common.js +++ b/module/execution/js/common.js @@ -124,7 +124,7 @@ function computeEndDate(delta) */ function loadBranches(product) { - $('#productsBox select').each(function() + $("#productsBox select[name^='products']").each(function() { var $product = $(product); if($product.val() != 0 && $product.val() == $(this).val() && $product.attr('id') != $(this).attr('id') && !multiBranchProducts[$product.val()]) @@ -216,8 +216,6 @@ function adjustPlanBoxMargin() } } -function loadBranch(){} - /* Auto compute the work days. */ $(function() { diff --git a/module/project/js/common.js b/module/project/js/common.js index dd1fd8dbc0..f6c87db6f1 100644 --- a/module/project/js/common.js +++ b/module/project/js/common.js @@ -139,7 +139,7 @@ function loadBranches(product) /* When selecting a product, delete a plan that is empty by default. */ $("#planDefault").remove(); - $('#productsBox select').each(function() + $("#productsBox select[name^='products']").each(function() { var $product = $(product); if($product.val() != 0 && $product.val() == $(this).val() && $product.attr('id') != $(this).attr('id') && !multiBranchProducts[$product.val()]) diff --git a/module/project/js/create.js b/module/project/js/create.js index 84088976fc..5936af5f44 100644 --- a/module/project/js/create.js +++ b/module/project/js/create.js @@ -138,7 +138,7 @@ function setAclList(programID) */ function loadBranches(product) { - $('#productsBox select').each(function() + $("#productsBox select[name^='products']").each(function() { var $product = $(product); if($product.val() != 0 && $product.val() == $(this).val() && $product.attr('id') != $(this).attr('id') && !multiBranchProducts[$product.val()]) From 8112a6e9858ce9054024aea298975b7bfcab87a0 Mon Sep 17 00:00:00 2001 From: xieqiyu Date: Fri, 19 Nov 2021 08:45:26 +0800 Subject: [PATCH 114/120] * Fix bug: add loadLang. --- module/build/model.php | 1 + 1 file changed, 1 insertion(+) diff --git a/module/build/model.php b/module/build/model.php index f0e246c0fe..dd5918cdd6 100644 --- a/module/build/model.php +++ b/module/build/model.php @@ -286,6 +286,7 @@ class buildModel extends model /* Set builds and filter done executions and terminate releases. */ $builds = array(); + $this->app->loadLang('branch'); foreach($productBuilds as $key => $build) { if(empty($build->releaseID) and (strpos($params, 'nodone') !== false) and ($build->executionStatus === 'done')) continue; From 5e49c845e6ee0eb63ac0348ab1a50a96830a628a Mon Sep 17 00:00:00 2001 From: songchenxuan Date: Fri, 19 Nov 2021 09:02:21 +0800 Subject: [PATCH 115/120] * Fix bug 16417 --- module/testcase/control.php | 4 +++- module/testcase/view/create.html.php | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/module/testcase/control.php b/module/testcase/control.php index e340fa8cce..034e347061 100644 --- a/module/testcase/control.php +++ b/module/testcase/control.php @@ -455,6 +455,7 @@ class testcase extends control $stories = $this->story->getExecutionStoryPairs($projectID, $productID, $branch, $modules); } if($storyID and !isset($stories[$storyID])) $stories = $this->story->formatStories(array($storyID => $story)) + $stories;//Fix bug #2406. + $productInfo = $this->loadModel('product')->getById($productID); /* Set custom. */ foreach(explode(',', $this->config->testcase->customCreateFields) as $field) $customFields[$field] = $this->lang->testcase->$field; @@ -465,6 +466,7 @@ class testcase extends control $this->view->position = $position; $this->view->projectID = isset($projectID) ? $projectID : 0; $this->view->productID = $productID; + $this->view->productInfo = $productInfo; $this->view->productName = $this->products[$productID]; $this->view->moduleOptionMenu = $this->tree->getOptionMenu($productID, $viewType = 'case', $startModuleID = 0, $branch === 'all' ? 0 : $branch); $this->view->currentModuleID = $currentModuleID; @@ -481,7 +483,7 @@ class testcase extends control $this->view->steps = $steps; $this->view->users = $this->user->getPairs('noletter|noclosed|nodeleted'); $this->view->branch = $branch; - $this->view->branches = $this->session->currentProductType != 'normal' ? $this->loadModel('branch')->getPairs($productID) : array(); + $this->view->branches = $productInfo->type != 'normal' ? $this->loadModel('branch')->getPairs($productID) : array(); $this->display(); } diff --git a/module/testcase/view/create.html.php b/module/testcase/view/create.html.php index 1e1a6c5df2..75ec50b0e7 100644 --- a/module/testcase/view/create.html.php +++ b/module/testcase/view/create.html.php @@ -40,7 +40,7 @@
- session->currentProductType != 'normal') echo html::select('branch', $branches, $branch, "onchange='loadBranch();' class='form-control' style='width:120px'");?> + type != 'normal') echo html::select('branch', $branches, $branch, "onchange='loadBranch();' class='form-control' style='width:120px'");?>
From 1e6f05b4c8d814e90f112393527b96d68686a1d7 Mon Sep 17 00:00:00 2001 From: mayue Date: Fri, 19 Nov 2021 09:25:33 +0800 Subject: [PATCH 116/120] * Fix bug #16454. --- module/productplan/control.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/module/productplan/control.php b/module/productplan/control.php index aa837d46df..008a027c55 100644 --- a/module/productplan/control.php +++ b/module/productplan/control.php @@ -63,6 +63,7 @@ class productplan extends control $this->commonAction($productID, $branchID); $lastPlan = $this->productplan->getLast($productID, $branchID, $parent); + $product = $this->loadModel('product')->getById($productID); if($lastPlan) { @@ -83,6 +84,7 @@ class productplan extends control $this->view->productID = $productID; $this->view->lastPlan = $lastPlan; $this->view->branch = $branchID; + $this->view->branches = $product->type == 'normal' ? array() : $this->loadModel('branch')->getPairs($productID, 'active'); $this->view->parent = $parent; $this->display(); } From 90e6d5d31556c61205ccc6a3d0681791deb9a882 Mon Sep 17 00:00:00 2001 From: mayue Date: Fri, 19 Nov 2021 09:37:32 +0800 Subject: [PATCH 117/120] * Fix bug #16455. --- module/story/control.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/story/control.php b/module/story/control.php index b50212f9c3..84ced15b3a 100644 --- a/module/story/control.php +++ b/module/story/control.php @@ -522,7 +522,7 @@ class story extends control $this->view->spec = $spec; $this->view->type = $type; $this->view->branch = $branch; - $this->view->branches = $this->loadModel('branch')->getPairs($productID); + $this->view->branches = $this->loadModel('branch')->getPairs($productID, 'active'); /* When the user is product owner or add story in project or not set review, the default is not to review. */ $this->view->needReview = ($this->app->user->account == $product->PO || $executionID > 0 || $this->config->story->needReview == 0) ? 0 : 1; From b959253bdf177d5dd876645c2fa52ae9ea13990e Mon Sep 17 00:00:00 2001 From: zhengrunyu Date: Fri, 19 Nov 2021 09:48:57 +0800 Subject: [PATCH 118/120] *Finish task #16368. --- module/build/control.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/module/build/control.php b/module/build/control.php index aa1dc47bef..918fcf2d6e 100644 --- a/module/build/control.php +++ b/module/build/control.php @@ -62,6 +62,12 @@ class build extends control $execution = $this->execution->getByID($executionID); $executions = $this->execution->getPairs($execution->project); } + + $executionList = $this->execution->getByIdList(array_keys($executions)); + foreach($executionList as $execution) + { + if($execution->lifetime == 'ops') unset($executions[$execution->id]); + } $productGroups = $this->loadModel('product')->getProducts($executionID); $productID = $productID ? $productID : key($productGroups); From 926e2e853df876fa1977dcaee53373025b7f9eda Mon Sep 17 00:00:00 2001 From: mayue Date: Fri, 19 Nov 2021 09:59:01 +0800 Subject: [PATCH 119/120] * Fix bug #16407. --- module/testcase/control.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/testcase/control.php b/module/testcase/control.php index ade2819dd4..e5ad39947d 100644 --- a/module/testcase/control.php +++ b/module/testcase/control.php @@ -481,7 +481,7 @@ class testcase extends control $this->view->steps = $steps; $this->view->users = $this->user->getPairs('noletter|noclosed|nodeleted'); $this->view->branch = $branch; - $this->view->branches = $this->session->currentProductType != 'normal' ? $this->loadModel('branch')->getPairs($productID) : array(); + $this->view->branches = $this->session->currentProductType != 'normal' ? $this->loadModel('branch')->getPairs($productID, 'active') : array(); $this->display(); } From 269633eb6dadf43875789d95a75c073e0a7d030f Mon Sep 17 00:00:00 2001 From: songchenxuan Date: Fri, 19 Nov 2021 10:23:44 +0800 Subject: [PATCH 120/120] * Fix bug 16417. --- module/testcase/control.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/testcase/control.php b/module/testcase/control.php index 034e347061..bcd14fc0a5 100644 --- a/module/testcase/control.php +++ b/module/testcase/control.php @@ -483,7 +483,7 @@ class testcase extends control $this->view->steps = $steps; $this->view->users = $this->user->getPairs('noletter|noclosed|nodeleted'); $this->view->branch = $branch; - $this->view->branches = $productInfo->type != 'normal' ? $this->loadModel('branch')->getPairs($productID) : array(); + $this->view->branches = $productInfo->type != 'normal' ? $this->loadModel('branch')->getPairs($productID, 'active') : array(); $this->display(); }