From acdeb1d7ecc3e91a8ef2e220d7b4de8eecff0a03 Mon Sep 17 00:00:00 2001
From: zhouxin <zhouxin@easycorp.ltd>
Date: Tue, 30 May 2023 16:39:05 +0800
Subject: [PATCH] * Remove unused param in common module.

---
 module/common/model.php | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/module/common/model.php b/module/common/model.php
index 8766ec5c87..c33ca376e2 100644
--- a/module/common/model.php
+++ b/module/common/model.php
@@ -770,9 +770,8 @@ class commonModel extends model
      * @access public
      * @return string
      */
-    public static function createMenuLink($menuItem, $group)
+    public static function createMenuLink($menuItem)
     {
-        global $app;
         $link = $menuItem->link;
         if(is_array($menuItem->link))
         {
@@ -1021,7 +1020,7 @@ class commonModel extends model
             if(common::hasPriv($currentModule, $currentMethod)) $display = true;
 
             /* 2. If the module is assetLib, need judge more methods. */
-            if($currentModule == 'assetlib' and $display == false)
+            if($currentModule == 'assetlib' && !$display)
             {
                 $methodList = array('caselib', 'issuelib', 'risklib', 'opportunitylib', 'practicelib', 'componentlib');
                 foreach($methodList as $method)
@@ -1199,7 +1198,7 @@ class commonModel extends model
                     $target = '';
                     $module = '';
                     $method = '';
-                    $link   = commonModel::createMenuLink($menuItem, $tab);
+                    $link   = commonModel::createMenuLink($menuItem);
 
                     if($menuItem->link['module'] == 'project' and $menuItem->link['method'] == 'other') $link = 'javascript:void(0);';
 
@@ -1377,7 +1376,7 @@ class commonModel extends model
                 $target = '';
                 $module = '';
                 $method = '';
-                $link   = commonModel::createMenuLink($menuItem, $tab);
+                $link   = commonModel::createMenuLink($menuItem);
                 if(is_array($menuItem->link))
                 {
                     if(isset($menuItem->link['target'])) $target = $menuItem->link['target'];
@@ -1861,7 +1860,6 @@ EOF;
         if(defined('TUTORIAL')) return;
         global $app, $config, $lang;
 
-        $pipelinePairs = array();
         $condition     = '';
         if(!$app->user->admin)
         {