From a7533f722defad02952c5b86b0a95b7a533d9ac6 Mon Sep 17 00:00:00 2001
From: holan20180123 <56391770@qq.com>
Date: Thu, 12 Nov 2020 10:09:16 +0800
Subject: [PATCH] * Finish task #8194.

---
 module/bug/model.php                    |  6 ++---
 module/bug/view/view.html.php           |  2 +-
 module/build/control.php                |  2 +-
 module/common/model.php                 | 10 ++++----
 module/doc/view/browse.html.php         |  4 +--
 module/doc/view/objectlibs.html.php     |  2 +-
 module/my/view/bug.html.php             |  6 ++---
 module/my/view/story.html.php           | 12 ++++-----
 module/my/view/task.html.php            |  6 ++---
 module/my/view/testcase.html.php        | 10 ++++----
 module/productplan/control.php          |  2 +-
 module/productplan/view/browse.html.php |  4 +--
 module/project/view/bug.html.php        |  6 ++---
 module/project/view/build.html.php      |  2 +-
 module/project/view/story.html.php      |  6 ++---
 module/project/view/testtask.html.php   |  6 ++---
 module/release/view/browse.html.php     |  4 +--
 module/release/view/view.html.php       | 34 ++++++++++++-------------
 module/story/model.php                  |  6 ++---
 module/story/view/view.html.php         |  2 +-
 module/task/view/view.html.php          |  2 +-
 module/testcase/model.php               |  6 ++---
 module/testreport/view/browse.html.php  |  2 +-
 module/testreport/view/view.html.php    |  2 +-
 module/testsuite/control.php            |  2 +-
 module/testtask/control.php             |  4 +--
 module/testtask/view/view.html.php      |  2 +-
 27 files changed, 76 insertions(+), 76 deletions(-)

diff --git a/module/bug/model.php b/module/bug/model.php
index 57fee78580..591ae77458 100644
--- a/module/bug/model.php
+++ b/module/bug/model.php
@@ -2501,7 +2501,7 @@ class bugModel extends model
     public function printCell($col, $bug, $users, $builds, $branches, $modulePairs, $projects = array(), $plans = array(), $stories = array(), $tasks = array(), $mode = 'datatable')
     {
         /* Check the product is closed. */
-        $isClosedProject = common::checkParentObjectClosed('bug', $bug);
+        $changeAllowed = common::checkObjectChangeAllowed('bug', $bug);
 
         $canBatchEdit         = common::hasPriv('bug', 'batchEdit');
         $canBatchConfirm      = common::hasPriv('bug', 'batchConfirm');
@@ -2572,7 +2572,7 @@ class bugModel extends model
             case 'id':
                 if($canBatchAction)
                 {
-                    $disabled = $isClosedProject ? 'disabled' : '';
+                    $disabled = $changeAllowed ? '' : 'disabled';
                     echo html::checkbox('bugIDList', array($bug->id => ''), '', $disabled) . html::a(helper::createLink('bug', 'view', "bugID=$bug->id"), sprintf('%03d', $bug->id));
                 }
                 else
@@ -2724,7 +2724,7 @@ class bugModel extends model
                 echo substr($bug->lastEditedDate, 5, 11);
                 break;
             case 'actions':
-                if(!$isClosedProject)
+                if($changeAllowed)
                 {
                     $params = "bugID=$bug->id";
                     common::printIcon('bug', 'confirmBug', $params, $bug, 'list', 'confirm', '', 'iframe', true);
diff --git a/module/bug/view/view.html.php b/module/bug/view/view.html.php
index 3cee72fc05..a79713b707 100644
--- a/module/bug/view/view.html.php
+++ b/module/bug/view/view.html.php
@@ -58,7 +58,7 @@
         </div>
       </div>
       <?php echo $this->fetch('file', 'printFiles', array('files' => $bug->files, 'fieldset' => 'true', 'object' => $bug));?>
-      <?php if(!common::checkParentObjectClosed('bug', $bug)) $actionFormLink = $this->createLink('action', 'comment', "objectType=bug&objectID=$bug->id");?>
+      <?php if(common::checkObjectChangeAllowed('bug', $bug)) $actionFormLink = $this->createLink('action', 'comment', "objectType=bug&objectID=$bug->id");?>
     </div>
     <?php $this->printExtendFields($bug, 'div', "position=left&inForm=0&inCell=1");?>
     <div class='cell'><?php include '../../common/view/action.html.php';?></div>
diff --git a/module/build/control.php b/module/build/control.php
index 36f4ea9d61..ee60eb135f 100644
--- a/module/build/control.php
+++ b/module/build/control.php
@@ -213,7 +213,7 @@ class build extends control
         if(!$build) die(js::error($this->lang->notFound) . js::locate('back'));
 
         /* Determines whether an object is editable. */
-        $changeAllowed = !common::checkParentObjectClosed('build', $build);
+        $changeAllowed = common::checkObjectChangeAllowed('build', $build);
 
         $product = $this->loadModel('product')->getById($build->product);
         if($product->type != 'normal') $this->lang->product->branch = sprintf($this->lang->product->branch, $this->lang->product->branchName[$product->type]);
diff --git a/module/common/model.php b/module/common/model.php
index 1c3f7efca3..afc4e7fee6 100644
--- a/module/common/model.php
+++ b/module/common/model.php
@@ -1490,7 +1490,7 @@ EOD;
         global $app, $lang;
 
         /* Check the parent object is closed. */
-        if(commonModel::checkParentObjectClosed($module, $object)) return false;
+        if(commonModel::checkObjectChangeAllowed($module, $object)) return true;
 
         /* Check is the super admin or not. */
         if(!empty($app->user->admin) || strpos($app->company->admins, ",{$app->user->account},") !== false) return true;
@@ -1850,7 +1850,7 @@ EOD;
      * @access public
      * @return bool
      */
-    public static function checkParentObjectClosed($module, $object = null)
+    public static function checkObjectChangeAllowed($module, $object = null)
     {
         global $app, $config;
 
@@ -1859,7 +1859,7 @@ EOD;
         {
             $productID = trim($object->product, ',');
             $product   = $app->control->loadModel('product')->getByID($productID);
-            if($product->status == 'closed') return true;
+            if($product->status == 'closed') return false;
 
             /* Get the projects associated with the story. */
             if($module == 'story' and empty($object->project))
@@ -1879,11 +1879,11 @@ EOD;
             $projects      = $app->control->loadModel('project')->getByIDList($projectIDList);
             foreach($projects as $project)
             {
-                if($project->status == 'closed') return true;
+                if($project->status == 'closed') return false;
             }
         }
 
-        return false;
+        return true;
     }
 
     /**
diff --git a/module/doc/view/browse.html.php b/module/doc/view/browse.html.php
index 599d5c4418..67417d0e2e 100644
--- a/module/doc/view/browse.html.php
+++ b/module/doc/view/browse.html.php
@@ -42,7 +42,7 @@ var browseType = '<?php echo $browseType;?>';
             <?php echo html::a('javascript:setBrowseType("bygrid")', "<i class='icon icon-cards-view'></i>", '', "title='{$lang->doc->browseTypeList['grid']}' class='btn btn-icon'");?>
             <?php echo html::a('javascript:setBrowseType("bylist")', "<i class='icon icon-bars'></i>", '', "title='{$lang->doc->browseTypeList['list']}' class='btn btn-icon text-primary'");?>
           </div>
-          <?php if($libID and !common::checkParentObjectClosed('doc', $currentLib)):?>
+          <?php if($libID and common::checkObjectChangeAllowed('doc', $currentLib)):?>
           <div class="dropdown">
             <button class="btn" type="button" data-toggle="dropdown"><i class='icon-cog'></i> <span class="caret"></span></button>
             <ul class='dropdown-menu'>
@@ -164,7 +164,7 @@ var browseType = '<?php echo $browseType;?>';
               <td class="c-datetime"><?php echo formatTime($doc->addedDate, 'y-m-d');?></td>
               <td class="c-datetime"><?php echo formatTime($doc->editedDate, 'y-m-d');?></td>
               <td class="c-actions">
-                <?php if(!common::checkParentObjectClosed('doc', $doc)):?>
+                <?php if(common::checkObjectChangeAllowed('doc', $doc)):?>
                 <?php if(common::hasPriv('doc', 'collect')):?>
                 <a data-url="<?php echo $this->createLink('doc', 'collect', "objectID=$doc->id&objectType=doc");?>" title="<?php echo $collectTitle;?>" class='btn btn-link ajaxCollect'><i class='icon <?php echo $star;?>'></i></a>
                 <?php endif;?>
diff --git a/module/doc/view/objectlibs.html.php b/module/doc/view/objectlibs.html.php
index 1f6905fb4f..8eb9f68835 100644
--- a/module/doc/view/objectlibs.html.php
+++ b/module/doc/view/objectlibs.html.php
@@ -57,7 +57,7 @@
             <?php $star = strpos($lib->collector, ',' . $this->app->user->account . ',') !== false ? 'icon-star text-yellow' : 'icon-star-empty';?>
             <?php $collectTitle = strpos($lib->collector, ',' . $this->app->user->account . ',') !== false ? $lang->doc->cancelCollection : $lang->doc->collect;?>
             <div class="actions">
-              <?php if(common::checkParentObjectClosed('doc', $object)):?>
+              <?php if(common::checkObjectChangeAllowed('doc', $object)):?>
               <?php if(common::hasPriv('doc', 'collect')):?>
               <a data-url="<?php echo $this->createLink('doc', 'collect', "objectID=$libID&objectType=doclib");?>" title="<?php echo $collectTitle;?>" class='btn btn-link ajaxCollect'><i class='icon <?php echo $star;?>'></i></a>
               <?php endif;?>
diff --git a/module/my/view/bug.html.php b/module/my/view/bug.html.php
index f6943b3b9a..cef75a175d 100644
--- a/module/my/view/bug.html.php
+++ b/module/my/view/bug.html.php
@@ -73,12 +73,12 @@
       ?>
       <tbody>
         <?php foreach($bugs as $bug):?>
-        <?php $isClosedProject = common::checkParentObjectClosed('bug', $bug);?>
+        <?php $changeAllowed = common::checkObjectChangeAllowed('bug', $bug);?>
         <tr>
           <td class="c-id">
             <?php if($canBatchAction):?>
             <div class="checkbox-primary">
-              <input type='checkbox' name='bugIDList[]' value='<?php echo $bug->id;?>' <?php if($isClosedProject) echo 'disabled';?> />
+              <input type='checkbox' name='bugIDList[]' value='<?php echo $bug->id;?>' <?php if(!$changeAllowed) echo 'disabled';?> />
               <label></label>
             </div>
             <?php endif;?>
@@ -100,7 +100,7 @@
           <td><?php echo zget($lang->bug->resolutionList, $bug->resolution);?></td>
           <td class='c-actions'>
             <?php
-            if(!$isClosedProject)
+            if($changeAllowed)
             {
                 $params = "bugID=$bug->id";
                 common::printIcon('bug', 'confirmBug', $params, $bug, 'list', 'confirm', '', 'iframe', true);
diff --git a/module/my/view/story.html.php b/module/my/view/story.html.php
index 37430d9aa8..4022afafec 100644
--- a/module/my/view/story.html.php
+++ b/module/my/view/story.html.php
@@ -63,14 +63,14 @@
       <tbody>
         <?php foreach($stories as $story):?>
         <?php
-        $storyLink = $this->createLink('story', 'view', "id=$story->id");
-        $isClosedProject = common::checkParentObjectClosed('story', $story);
+        $storyLink     = $this->createLink('story', 'view', "id=$story->id");
+        $changeAllowed = common::checkObjectChangeAllowed('story', $story);
         ?>
         <tr>
           <td class="c-id">
             <?php if($canBatchAction):?>
             <div class="checkbox-primary">
-              <input type='checkbox' name='storyIdList[<?php echo $story->id;?>]' value='<?php echo $story->id;?>' <?php if($isClosedProject) echo 'disabled';?>/>
+              <input type='checkbox' name='storyIdList[<?php echo $story->id;?>]' value='<?php echo $story->id;?>' <?php if(!$changeAllowed) echo 'disabled';?>/>
               <label></label>
             </div>
             <?php endif;?>
@@ -86,7 +86,7 @@
           <td class='c-stage'><?php echo zget($lang->story->stageList, $story->stage);?></td>
           <td class='c-actions'>
             <?php
-            if(!$isClosedProject)
+            if($changeAllowed)
             {
                 $vars = "story={$story->id}";
                 common::printIcon('story', 'change',     $vars, $story, 'list', 'fork');
@@ -105,7 +105,7 @@
           <td class="c-id">
             <?php if($canBatchAction):?>
             <div class="checkbox-primary">
-              <input type='checkbox' name='storyIdList[<?php echo $child->id;?>]' value='<?php echo $child->id;?>' <?php if($isClosedProject) echo 'disabled';?>/>
+              <input type='checkbox' name='storyIdList[<?php echo $child->id;?>]' value='<?php echo $child->id;?>' <?php if(!$changeAllowed) echo 'disabled';?>/>
               <label></label>
             </div>
             <?php endif;?>
@@ -121,7 +121,7 @@
           <td class='c-stage'><?php echo zget($lang->story->stageList, $child->stage);?></td>
           <td class='c-actions'>
             <?php
-            if(!$isClosedProject)
+            if($changeAllowed)
             {
                 $vars = "story={$child->id}";
                 common::printIcon('story', 'change',     $vars, $child, 'list', 'fork');
diff --git a/module/my/view/task.html.php b/module/my/view/task.html.php
index 7bb8ce2cfc..a48eca713f 100644
--- a/module/my/view/task.html.php
+++ b/module/my/view/task.html.php
@@ -61,12 +61,12 @@
       </thead>
       <tbody>
         <?php foreach($tasks as $task):?>
-        <?php $isClosedProject = common::checkParentObjectClosed('task', $task);?>
+        <?php $changeAllowed = common::checkObjectChangeAllowed('task', $task);?>
         <tr>
           <td class="c-id">
             <?php if($canBatchEdit or $canBatchClose):?>
             <div class="checkbox-primary">
-              <input type='checkbox' name='taskIDList[]' value='<?php echo $task->id;?>' <?php if($isClosedProject) echo 'disabled';?>/>
+              <input type='checkbox' name='taskIDList[]' value='<?php echo $task->id;?>' <?php if(!$changeAllowed) echo 'disabled';?>/>
               <label></label>
             </div>
             <?php endif;?>
@@ -93,7 +93,7 @@
           </td>
           <td class='c-actions'>
             <?php
-            if(!$isClosedProject)
+            if($changeAllowed)
             {
                 if($task->needConfirm)
                 {
diff --git a/module/my/view/testcase.html.php b/module/my/view/testcase.html.php
index 06b41e941a..9fdf9645fc 100644
--- a/module/my/view/testcase.html.php
+++ b/module/my/view/testcase.html.php
@@ -67,15 +67,15 @@
       <tbody>
         <?php foreach($cases as $case):?>
         <?php
-        $caseID          = $type == 'assigntome' ? $case->case : $case->id;
-        $runID           = $type == 'assigntome' ? $case->id   : 0;
-        $isClosedProject = common::checkParentObjectClosed('testcase', $case);
+        $caseID        = $type == 'assigntome' ? $case->case : $case->id;
+        $runID         = $type == 'assigntome' ? $case->id   : 0;
+        $changeAllowed = common::checkObjectChangeAllowed('testcase', $case);
         ?>
         <tr>
           <td class="c-id">
             <?php if($canBatchEdit or $canBatchRun):?>
             <div class="checkbox-primary">
-              <input type='checkbox' name='caseIDList[]' value='<?php echo $case->id;?>' <?php if($isClosedProject) echo 'disabled';?>/>
+              <input type='checkbox' name='caseIDList[]' value='<?php echo $case->id;?>' <?php if(!$changeAllowed) echo 'disabled';?>/>
               <label></label>
             </div>
             <?php endif;?>
@@ -93,7 +93,7 @@
           <td class='<?php if(isset($run)) echo $run->status;?>'><?php echo $this->processStatus('testcase', $case);?></td>
           <td class='c-actions'>
             <?php
-            if(!$isClosedProject)
+            if($changeAllowed)
             {
                 common::printIcon('testcase', 'createBug', "product=$case->product&branch=$case->branch&extra=caseID=$caseID,version=$case->version,runID=$runID", $case, 'list', 'bug');
                 common::printIcon('testcase', 'create',  "productID=$case->product&branch=$case->branch&moduleID=$case->module&from=testcase&param=$caseID", $case, 'list', 'copy');
diff --git a/module/productplan/control.php b/module/productplan/control.php
index ab10ccc71f..948efa87dd 100644
--- a/module/productplan/control.php
+++ b/module/productplan/control.php
@@ -250,7 +250,7 @@ class productplan extends control
         $this->session->set('bugList', $this->app->getURI(true) . '&type=' . 'bug');
 
         /* Determines whether an object is editable. */
-        $changeAllowed = !common::checkParentObjectClosed('plan', $plan);
+        $changeAllowed = common::checkObjectChangeAllowed('plan', $plan);
 
         /* Load pager. */
         $this->app->loadClass('pager', $static = true);
diff --git a/module/productplan/view/browse.html.php b/module/productplan/view/browse.html.php
index 5e17ac3634..75fa9a882e 100644
--- a/module/productplan/view/browse.html.php
+++ b/module/productplan/view/browse.html.php
@@ -75,8 +75,8 @@
       <?php $this->loadModel('file');?>
       <?php foreach($plans as $plan):?>
       <?php
-      $isClosedProject = common::checkParentObjectClosed('plan', $plan);
-      $disabled        = $isClosedProject ? 'disabled' : '';
+      $changeAllowed = common::checkObjectChangeAllowed('plan', $plan);
+      $disabled      = $changeAllowed ? '' : 'disabled';
 
       $plan = $this->file->replaceImgURL($plan, 'desc');
       if($plan->parent == '-1')
diff --git a/module/project/view/bug.html.php b/module/project/view/bug.html.php
index e5005c6be9..0826aa0d29 100644
--- a/module/project/view/bug.html.php
+++ b/module/project/view/bug.html.php
@@ -75,8 +75,8 @@
       <tbody>
       <?php foreach($bugs as $bug):?>
       <?php
-      $isClosedProject = common::checkParentObjectClosed('bug', $bug);
-      $disabled        = $isClosedProject ? 'disabled' : '';
+      $changeAllowed = common::checkObjectChangeAllowed('bug', $bug);
+      $disabled      = $changeAllowed ? '' : 'disabled';
       ?>
       <tr>
         <td class='cell-id'>
@@ -101,7 +101,7 @@
         <td><?php echo zget($lang->bug->resolutionList, $bug->resolution);?></td>
         <td class='c-actions'>
           <?php
-          if(!$isClosedProject)
+          if($changeAllowed)
           {
               $params = "bugID=$bug->id";
               common::printIcon('bug', 'confirmBug', $params, $bug, 'list', 'confirm', '', 'iframe', true);
diff --git a/module/project/view/build.html.php b/module/project/view/build.html.php
index ead308f52a..856edb982c 100644
--- a/module/project/view/build.html.php
+++ b/module/project/view/build.html.php
@@ -74,7 +74,7 @@
           <td class="c-user em"><?php echo zget($users, $build->builder);?></td>
           <td class="c-actions">
             <?php
-            if(common::hasPriv('build', 'linkstory') and common::hasPriv('build', 'view') and !common::checkParentObjectClosed('build', $build))
+            if(common::hasPriv('build', 'linkstory') and common::hasPriv('build', 'view') and common::checkObjectChangeAllowed('build', $build))
             {
                 echo html::a($this->createLink('build', 'view', "buildID=$build->id&type=story&link=true"), "<i class='icon icon-link'></i>", '', "class='btn' title='{$lang->build->linkStory}'");
             }
diff --git a/module/project/view/story.html.php b/module/project/view/story.html.php
index 5bbb5ac21c..f6921b0bf2 100644
--- a/module/project/view/story.html.php
+++ b/module/project/view/story.html.php
@@ -148,8 +148,8 @@
         <tbody id='storyTableList' class='sortable'>
           <?php foreach($stories as $key => $story):?>
           <?php
-          $isClosedProject = common::checkParentObjectClosed('story', $story);
-          $disabled        = $isClosedProject ? 'disabled' : '';
+          $changeAllowed = common::checkObjectChangeAllowed('story', $story);
+          $disabled      = $changeAllowed ? '' : 'disabled';
 
           $storyLink       = $this->createLink('story', 'view', "storyID=$story->id&version=$story->version&from=project&param=$project->id");
           $totalEstimate  += $story->estimate;
@@ -198,7 +198,7 @@
             </td>
             <td class='c-actions'>
               <?php
-              if(!$isClosedProject)
+              if($changeAllowed)
               {
                   $hasDBPriv = common::hasDBPriv($project, 'project');
                   $param = "projectID={$project->id}&story={$story->id}&moduleID={$story->module}";
diff --git a/module/project/view/testtask.html.php b/module/project/view/testtask.html.php
index a468348743..15a068dc73 100644
--- a/module/project/view/testtask.html.php
+++ b/module/project/view/testtask.html.php
@@ -74,8 +74,8 @@
         <?php $productName = zget($products, $product, '');?>
         <?php foreach($productTasks as $task):?>
         <?php
-        $isClosedProject = common::checkParentObjectClosed('task', $task);
-        $disabled        = $isClosedProject ? 'disabled' : '';
+        $changeAllowed = common::checkObjectChangeAllowed('task', $task);
+        $disabled      = $changeAllowed ? '' : 'disabled';
         ?>
         <tr data-id='<?php echo $product;?>' <?php if($task == reset($productTasks)) echo "class='divider-top'";?>>
           <?php if($task == reset($productTasks)):?>
@@ -102,7 +102,7 @@
           </td>
           <td class='c-actions'>
             <?php
-            if(!$isClosedProject)
+            if($changeAllowed)
             {
                 common::printIcon('testtask',   'cases',    "taskID=$task->id", $task, 'list', 'sitemap');
                 common::printIcon('testtask',   'linkCase', "taskID=$task->id", $task, 'list', 'link');
diff --git a/module/release/view/browse.html.php b/module/release/view/browse.html.php
index 9348075d31..73f0de5dcb 100644
--- a/module/release/view/browse.html.php
+++ b/module/release/view/browse.html.php
@@ -58,7 +58,7 @@
     </thead>
     <tbody>
       <?php foreach($releases as $release):?>
-      <?php $isClosedProject = common::checkParentObjectClosed('release', $release);?>
+      <?php $changeAllowed = common::checkObjectChangeAllowed('release', $release);?>
       <tr>
         <td><?php echo html::a(helper::createLink('release', 'view', "releaseID=$release->id"), sprintf('%03d', $release->id));?></td>
         <td>
@@ -79,7 +79,7 @@
         <?php foreach($extendFields as $extendField) echo "<td>" . $this->loadModel('flow')->getFieldValue($extendField, $release) . "</td>";?>
         <td class='c-actions'>
           <?php
-          if(!$isClosedProject)
+          if($changeAllowed)
           {
               if(common::hasPriv('release', 'linkStory')) echo html::a(inlink('view', "releaseID=$release->id&type=story&link=true"), '<i class="icon-link"></i> ', '', "class='btn' title='{$lang->release->linkStory}'");
               if(common::hasPriv('release', 'linkBug') and $config->global->flow != 'onlyStory') echo html::a(inlink('view', "releaseID=$release->id&type=bug&link=true"), '<i class="icon-bug"></i> ', '', "class='btn' title='{$lang->release->linkBug}'");
diff --git a/module/release/view/view.html.php b/module/release/view/view.html.php
index eb37f65004..bfd784c9a2 100644
--- a/module/release/view/view.html.php
+++ b/module/release/view/view.html.php
@@ -31,9 +31,9 @@
   </div>
   <div class='btn-toolbar pull-right'>
     <?php
-    $isClosedProduct = common::checkParentObjectClosed('release', $release);
+    $changeAllowed = common::checkObjectChangeAllowed('release', $release);
 
-    if(!$release->deleted and !$isClosedProduct)
+    if(!$release->deleted and $changeAllowed)
     {
         echo $this->buildOperateMenu($release, 'view');
 
@@ -66,7 +66,7 @@
         </ul>
         <div class='tab-content'>
           <div class='tab-pane <?php if($type == 'story') echo 'active'?>' id='stories'>
-            <?php if(common::hasPriv('release', 'linkStory') and !$isClosedProduct):?>
+            <?php if(common::hasPriv('release', 'linkStory') and $changeAllowed):?>
             <div class='actions'><?php echo html::a("javascript:showLink({$release->id}, \"story\")", '<i class="icon-link"></i> ' . $lang->release->linkStory, '', "class='btn btn-primary'");?></div>
             <div class='linkBox cell hidden'></div>
             <?php endif;?>
@@ -80,7 +80,7 @@
                 <thead>
                   <tr class='text-center'>
                     <th class='c-id text-left'>
-                      <?php if(($canBatchUnlink or $canBatchClose) and !$isClosedProduct):?>
+                      <?php if(($canBatchUnlink or $canBatchClose) and $changeAllowed):?>
                       <div class="checkbox-primary check-all" title="<?php echo $lang->selectAll?>">
                         <label></label>
                       </div>
@@ -101,7 +101,7 @@
                   <?php $storyLink = $this->createLink('story', 'view', "storyID=$story->id", '', true);?>
                   <tr>
                     <td class='c-id text-left'>
-                      <?php if(($canBatchUnlink or $canBatchClose) and !$isClosedProduct):?>
+                      <?php if(($canBatchUnlink or $canBatchClose) and $changeAllowed):?>
                       <div class="checkbox-primary">
                         <input type='checkbox' name='storyIdList[]'  value='<?php echo $story->id;?>'/>
                         <label></label>
@@ -124,7 +124,7 @@
                     <td><?php echo $lang->story->stageList[$story->stage];?></td>
                     <td class='c-actions'>
                       <?php
-                      if(common::hasPriv('release', 'unlinkStory') and !$isClosedProduct)
+                      if(common::hasPriv('release', 'unlinkStory') and $changeAllowed)
                       {
                           $unlinkURL = $this->createLink('release', 'unlinkStory', "releaseID=$release->id&story=$story->id");
                           echo html::a("javascript:ajaxDelete(\"$unlinkURL\", \"storyList\", confirmUnlinkStory)", '<i class="icon-unlink"></i>', '', "class='btn' title='{$lang->release->unlinkStory}'");
@@ -136,7 +136,7 @@
                 </tbody>
               </table>
               <div class='table-footer'>
-                <?php if($countStories and ($canBatchUnlink or $canBatchClose) and !$isClosedProduct):?>
+                <?php if($countStories and ($canBatchUnlink or $canBatchClose) and $changeAllowed):?>
                 <div class="checkbox-primary check-all"><label><?php echo $lang->selectAll?></label></div>
                 <div class="table-actions btn-toolbar">
                   <?php
@@ -164,7 +164,7 @@
             </form>
           </div>
           <div class='tab-pane <?php if($type == 'bug') echo 'active'?>' id='bugs'>
-            <?php if(common::hasPriv('release', 'linkBug') and !$isClosedProduct):?>
+            <?php if(common::hasPriv('release', 'linkBug') and $changeAllowed):?>
             <div class='actions'><?php echo html::a("javascript:showLink({$release->id}, \"bug\")", '<i class="icon-bug"></i> ' . $lang->release->linkBug, '', "class='btn btn-primary'");?></div>
             <div class='linkBox cell hidden'></div>
             <?php endif;?>
@@ -175,7 +175,7 @@
                 <thead>
                   <tr class='text-center'>
                     <th class='c-id text-left'>
-                      <?php if($canBatchUnlink and !$isClosedProduct):?>
+                      <?php if($canBatchUnlink and $changeAllowed):?>
                       <div class="checkbox-primary check-all" title="<?php echo $lang->selectAll?>">
                         <label></label>
                       </div>
@@ -196,7 +196,7 @@
                   <?php $bugLink = $this->createLink('bug', 'view', "bugID=$bug->id", '', true);?>
                   <tr>
                     <td class='c-id text-left'>
-                      <?php if($canBatchUnlink and !$isClosedProduct):?>
+                      <?php if($canBatchUnlink and $changeAllowed):?>
                       <div class="checkbox-primary">
                         <input type='checkbox' name='unlinkBugs[]'  value='<?php echo $bug->id;?>'/>
                         <label></label>
@@ -214,7 +214,7 @@
                     <td><?php echo substr($bug->resolvedDate, 5, 11)?></td>
                     <td class='c-actions'>
                       <?php
-                      if(common::hasPriv('release', 'unlinkBug') and !$isClosedProduct)
+                      if(common::hasPriv('release', 'unlinkBug') and $changeAllowed)
                       {
                           $unlinkURL = $this->createLink('release', 'unlinkBug', "releaseID=$release->id&bug=$bug->id");
                           echo html::a("javascript:ajaxDelete(\"$unlinkURL\", \"bugList\", confirmUnlinkBug)", '<i class="icon-unlink"></i>', '', "class='btn' title='{$lang->release->unlinkBug}'");
@@ -226,7 +226,7 @@
                 </tbody>
               </table>
               <div class='table-footer'>
-                <?php if($countBugs and $canBatchUnlink and !$isClosedProduct):?>
+                <?php if($countBugs and $canBatchUnlink and $changeAllowed):?>
                 <div class="checkbox-primary check-all"><label><?php echo $lang->selectAll?></label></div>
                 <div class="table-actions btn-toolbar">
                   <?php echo html::submitButton($lang->release->batchUnlink, '', 'btn');?>
@@ -242,7 +242,7 @@
             </form>
           </div>
           <div class='tab-pane <?php if($type == 'leftBug') echo 'active'?>' id='leftBugs'>
-            <?php if(common::hasPriv('release', 'linkBug') and !$isClosedProduct):?>
+            <?php if(common::hasPriv('release', 'linkBug') and $changeAllowed):?>
             <div class='actions'><?php echo html::a("javascript:showLink({$release->id}, \"leftBug\")", '<i class="icon-bug"></i> ' . $lang->release->linkBug, '', "class='btn btn-primary'");?></div>
             <div class='linkBox cell hidden'></div>
             <?php endif;?>
@@ -253,7 +253,7 @@
                 <thead>
                   <tr class='text-center'>
                     <th class='c-id text-left'>
-                      <?php if($canBatchUnlink and !$isClosedProduct):?>
+                      <?php if($canBatchUnlink and $changeAllowed):?>
                       <div class="checkbox-primary check-all" title="<?php echo $lang->selectAll?>">
                         <label></label>
                       </div>
@@ -284,7 +284,7 @@
                   <?php $bugLink = $this->createLink('bug', 'view', "bugID=$bug->id", '', true);?>
                   <tr>
                     <td class='c-id text-left'>
-                      <?php if($canBatchUnlink and !$isClosedProduct):?>
+                      <?php if($canBatchUnlink and $changeAllowed):?>
                       <div class="checkbox-primary">
                         <input type='checkbox' name='unlinkBugs[]'  value='<?php echo $bug->id;?>'/>
                         <label></label>
@@ -305,7 +305,7 @@
                     <td><?php echo $bug->openedDate?></td>
                     <td class='c-actions'>
                       <?php
-                      if(common::hasPriv('release', 'unlinkBug') and !$isClosedProduct)
+                      if(common::hasPriv('release', 'unlinkBug') and $changeAllowed)
                       {
                           $unlinkURL = $this->createLink('release', 'unlinkBug', "releaseID=$release->id&bug=$bug->id&type=leftBug");
                           echo html::a("javascript:ajaxDelete(\"$unlinkURL\", \"leftBugList\", confirmUnlinkBug)", '<i class="icon-unlink"></i>', '', "class='btn' title='{$lang->release->unlinkBug}'");
@@ -317,7 +317,7 @@
                 </tbody>
               </table>
               <div class='table-footer'>
-                <?php if($countLeftBugs and $canBatchUnlink and !$isClosedProduct):?>
+                <?php if($countLeftBugs and $canBatchUnlink and $changeAllowed):?>
                 <div class="checkbox-primary check-all"><label><?php echo $lang->selectAll?></label></div>
                 <div class="table-actions btn-toolbar">
                   <?php echo html::submitButton($lang->release->batchUnlink, '', 'btn');?>
diff --git a/module/story/model.php b/module/story/model.php
index a780ad6614..363689ed79 100644
--- a/module/story/model.php
+++ b/module/story/model.php
@@ -2971,7 +2971,7 @@ class storyModel extends model
     public function printCell($col, $story, $users, $branches, $storyStages, $modulePairs = array(), $storyTasks = array(), $storyBugs = array(), $storyCases = array(), $mode = 'datatable', $storyType = 'story')
     {
         /* Check the product is closed. */
-        $isClosedProject = common::checkParentObjectClosed('story', $story);
+        $changeAllowed = common::checkObjectChangeAllowed('story', $story);
 
         $canBatchEdit         = common::hasPriv('story', 'batchEdit');
         $canBatchClose        = common::hasPriv('story', 'batchClose');
@@ -3046,7 +3046,7 @@ class storyModel extends model
             case 'id':
                 if($canBatchAction)
                 {
-                    $disabled = $isClosedProject ? 'disabled' : '';
+                    $disabled = $changeAllowed ? '' : 'disabled';
                     echo html::checkbox('storyIdList', array($story->id => ''), '', $disabled) . html::a(helper::createLink('story', 'view', "storyID=$story->id"), sprintf('%03d', $story->id));
                 }
                 else
@@ -3168,7 +3168,7 @@ class storyModel extends model
                 echo $story->version;
                 break;
             case 'actions':
-                if(!$isClosedProject)
+                if($changeAllowed)
                 {
                     $vars = "story={$story->id}";
                     common::printIcon('story', 'change',     $vars, $story, 'list', 'fork');
diff --git a/module/story/view/view.html.php b/module/story/view/view.html.php
index bd0b9e50e6..53ec2d8aab 100644
--- a/module/story/view/view.html.php
+++ b/module/story/view/view.html.php
@@ -65,7 +65,7 @@
         <div class="detail-content article-content"><?php echo $story->verify;?></div>
       </div>
       <?php echo $this->fetch('file', 'printFiles', array('files' => $story->files, 'fieldset' => 'true', 'object' => $story));?>
-      <?php if(!common::checkParentObjectClosed('story', $story)) $actionFormLink = $this->createLink('action', 'comment', "objectType=story&objectID=$story->id");?>
+      <?php if(common::checkObjectChangeAllowed('story', $story)) $actionFormLink = $this->createLink('action', 'comment', "objectType=story&objectID=$story->id");?>
       <?php if(!empty($story->children)):?>
       <div class='detail'>
         <div class='detail-title'><?php echo $this->lang->story->children;?></div>
diff --git a/module/task/view/view.html.php b/module/task/view/view.html.php
index c0d669a5f0..330d9f153d 100644
--- a/module/task/view/view.html.php
+++ b/module/task/view/view.html.php
@@ -143,7 +143,7 @@
       </div>
       <?php endif;?>
       <?php echo $this->fetch('file', 'printFiles', array('files' => $task->files, 'fieldset' => 'true', 'object' => $task));?>
-      <?php if(!common::checkParentObjectClosed('task', $task)) $actionFormLink = $this->createLink('action', 'comment', "objectType=task&objectID=$task->id");?>
+      <?php if(common::checkObjectChangeAllowed('task', $task)) $actionFormLink = $this->createLink('action', 'comment', "objectType=task&objectID=$task->id");?>
     </div>
     <?php $this->printExtendFields($task, 'div', "position=left&inForm=0&inCell=1");?>
     <div class="cell"><?php include '../../common/view/action.html.php';?></div>
diff --git a/module/testcase/model.php b/module/testcase/model.php
index b3dd183f47..0f5b9f13d4 100644
--- a/module/testcase/model.php
+++ b/module/testcase/model.php
@@ -1409,7 +1409,7 @@ class testcaseModel extends model
     public function printCell($col, $case, $users, $branches, $modulePairs = array(), $browseType = '', $mode = 'datatable')
     {
         /* Check the product is closed. */
-        $isClosedProject = common::checkParentObjectClosed('case', $case);
+        $changeAllowed = common::checkObjectChangeAllowed('case', $case);
 
         $canBatchRun                = common::hasPriv('testtask', 'batchRun');
         $canBatchEdit               = common::hasPriv('testcase', 'batchEdit');
@@ -1450,7 +1450,7 @@ class testcaseModel extends model
             case 'id':
                 if($canBatchAction)
                 {
-                    $disabled = $isClosedProject ? 'disabled' : '';
+                    $disabled = $changeAllowed ? '' : 'disabled';
                     echo html::checkbox('caseIDList', array($case->id => ''), '', $disabled) . html::a(helper::createLink('testcase', 'view', "caseID=$case->id"), sprintf('%03d', $case->id));
                 }
                 else
@@ -1547,7 +1547,7 @@ class testcaseModel extends model
                 echo $case->stepNumber;
                 break;
             case 'actions':
-                if(!$isClosedProject)
+                if($changeAllowed)
                 {
                     if($case->needconfirm or $browseType == 'needconfirm')
                     {
diff --git a/module/testreport/view/browse.html.php b/module/testreport/view/browse.html.php
index c9de9e446f..4663e9c5b0 100644
--- a/module/testreport/view/browse.html.php
+++ b/module/testreport/view/browse.html.php
@@ -64,7 +64,7 @@
         <td class='text-left' title='<?php echo $taskName?>'><?php echo $taskName;?></td>
         <td class='c-actions'>
           <?php
-          if(!common::checkParentObjectClosed('report', $report))
+          if(common::checkObjectChangeAllowed('report', $report))
           {
               common::printIcon('testreport', 'edit', "id=$report->id", '', 'list');
               common::printIcon('testreport', 'delete', "id=$report->id", '', 'list', 'trash', 'hiddenwin');
diff --git a/module/testreport/view/view.html.php b/module/testreport/view/view.html.php
index 974d939084..4f4a1f83fa 100644
--- a/module/testreport/view/view.html.php
+++ b/module/testreport/view/view.html.php
@@ -112,7 +112,7 @@
     <?php if(!$report->deleted):?>
     <div class='divider'></div>
     <?php
-    if(!common::checkParentObjectClosed('report', $report))
+    if(common::checkObjectChangeAllowed('report', $report))
     {
         if(common::hasPriv('testreport', 'create')) echo html::a(inLink('create', "objectID=$report->objectID&objectType=$report->objectType"),  "<i class='icon-refresh'></i>", '', "class='btn' title='{$lang->testreport->recreate}'");
         common::printIcon('testreport', 'edit', "reportID=$report->id", '', 'button');
diff --git a/module/testsuite/control.php b/module/testsuite/control.php
index 1ebde41ce9..7d8a9f912a 100644
--- a/module/testsuite/control.php
+++ b/module/testsuite/control.php
@@ -161,7 +161,7 @@ class testsuite extends control
         $this->view->pager         = $pager;
         $this->view->modules       = $this->loadModel('tree')->getOptionMenu($suite->product, 'case');
         $this->view->branches      = $this->loadModel('branch')->getPairs($suite->product, 'noempty');
-        $this->view->changeAllowed = common::checkParentObjectClosed('testsuite', $suite) ? false : true;
+        $this->view->changeAllowed = common::checkObjectChangeAllowed('testsuite', $suite);
 
         $this->display();
     }
diff --git a/module/testtask/control.php b/module/testtask/control.php
index dff6832f7a..295addfa3f 100644
--- a/module/testtask/control.php
+++ b/module/testtask/control.php
@@ -402,7 +402,7 @@ class testtask extends control
         setcookie('preTaskID', $taskID, $this->config->cookieLife, $this->config->webRoot, '', false, true);
 
         /* Determines whether an object is editable. */
-        $changeAllowed = common::checkParentObjectClosed('testtask', $task) ? false : true;
+        $changeAllowed = common::checkObjectChangeAllowed('testtask', $task);
 
         if($this->cookie->preTaskID != $taskID)
         {
@@ -553,7 +553,7 @@ class testtask extends control
         $this->testtask->setMenu($this->products, $productID, $task->branch, $taskID);
 
         /* Determines whether an object is editable. */
-        $changeAllowed = common::checkParentObjectClosed('testtask', $task) ? false : true;
+        $changeAllowed = common::checkObjectChangeAllowed('testtask', $task);
 
         $runs = $this->testtask->getRuns($taskID, 0, $groupBy);
         $this->loadModel('common')->saveQueryCondition($this->dao->get(), 'testcase', false);
diff --git a/module/testtask/view/view.html.php b/module/testtask/view/view.html.php
index b2c3e3bfd3..5de9475449 100644
--- a/module/testtask/view/view.html.php
+++ b/module/testtask/view/view.html.php
@@ -39,7 +39,7 @@
         <div class="detail-content article-content"><?php echo $task->report;?></div>
       </div>
       <?php endif;?>
-      <?php if(!common::checkParentObjectClosed('testtask', $task)) $actionFormLink = $this->createLink('action', 'comment', "objectType=testtask&objectID=$task->id");?>
+      <?php if(common::checkObjectChangeAllowed('testtask', $task)) $actionFormLink = $this->createLink('action', 'comment', "objectType=testtask&objectID=$task->id");?>
     </div>
     <?php $this->printExtendFields($task, 'div', "position=left&inForm=0&inCell=1");?>
     <div class='cell'><?php include '../../common/view/action.html.php';?></div>