From 9d584c21f6e8c673bc9334fcc8db62633fd65847 Mon Sep 17 00:00:00 2001 From: "chencongzhi520@gmail.com" Date: Sat, 4 May 2013 00:37:33 +0000 Subject: [PATCH] * fix bug#411. --- module/story/model.php | 6 +++--- module/task/model.php | 4 ++-- module/testcase/model.php | 2 +- module/todo/model.php | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/module/story/model.php b/module/story/model.php index 075d3543d2..a2d92a9db4 100644 --- a/module/story/model.php +++ b/module/story/model.php @@ -198,7 +198,7 @@ class storyModel extends model $data[$i] = new stdclass(); $data[$i]->module = $stories->module[$i] != 'same' ? $stories->module[$i] : ($i == 0 ? 0 : $data[$i-1]->module); $data[$i]->plan = $stories->plan[$i] == 'same' ? ($i != 0 ? $data[$i-1]->plan : 0) : ($stories->plan[$i] != '' ? $stories->plan[$i] : 0); - $data[$i]->title = $stories->title[$i]; + $data[$i]->title = htmlspecialchars($stories->title[$i]); $data[$i]->pri = $stories->pri[$i] != '' ? $stories->pri[$i] : 0; $data[$i]->estimate = $stories->estimate[$i] != '' ? $stories->estimate[$i] : 0; $data[$i]->status = $stories->needReview[$i] == 0 ? 'active' : 'draft'; @@ -223,8 +223,8 @@ class storyModel extends model $specData[$i]->story = $storyID; $specData[$i]->version = 1; - $specData[$i]->title = $stories->title[$i]; - if($stories->spec[$i] != '') $specData[$i]->spec = $stories->spec[$i]; + $specData[$i]->title = htmlspecialchars($stories->title[$i]); + if($stories->spec[$i] != '') $specData[$i]->spec = htmlspecialchars($stories->spec[$i]); $this->dao->insert(TABLE_STORYSPEC)->data($specData[$i])->exec(); $this->loadModel('action'); diff --git a/module/task/model.php b/module/task/model.php index ddfcda0486..f06cf255c0 100644 --- a/module/task/model.php +++ b/module/task/model.php @@ -100,8 +100,8 @@ class taskModel extends model $data[$i]->story = $tasks->story[$i] == 'ditto' ? (isset($data[$i-1]) ? $data[$i-1]->story : 0) : ($tasks->story[$i] ? $tasks->story[$i] : 0); $data[$i]->type = $tasks->type[$i] == 'ditto' ? (isset($data[$i-1]) ? $data[$i-1]->type : 0) : $tasks->type[$i]; $data[$i]->assignedTo = $tasks->assignedTo[$i] == 'ditto' ? (isset($data[$i-1]) ? $data[$i-1]->assignedTo : 0) : $tasks->assignedTo[$i]; - $data[$i]->name = $tasks->name[$i]; - $data[$i]->desc = $tasks->desc[$i]; + $data[$i]->name = htmlspecialchars($tasks->name[$i]); + $data[$i]->desc = htmlspecialchars($tasks->desc[$i]); $data[$i]->pri = $tasks->pri[$i]; $data[$i]->estimate = $tasks->estimate[$i]; $data[$i]->left = $tasks->estimate[$i]; diff --git a/module/testcase/model.php b/module/testcase/model.php index c1b0fa9c3d..97e76c6b9b 100644 --- a/module/testcase/model.php +++ b/module/testcase/model.php @@ -91,7 +91,7 @@ class testcaseModel extends model $data[$i]->module = $cases->module[$i] == 'same' ? ($i == 0 ? 0 : $data[$i-1]->module) : $cases->module[$i]; $data[$i]->type = $cases->type[$i] == 'same' ? ($i == 0 ? '' : $data[$i-1]->type) : $cases->type[$i]; $data[$i]->story = $cases->story[$i] == 'same' ? ($i == 0 ? 0 : $data[$i-1]->story) : $cases->story[$i]; - $data[$i]->title = $cases->title[$i]; + $data[$i]->title = htmlspecialchars($cases->title[$i]); $data[$i]->openedBy = $this->app->user->account; $data[$i]->openedDate = $now; $data[$i]->status = 'normal'; diff --git a/module/todo/model.php b/module/todo/model.php index 57cd9e9b98..21d5514d9b 100644 --- a/module/todo/model.php +++ b/module/todo/model.php @@ -70,8 +70,8 @@ class todoModel extends model } $todo->type = $todos->types[$i]; $todo->pri = $todos->pris[$i]; - $todo->name = isset($todos->names[$i]) ? $todos->names[$i] : ''; - $todo->desc = $todos->descs[$i]; + $todo->name = isset($todos->names[$i]) ? htmlspecialchars($todos->names[$i]) : ''; + $todo->desc = htmlspecialchars($todos->descs[$i]); $todo->begin = $todos->begins[$i]; $todo->end = $todos->ends[$i]; $todo->status = "wait";