From 9a758cab4e88f82f92ffb007a7da6fe648798be1 Mon Sep 17 00:00:00 2001
From: wangyuting <wangyuting@easycorp.ltd>
Date: Thu, 18 Jul 2024 15:07:34 +0800
Subject: [PATCH] * [misc] Optimize the number of feedback awaiting my
 approval.

---
 module/my/model.php | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/module/my/model.php b/module/my/model.php
index 8e5a80913d..e4040afcbb 100644
--- a/module/my/model.php
+++ b/module/my/model.php
@@ -945,15 +945,15 @@ class myModel extends model
     {
         $vision     = $this->config->vision;
         $reviewList = array();
-        if($browseType == 'all' || $browseType == 'demand')                                       $reviewList = array_merge($reviewList, $this->getReviewingDemands());
-        if($browseType == 'all' || $browseType == 'story')                                        $reviewList = array_merge($reviewList, $this->getReviewingStories());
-        if($browseType == 'all' || $browseType == 'epic')                                         $reviewList = array_merge($reviewList, $this->getReviewingStories('id_desc', false, 'epic'));
-        if($browseType == 'all' || $browseType == 'requirement')                                  $reviewList = array_merge($reviewList, $this->getReviewingStories('id_desc', false, 'requirement'));
-        if($vision != 'or' && ($browseType == 'all' || $browseType == 'testcase'))                $reviewList = array_merge($reviewList, $this->getReviewingCases());
-        if($vision != 'or' && ($browseType == 'all' || $browseType == 'project'))                 $reviewList = array_merge($reviewList, $this->getReviewingApprovals());
-        if($browseType == 'all' || $browseType == 'feedback')                                     $reviewList = array_merge($reviewList, $this->getReviewingFeedbacks());
-        if($vision != 'or' && ($browseType == 'all' || $browseType == 'oa'))                      $reviewList = array_merge($reviewList, $this->getReviewingOA());
-        if($browseType == 'all' || !in_array($browseType, $this->config->my->noFlowAuditModules)) $reviewList = array_merge($reviewList, $this->getReviewingFlows($browseType));
+        if($browseType == 'all' || $browseType == 'demand')                                              $reviewList = array_merge($reviewList, $this->getReviewingDemands());
+        if($browseType == 'all' || $browseType == 'story')                                               $reviewList = array_merge($reviewList, $this->getReviewingStories());
+        if($browseType == 'all' || $browseType == 'epic')                                                $reviewList = array_merge($reviewList, $this->getReviewingStories('id_desc', false, 'epic'));
+        if($browseType == 'all' || $browseType == 'requirement')                                         $reviewList = array_merge($reviewList, $this->getReviewingStories('id_desc', false, 'requirement'));
+        if($vision != 'or' && ($browseType == 'all' || $browseType == 'testcase'))                       $reviewList = array_merge($reviewList, $this->getReviewingCases());
+        if($vision != 'or' && ($browseType == 'all' || $browseType == 'project'))                        $reviewList = array_merge($reviewList, $this->getReviewingApprovals());
+        if($vision != 'or' && ($browseType == 'all' || $browseType == 'oa'))                             $reviewList = array_merge($reviewList, $this->getReviewingOA());
+        if($browseType == 'all' || !in_array($browseType, $this->config->my->noFlowAuditModules))        $reviewList = array_merge($reviewList, $this->getReviewingFlows($browseType));
+        if(($browseType == 'all' || $browseType == 'feedback') && common::hasPriv('feedback', 'review')) $reviewList = array_merge($reviewList, $this->getReviewingFeedbacks());
         if(empty($reviewList)) return array();
 
         $field     = $orderBy;