diff --git a/module/todo/js/view.js b/module/todo/js/view.js index 80796b6858..224695541b 100644 --- a/module/todo/js/view.js +++ b/module/todo/js/view.js @@ -41,8 +41,13 @@ $(function() { var onlybody = config.onlybody == 'yes'; var productID = $('#bugProduct').val(); - var link = createLink('bug', 'create', 'productID=' + productID + '&branch=0&extras=todoID=' + todoID, config.defaultView, onlybody); + if(!productID) + { + alert(selectProduct); + return false; + } + var link = createLink('bug', 'create', 'productID=' + productID + '&branch=0&extras=todoID=' + todoID, config.defaultView, onlybody); if(!onlybody) window.parent.$.apps.open(link, 'qa'); if(onlybody) location.href = link; }) diff --git a/module/todo/lang/en.php b/module/todo/lang/en.php index 54481dad81..c3a58f7db6 100644 --- a/module/todo/lang/en.php +++ b/module/todo/lang/en.php @@ -113,6 +113,7 @@ $lang->todo->noTodo = 'No todos of this type.'; $lang->todo->noAssignedTo = "The AssignedTo should not be empty."; $lang->todo->unfinishedTodo = 'The todos of ID %s are not finished, and can not close.'; $lang->todo->today = 'Todo Today'; +$lang->todo->selectProduct = "Please select a product"; $lang->todo->periods['all'] = 'Assigned To Yourself'; $lang->todo->periods['before'] = 'Unfinished'; diff --git a/module/todo/lang/zh-cn.php b/module/todo/lang/zh-cn.php index 1b5124f5fa..5fb2578c24 100644 --- a/module/todo/lang/zh-cn.php +++ b/module/todo/lang/zh-cn.php @@ -113,6 +113,7 @@ $lang->todo->noTodo = '该类型没有待办事务'; $lang->todo->noAssignedTo = '被指派人不能为空'; $lang->todo->unfinishedTodo = '待办ID %s 不是完成状态,不能关闭。'; $lang->todo->today = '今日待办'; +$lang->todo->selectProduct = "请选择产品"; $lang->todo->periods['all'] = '指派自己'; $lang->todo->periods['before'] = '未完'; diff --git a/module/todo/view/view.html.php b/module/todo/view/view.html.php index f7540d8330..2fcf9715a0 100644 --- a/module/todo/view/view.html.php +++ b/module/todo/view/view.html.php @@ -209,14 +209,6 @@ @@ -271,14 +262,6 @@ id);?> execution->selectExecution);?> +todo->selectProduct);?>