From d9194b2a27240f905ca9b846f896634588f85636 Mon Sep 17 00:00:00 2001
From: zenggang <zenggang@easycorp.ltd>
Date: Thu, 10 Feb 2022 07:25:20 +0000
Subject: [PATCH] * Fix bug#19388

---
 module/sonarqube/lang/en.php    | 1 +
 module/sonarqube/lang/zh-cn.php | 1 +
 module/sonarqube/model.php      | 8 +++++---
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/module/sonarqube/lang/en.php b/module/sonarqube/lang/en.php
index c1bea48b42..32c692503a 100644
--- a/module/sonarqube/lang/en.php
+++ b/module/sonarqube/lang/en.php
@@ -42,6 +42,7 @@ $lang->sonarqube->nameRepeatError      = "Server name  already exists!";
 $lang->sonarqube->urlRepeatError       = 'Server address already exists!';
 $lang->sonarqube->validError           = 'SonarQube user authority authentication failed!';
 $lang->sonarqube->hostError            = "Invalid SonarQube service address.";
+$lang->sonarqube->lengthError          = "『%s』length should be <=『%d』";
 $lang->sonarqube->confirmDelete        = 'Do you want to delete this SonarQube server?';
 $lang->sonarqube->confirmDeleteProject = 'Do you want to delete this SonarQube project?';
 $lang->sonarqube->noReport             = "No Reprot";
diff --git a/module/sonarqube/lang/zh-cn.php b/module/sonarqube/lang/zh-cn.php
index 0d2be51294..791445b5a4 100644
--- a/module/sonarqube/lang/zh-cn.php
+++ b/module/sonarqube/lang/zh-cn.php
@@ -42,6 +42,7 @@ $lang->sonarqube->nameRepeatError      = "服务器名称已存在！";
 $lang->sonarqube->urlRepeatError       = "服务器地址已存在！";
 $lang->sonarqube->validError           = "SonarQube 用户权限认证失败！";
 $lang->sonarqube->hostError            = "无效的SonarQube服务地址。";
+$lang->sonarqube->lengthError          = "『%s』长度应当不超过『%d』";
 $lang->sonarqube->confirmDelete        = '确认删除该SonarQube吗？';
 $lang->sonarqube->confirmDeleteProject = '确认删除该SonarQube项目吗？';
 $lang->sonarqube->noReport             = "暂无报告";
diff --git a/module/sonarqube/model.php b/module/sonarqube/model.php
index 6dad63f4da..da5d3c9f9d 100644
--- a/module/sonarqube/model.php
+++ b/module/sonarqube/model.php
@@ -197,9 +197,11 @@ class sonarqubeModel extends model
         $project = fixer::input('post')->get();
 
         $this->dao->insert('sonarqube')->data($project)
-            ->batchCheck($this->config->sonarqube->createproject->requiredFields, 'notempty')
-            ->check('projectName', 'length', 255, 1)
-            ->check('projectKey', 'length', 400, 1);
+            ->batchCheck($this->config->sonarqube->createproject->requiredFields, 'notempty');
+        if(dao::isError()) return false;
+
+        if(mb_strlen($project->projectName) > 255) dao::$errors['projectName'][] = sprintf($this->lang->sonarqube->lengthError, $this->lang->sonarqube->projectName, 255);
+        if(mb_strlen($project->projectKey) > 400) dao::$errors['projectKey'][] = sprintf($this->lang->sonarqube->lengthError, $this->lang->sonarqube->projectKey, 400);
         if(dao::isError()) return false;
 
         $response = $this->apiCreateProject($sonarqubeID, $project);