diff --git a/module/testtask/js/runcase.js b/module/testtask/js/runcase.js index 9cd3df0e2b..43b373f6b9 100644 --- a/module/testtask/js/runcase.js +++ b/module/testtask/js/runcase.js @@ -20,10 +20,9 @@ function deleteFile(fileID) } /* Download a file, append the mouse to the link. Thus we call decide to open the file in browser no download it. */ -function downloadFile(fileID) +function downloadFile(fileID, extension, imageWidth) { if(!fileID) return; - var sessionString = ''; var url = createLink('file', 'download', 'fileID=' + fileID + '&mouse=left') + sessionString; window.open(url, '_blank'); return false; diff --git a/module/testtask/model.php b/module/testtask/model.php index 53d8934f02..f00360f992 100644 --- a/module/testtask/model.php +++ b/module/testtask/model.php @@ -424,18 +424,11 @@ class testtaskModel extends model } /* Create result of every step. */ - if(isset($postData->steps) and $postData->steps) + foreach($postData->steps as $stepID =>$stepResult) { - foreach($postData->steps as $stepID =>$stepResult) - { - $step['result'] = $stepResult; - $step['real'] = $postData->reals[$stepID]; - $stepResults[$stepID] = $step; - } - } - else - { - $stepResults = array(); + $step['result'] = $stepResult; + $step['real'] = $postData->reals[$stepID]; + $stepResults[$stepID] = $step; } /* Insert into testResult table. */ @@ -462,14 +455,7 @@ class testtaskModel extends model if(!dao::isError()) { $resultID = $this->dao->lastInsertID(); - if(!empty($stepResults)) - { - foreach($stepResults as $stepID => $stepResult) $this->loadModel('file')->saveUpload('stepResult', $resultID, $stepID, "files{$stepID}", "labels{$stepID}"); - } - else - { - $this->loadModel('file')->saveUpload('caseResult', $resultID); - } + foreach($stepResults as $stepID => $stepResult) $this->loadModel('file')->saveUpload('stepResult', $resultID, $stepID, "files{$stepID}", "labels{$stepID}"); } $this->dao->update(TABLE_CASE)->set('lastRunner')->eq($this->app->user->account)->set('lastRunDate')->eq($now)->set('lastRunResult')->eq($caseResult)->where('id')->eq($postData->case)->exec(); @@ -488,6 +474,7 @@ class testtaskModel extends model ->exec(); } } + return $caseResult; } /** @@ -520,18 +507,28 @@ class testtaskModel extends model foreach($postData->results as $caseID => $result) { $runID = isset($runs[$caseID]) ? $runs[$caseID] : 0; - $dbSteps = $stepGroups[$caseID]; - $postSteps = $postData->steps[$caseID]; + $dbSteps = isset($stepGroups[$caseID]) ? $stepGroups[$caseID] : array(); + $postSteps = isset($postData->steps[$caseID]) ? $postData->steps[$caseID] : array(); $postReals = $postData->reals[$caseID]; $caseResult = $result ? $result : 'pass'; $stepResults = array(); - foreach($dbSteps as $stepID => $step) + if($dbSteps) + { + foreach($dbSteps as $stepID => $step) + { + $step = array(); + $step['result'] = $caseResult == 'pass' ? $caseResult : $postSteps[$stepID]; + $step['real'] = $caseResult == 'pass' ? '' : $postReals[$stepID]; + $stepResults[$stepID] = $step; + } + } + else { $step = array(); - $step['result'] = $caseResult == 'pass' ? $caseResult : $postSteps[$stepID]; - $step['real'] = $caseResult == 'pass' ? '' : $postReals[$stepID]; - $stepResults[$stepID] = $step; + $step['result'] = $caseResult; + $step['real'] = $caseResult == 'pass' ? '' : $postReals[0]; + $stepResults[] = $step; } $result = new stdClass(); diff --git a/module/testtask/view/batchrun.html.php b/module/testtask/view/batchrun.html.php index 980a583bd3..96781a5933 100644 --- a/module/testtask/view/batchrun.html.php +++ b/module/testtask/view/batchrun.html.php @@ -53,7 +53,9 @@ - + + + diff --git a/module/testtask/view/runcase.html.php b/module/testtask/view/runcase.html.php index 9203f0964d..b139a1d42f 100644 --- a/module/testtask/view/runcase.html.php +++ b/module/testtask/view/runcase.html.php @@ -30,23 +30,28 @@ testcase->stepDesc;?> testcase->stepExpect;?> testcase->result;?> - - testcase->real;?> - case->steps)):?> - - - + testcase->real;?> + case->steps)) + { + $step = new stdclass(); + $step->id = 0; + $step->case = $run->case->id; + $step->desc = ''; + $step->expect = ''; + $run->case->steps[] = $step; + } + ?> case->steps as $key => $step):?> - expect ? 'pass' : 'n/a';?> desc);?> expect);?> - id]", $lang->testcase->resultList, $defaultResult, "class='form-control'");?> + id]", $lang->testcase->resultList, 'pass', "class='form-control'");?> - +
@@ -59,17 +64,8 @@
id]", '', "rows=1 class='form-control autosize'");?> testtask->pre, '', "id='pre' class='btn'"); - if(empty($run->case->steps)) - { - echo html::submitButton($lang->testtask->pass, "onclick=$('#result').val('pass')", 'btn btn-success'); - echo html::submitButton($lang->testtask->fail, "onclick=$('#result').val('fail')", 'btn btn-danger'); - } - else - { - echo html::submitButton(); - } + echo html::submitButton(); if($nextCase) echo html::a(inlink('runCase', "runID={$nextCase['runID']}&caseID={$nextCase['caseID']}&version={$nextCase['version']}"), $lang->testtask->next, '', "id='next' class='btn'"); - if(!$run->case->steps) echo html::hidden('result', ''); echo html::hidden('case', $run->case->id); echo html::hidden('version', $run->case->currentVersion); ?> @@ -77,28 +73,6 @@
- case->steps)):?> - - case->steps as $key => $step):?> -
@@ -143,5 +116,10 @@ $(function() $('#casesResults table caption .result-tip').html($('#resultTip').html()); }); }); +requestType == 'PATH_INFO' ? '?' : '&'; +$sessionString .= session_name() . '=' . session_id(); +?> +var sessionString = '';