diff --git a/module/action/model.php b/module/action/model.php index 9a1cad8dfe..c11a37c62b 100755 --- a/module/action/model.php +++ b/module/action/model.php @@ -632,7 +632,7 @@ class actionModel extends model */ public function logHistory(int $actionID, array $changes): bool { - if(empty($actionID)) return false; + if(empty($actionID) || empty($changes)) return false; foreach($changes as $change) { $change = is_array($change) ? json_decode(json_encode($change)) : $change; @@ -2720,4 +2720,4 @@ class actionModel extends model } return array_values($actions); } -} +} \ No newline at end of file diff --git a/module/testtask/control.php b/module/testtask/control.php index faec68fa19..01bf872ef4 100644 --- a/module/testtask/control.php +++ b/module/testtask/control.php @@ -657,7 +657,7 @@ class testtask extends control if($changes || $this->post->comment) { $actionID = $this->loadModel('action')->create('testtask', $taskID, 'Closed', $this->post->comment); - $this->action->logHistory($actionID, $changes); + if($changes) $this->action->logHistory($actionID, $changes); } $message = $this->executeHooks($taskID) ?: $this->lang->saveSuccess;