From 35932694926df7a7cf6a3e9661400138bb6486f7 Mon Sep 17 00:00:00 2001 From: liumengyi Date: Thu, 19 May 2022 16:30:20 +0800 Subject: [PATCH 1/2] * Fix bug for kanban closed. --- module/kanban/js/view.js | 20 ++++++++------------ module/kanban/view/view.html.php | 3 ++- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/module/kanban/js/view.js b/module/kanban/js/view.js index dd19bfe26a..e11f5e4610 100644 --- a/module/kanban/js/view.js +++ b/module/kanban/js/view.js @@ -151,7 +151,7 @@ function renderHeaderCol($column, column, $header, kanbanData) } var moreAction = ' '; - $actions.html(addItemBtn + moreAction); + if(CRKanban || kanban.status != 'closed') $actions.html(addItemBtn + moreAction); } if(columnPrivs.includes('sortColumn')) @@ -219,7 +219,7 @@ function renderLaneName($lane, lane, $kanban, columns, kanban) $lane.parent().toggleClass('sort', canSort); - if(!$lane.children('.actions').length && (canSet || canDelete)) + if(!$lane.children('.actions').length && (canSet || canDelete) && (CRKanban || kanbanInfo.status != 'closed') ) { $([ '
', @@ -286,7 +286,7 @@ function renderKanbanItem(item, $item) var printMoreBtn = (privs.includes('editCard') || privs.includes('archiveCard') || privs.includes('copyCard') || privs.includes('deleteCard') || privs.includes('moveCard') || privs.includes('setCardColor')); var $actions = $item.children('.actions'); var $title = $item.children('.title'); - if(printMoreBtn && !$actions.length) + if(printMoreBtn && !$actions.length && (CRKanban || kanban.status != 'closed')) { $( [ @@ -962,7 +962,7 @@ function findDropColumns($element, $root) return $root.find('.kanban-lane-col:not([data-type="EMPTY"],[data-type=""])').filter(function() { - if($.cookie('isFullScreen') == 1 || (!CRKanban && kanban.status == 'closed')) return false; + if($.cookie('isFullScreen') == 1 || (!CRKanban && kanbanInfo.status == 'closed')) return false; var $newCol = $(this); var newCol = $newCol.data(); var $newLane = $newCol.closest('.kanban-lane'); @@ -1309,6 +1309,8 @@ $(function() { window.isMultiLanes = laneCount > 1; + $.cookie('isFullScreen', 0); + /* Init first kanban */ $('.kanban').each(function() { @@ -1419,20 +1421,14 @@ $(function() initSortable(); resetRegionHeight('open'); - - if(!CRKanban && kanban.status == "closed") - { - fullScreen(); - $.cookie('isFullScreen', 0); - $('.region-actions > div > .action').show(); - $(".title").attr("disabled", false).css("pointer-events", "auto"); - } + if(!CRKanban && kanbanInfo.status == 'closed') $('.kanban-col.kanban-header-col').css('padding', '0px 0px 0px 0px'); }); function initSortable() { var sortType = ''; var $cards = null; + if(!CRKanban && kanbanInfo.status == 'closed') return; $('#kanban').sortable( { selector: '.region, .kanban-board, .kanban-lane, .kanban-col', diff --git a/module/kanban/view/view.html.php b/module/kanban/view/view.html.php index 636587c745..d77c5837dc 100644 --- a/module/kanban/view/view.html.php +++ b/module/kanban/view/view.html.php @@ -24,6 +24,7 @@ js::set('vision', $this->config->vision); js::set('CRKanban', isset($this->config->CRKanban) ? $this->config->CRKanban : 1); js::set('regions', $regions); js::set('kanban', $kanban); +js::set('kanbanInfo', $kanban); js::set('kanbanLang', $lang->kanban); js::set('kanbanlaneLang', $lang->kanbanlane); js::set('kanbancolumnLang', $lang->kanbancolumn); @@ -58,7 +59,7 @@ $canCreateLane = commonModel::hasPriv('kanban', 'createLane'); name;?>
- + config->CRKanban) and $this->config->CRKanban == '0' and $kanban->status == 'closed')):?>