diff --git a/module/custom/view/code.html.php b/module/custom/view/code.html.php index d3ea25a840..64fa25546e 100644 --- a/module/custom/view/code.html.php +++ b/module/custom/view/code.html.php @@ -39,10 +39,4 @@ - diff --git a/module/execution/model.php b/module/execution/model.php index c1cd90d2fc..6731dc0ddd 100644 --- a/module/execution/model.php +++ b/module/execution/model.php @@ -660,13 +660,12 @@ class executionModel extends model foreach($data->executionIDList as $executionID) { $executionName = $data->names[$executionID]; - $executionCode = $data->codes[$executionID]; + if(isset($data->codes)) $executionCode = $data->codes[$executionID]; $executionID = (int)$executionID; $executions[$executionID] = new stdClass(); $executions[$executionID]->id = $executionID; $executions[$executionID]->name = $executionName; - $executions[$executionID]->code = $executionCode; $executions[$executionID]->PM = $data->PMs[$executionID]; $executions[$executionID]->PO = $data->POs[$executionID]; $executions[$executionID]->QD = $data->QDs[$executionID]; @@ -680,13 +679,15 @@ class executionModel extends model $executions[$executionID]->days = $data->dayses[$executionID]; $executions[$executionID]->lastEditedBy = $this->app->user->account; $executions[$executionID]->lastEditedDate = helper::now(); + + if(isset($data->codes)) $executions[$executionID]->code = $executionCode; if(isset($data->projects)) $executions[$executionID]->project = zget($data->projects, $executionID, 0); if(isset($data->attributes)) $executions[$executionID]->attribute = zget($data->attributes, $executionID, ''); if($executions[$executionID]->status == 'closed') $executions[$executionID]->closedDate = helper::now(); if($executions[$executionID]->status == 'suspended') $executions[$executionID]->suspendedDate = helper::today(); /* Check unique code for edited executions. */ - if($projectModel == 'scrum' and empty($executionCode) and (!isset($this->config->setCode) or $this->config->setCode == 1)) + if($projectModel == 'scrum' and isset($executionCode) and empty($executionCode)) { dao::$errors['code'][] = 'execution#' . $executionID . sprintf($this->lang->error->notempty, $this->lang->project->code); return false; diff --git a/module/execution/view/batchedit.html.php b/module/execution/view/batchedit.html.php index aa395cbe56..e9a76ecae3 100755 --- a/module/execution/view/batchedit.html.php +++ b/module/execution/view/batchedit.html.php @@ -34,14 +34,13 @@ if(strpos(",{$config->execution->customBatchEditFields},", ",{$field},") !== false) $visibleFields[$field] = ''; } } - $minWidth = (count($visibleFields) > 5) ? 'w-150px' : ''; - $name = $from == 'execution' ? 'execName' : 'name'; - $code = $from == 'execution' ? 'execCode' : 'code'; - $PM = $from == 'execution' ? 'execPM' : 'PM'; - $type = $from == 'execution' ? 'execType' : 'type'; - $desc = $from == 'execution' ? 'execDesc' : 'desc'; - $status = $from == 'execution' ? 'execStatus' : 'status'; - $hiddenCode = (isset($config->setCode) and $config->setCode == 0) ? 'hidden' : ''; + $minWidth = (count($visibleFields) > 5) ? 'w-150px' : ''; + $name = $from == 'execution' ? 'execName' : 'name'; + $code = $from == 'execution' ? 'execCode' : 'code'; + $PM = $from == 'execution' ? 'execPM' : 'PM'; + $type = $from == 'execution' ? 'execType' : 'type'; + $desc = $from == 'execution' ? 'execDesc' : 'desc'; + $status = $from == 'execution' ? 'execStatus' : 'status'; ?>
'>
@@ -53,7 +52,9 @@ execution->projectName;?> execution->$name;?> - execution->$code;?> + setCode) and $config->setCode == 1):?> + execution->$code;?> + '>execution->$PM;?> '>execution->PO;?> '>execution->QD;?> @@ -85,7 +86,9 @@ project, "class='form-control picker-select' data-lastselected='{$executions[$executionID]->project}' onchange='changeProject(this, $executionID, {$executions[$executionID]->project})'");?> name, "id='names{$executionID}' class='form-control'");?> - code, "class='form-control'");?> + setCode) and $config->setCode == 1):?> + code, "class='form-control'");?> + ' style='overflow:visible'>PM, "class='form-control picker-select'");?> ' style='overflow:visible'>PO, "class='form-control picker-select'");?> ' style='overflow:visible'>QD, "class='form-control picker-select'");?> diff --git a/module/project/config.php b/module/project/config.php index 6df296e022..c75ee66c9e 100644 --- a/module/project/config.php +++ b/module/project/config.php @@ -137,7 +137,7 @@ $config->project->maxCheckList->waterfall = array('execution', 'design', 'doc', $config->project->search['module'] = 'project'; $config->project->search['fields']['name'] = $lang->project->name; -if(!isset($config->setCode) or $config->setCode == 1 )$config->project->search['fields']['code'] = $lang->project->code; +if(!isset($config->setCode) or $config->setCode == 1) $config->project->search['fields']['code'] = $lang->project->code; $config->project->search['fields']['id'] = $lang->project->id; $config->project->search['fields']['model'] = $lang->project->model; $config->project->search['fields']['parent'] = $lang->project->parent; diff --git a/module/project/model.php b/module/project/model.php index 5a78b6ed6a..5cc3740b7f 100644 --- a/module/project/model.php +++ b/module/project/model.php @@ -1524,13 +1524,12 @@ class projectModel extends model { $projectID = (int)$projectID; $projectName = $data->names[$projectID]; - $projectCode = $data->codes[$projectID]; + if(isset($data->codes)) $projectCode = $data->codes[$projectID]; $projects[$projectID] = new stdClass(); if(isset($data->parents[$projectID])) $projects[$projectID]->parent = $data->parents[$projectID]; $projects[$projectID]->id = $projectID; $projects[$projectID]->name = $projectName; - $projects[$projectID]->code = $projectCode; $projects[$projectID]->model = $oldProjects[$projectID]->model; $projects[$projectID]->PM = $data->PMs[$projectID]; $projects[$projectID]->begin = $data->begins[$projectID]; @@ -1540,6 +1539,7 @@ class projectModel extends model $projects[$projectID]->lastEditedBy = $this->app->user->account; $projects[$projectID]->lastEditedDate = helper::now(); + if(isset($data->codes)) $projects[$projectID]->code = $projectCode; if($projects[$projectID]->parent) { $parentProject = $this->dao->select('*')->from(TABLE_PROGRAM)->where('id')->eq($projects[$projectID]->parent)->fetch(); @@ -1570,9 +1570,6 @@ class projectModel extends model } if(dao::isError()) return false; - $requiredFields = $this->config->project->edit->requiredFields; - if(isset($this->config->setCode) and $this->config->setCode == 0) $requiredFields = trim(str_replace(',code,', ',', ",{$requiredFields},"), ','); - foreach($projects as $projectID => $project) { $oldProject = $oldProjects[$projectID]; @@ -1580,7 +1577,7 @@ class projectModel extends model $this->dao->update(TABLE_PROJECT)->data($project) ->autoCheck($skipFields = 'begin,end') - ->batchCheck($requiredFields, 'notempty') + ->batchCheck($this->config->project->edit->requiredFields, 'notempty') ->checkIF($project->begin != '', 'begin', 'date') ->checkIF($project->end != '', 'end', 'date') ->checkIF($project->end != '', 'end', 'gt', $project->begin) diff --git a/module/project/view/batchedit.html.php b/module/project/view/batchedit.html.php index 955352af03..2a3674c3d3 100644 --- a/module/project/view/batchedit.html.php +++ b/module/project/view/batchedit.html.php @@ -19,7 +19,6 @@

project->batchEdit;?>

- setCode) and $config->setCode == 0) ? 'hidden' : '';?> @@ -27,7 +26,9 @@ - + setCode) and $config->setCode == 1):?> + + @@ -52,7 +53,9 @@ - + setCode) and $config->setCode == 1):?> + +
idAB;?> project->parent;?> project->name;?>project->code;?>project->code;?> project->PM;?> project->begin;?> project->end;?>parent, "class='form-control chosen' data-id='$projectID' data-name='{$project->name}' data-parent='{$project->parent}'");?> name, "class='form-control'");?>code, "class='form-control'");?>code, "class='form-control'");?> PM, "class='form-control chosen'");?> begin, "class='form-control form-date' onchange='computeWorkDays(this.id);' placeholder='" . $lang->project->begin . "'");?>